sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-10-04 04:29:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address CodeRabbit review on DNAT refcount

Browse Source
This commit is contained in:
Viktor Liu
2026-05-25 12:14:27 +02:00
parent ddc9f8199a
commit 3b8a5c15cc
3 changed files with 27 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/firewall/iptables/dnat_refcount_linux_test.go
+8 -4
View File
@@ -85,12 +85,14 @@ func TestIptablesDNAT_RefcountBalancedV4(t *testing.T) {
r2, err := m.AddDNATRule(iptDnatV4(7082))
require.NoError(t, err, "add v4 dnat 2")
v4, _ = state.Counts()
v4, v6 = state.Counts()
require.Equal(t, 2, v4, "v4 refcount after second add")
require.Equal(t, 0, v6, "v6 refcount unchanged")
require.NoError(t, m.DeleteDNATRule(r1))
v4, _ = state.Counts()
v4, v6 = state.Counts()
require.Equal(t, 1, v4, "v4 refcount after first delete")
require.Equal(t, 0, v6, "v6 refcount unchanged")
require.NoError(t, m.DeleteDNATRule(r2))
v4, v6 = state.Counts()
@@ -114,11 +116,13 @@ func TestIptablesDNAT_RefcountBalancedV6(t *testing.T) {
r2, err := m.AddDNATRule(iptDnatV6(9082))
require.NoError(t, err, "add v6 dnat 2")
_, v6 = state.Counts()
v4, v6 = state.Counts()
require.Equal(t, 0, v4, "v4 refcount unchanged")
require.Equal(t, 2, v6, "v6 refcount after second add")
require.NoError(t, m.DeleteDNATRule(r1))
_, v6 = state.Counts()
v4, v6 = state.Counts()
require.Equal(t, 0, v4, "v4 refcount unchanged")
require.Equal(t, 1, v6, "v6 refcount after first delete")
require.NoError(t, m.DeleteDNATRule(r2))