sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-10-29 07:49:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

[client] Mark Rosenpass as deprecated (#8372)

Browse Source 
* [client] Mark Rosenpass flags as deprecated

Rosenpass support is being deprecated. Users enabling it from the CLI
should learn that before they depend on it, while the feature itself
keeps working.

* [client] Show Rosenpass deprecation notice in the UI settings

Desktop users enable Rosenpass from the settings toggle, not the CLI,
so the deprecation notice needs to reach them there too. A new string
key falls back to English until Crowdin translates it, instead of
showing a stale translation without the notice.

* [client] Keep switchOrCreateProfile doc comment attached

The Rosenpass warning helper landed between switchOrCreateProfile and
its doc comment, leaving the function undocumented.

* [client] Use MarkDeprecated for the Rosenpass flags

Follows the convention already used for --enable-lazy-connection, as
asked in review. The flags drop out of --help and pflag warns on any
use, so the custom helper is no longer needed.

* [client] Isolate the Rosenpass flag test from upCmd's flag set

Setting the shared upCmd flags left them marked Changed for any later
test in the package.
This commit is contained in:
Riccardo Manfrin
2026-10-27 14:01:16 +01:00
committed by GitHub
parent 2c68a84a97
commit 36339993bc
4 changed files with 50 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/ui/frontend/src/modules/settings/SettingsSecurity.tsx
+8 -1
View File
@@ -42,7 +42,14 @@ export function SettingsSecurity() {
if (!v) setField("rosenpassPermissive", false);
}}
label={t("settings.security.rosenpass.label")}
helpText={t("settings.security.rosenpass.help")}
helpText={
<>
{t("settings.security.rosenpass.help")}
<span className={"mt-1 block"}>
{t("settings.security.rosenpass.deprecated")}
</span>
</>
}
/>
)}
{!hideRosenpassPermissive && (