sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-10-27 06:49:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

[client] Report a missing OS user in the SSH login error message

Browse Source 
The session handler mapped a failed user lookup to the generic
"User authentication failed", which reads as a rejected SSO login even
though the JWT was accepted. Name the missing user instead.
This commit is contained in:
Zoltan Papp
2026-09-07 23:42:27 +02:00
parent 5cb6b0d33b
commit 32bfc48960
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/ssh/server/session_handlers.go
+4
View File
@@ -119,8 +119,12 @@ func (s *Server) handlePrivError(logger *log.Entry, session ssh.Session, err err
// buildUserLookupErrorMessage creates appropriate user-facing error messages based on error type // buildUserLookupErrorMessage creates appropriate user-facing error messages based on error type
func (s *Server) buildUserLookupErrorMessage(err error) string { func (s *Server) buildUserLookupErrorMessage(err error) string {
var privilegedErr *PrivilegedUserError var privilegedErr *PrivilegedUserError
var notFoundErr *UserNotFoundError
switch { switch {
case errors.As(err, &notFoundErr):
return fmt.Sprintf("user %q does not exist on this host\n", notFoundErr.Username)
case errors.As(err, &privilegedErr): case errors.As(err, &privilegedErr):
if privilegedErr.Username == "root" { if privilegedErr.Username == "root" {
return "root login is disabled on this SSH server\n" return "root login is disabled on this SSH server\n"