From 2befe96c314822c55bda796fc32af567771a3f5e Mon Sep 17 00:00:00 2001 From: riccardom Date: Mon, 14 Sep 2026 09:18:44 +0200 Subject: [PATCH] [client] Say in --upload-bundle-url's help that the default can be NetBird's service The text described the empty flag as "the one the management server publishes" and stopped there, so a reader had no way to know what happens when it publishes none. Name the fallback, and scope the root requirement to a host other than NetBird's rather than to setting the flag at all. Reported by cubic on #7514. --- client/cmd/debug.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/client/cmd/debug.go b/client/cmd/debug.go index 09a53d96d..bc2be1e99 100644 --- a/client/cmd/debug.go +++ b/client/cmd/debug.go @@ -27,11 +27,12 @@ const errCloseConnection = "Failed to close connection: %v" // uploadBundleURLUsage documents that an empty flag is not "no upload" but // "wherever this deployment says": the daemon takes the destination from the -// management server, and only falls back to the service NetBird runs for a peer -// enrolled with NetBird's cloud. Naming another one requires root, since the -// daemon fetches the URL and PUTs its own logs and state to whatever it returns. +// management server, falling back to the service NetBird runs when none is +// published. Naming another host requires root, since the daemon fetches the URL +// and PUTs its own logs and state to whatever it returns. const uploadBundleURLUsage = "Upload service URL to get an upload URL from. " + - "Defaults to the one the management server publishes; requires root when set explicitly" + "Defaults to the one the management server publishes, or to NetBird's service when it publishes none; " + + "naming any host other than NetBird's requires root" var ( logFileCount uint32