sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-05-21 08:09:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Accept any RGB shift permutation as Tight-compatible per RFB 7.7.6

Browse Source
This commit is contained in:
Viktor Liu
2026-05-19 12:19:05 +02:00
parent 9d189bb3e8
commit 24a5f2252c
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
client/vnc/server/session_encode.go
View File

@@ -409,8 +409,12 @@ func drainRequests(ch chan fbRequest) int {
}
// pfIsTightCompatible reports whether the negotiated client pixel format
// matches Tight's TPIXEL constraint: standard RGB shifts (R=16, G=8, B=0).
// bpp/endianness/channel-max are already locked at SetPixelFormat time.
// satisfies Tight's TPIXEL constraint (RFB 7.7.6): the three RGB shifts form
// a permutation of {0, 8, 16} so the colour values live in the low 24 bits.
// bpp, endianness, and 8-bit channels are already enforced at SetPixelFormat
// time. Any permutation works because Tight always emits a three-byte R, G,
// B triple regardless of where the client stores each channel.
func pfIsTightCompatible(pf clientPixelFormat) bool {
return pf.rShift == 16 && pf.gShift == 8 && pf.bShift == 0
shifts := uint32(1)<<pf.rShift | uint32(1)<<pf.gShift | uint32(1)<<pf.bShift
return shifts == 1<<0|1<<8|1<<16
}