diff --git a/client/cmd/testutil_test.go b/client/cmd/testutil_test.go index 258a8daff..9bd13ec02 100644 --- a/client/cmd/testutil_test.go +++ b/client/cmd/testutil_test.go @@ -83,7 +83,6 @@ func startManagement(t *testing.T, config *types.Config, testFile string) (*grpc } t.Cleanup(cleanUp) - peersUpdateManager := mgmt.NewPeersUpdateManager(nil) eventStore := &activity.InMemoryEventStore{} if err != nil { return nil, nil @@ -92,6 +91,9 @@ func startManagement(t *testing.T, config *types.Config, testFile string) (*grpc metrics, err := telemetry.NewDefaultAppMetrics(context.Background()) require.NoError(t, err) + + peersUpdateManager := mgmt.NewPeersUpdateManager(metrics) + ctrl := gomock.NewController(t) t.Cleanup(ctrl.Finish) diff --git a/client/internal/engine_test.go b/client/internal/engine_test.go index 8c084e366..4a00f452a 100644 --- a/client/internal/engine_test.go +++ b/client/internal/engine_test.go @@ -1456,16 +1456,16 @@ func startManagement(t *testing.T, dataDir, testFile string) (*grpc.Server, stri } t.Cleanup(cleanUp) - peersUpdateManager := server.NewPeersUpdateManager(nil) + metrics, err := telemetry.NewDefaultAppMetrics(context.Background()) + require.NoError(t, err) + + peersUpdateManager := server.NewPeersUpdateManager(metrics) eventStore := &activity.InMemoryEventStore{} if err != nil { return nil, "", err } ia, _ := integrations.NewIntegratedValidator(context.Background(), eventStore) - metrics, err := telemetry.NewDefaultAppMetrics(context.Background()) - require.NoError(t, err) - ctrl := gomock.NewController(t) t.Cleanup(ctrl.Finish) settingsMockManager := settings.NewMockManager(ctrl) diff --git a/client/server/server_test.go b/client/server/server_test.go index f2dff76fd..f423b3ff6 100644 --- a/client/server/server_test.go +++ b/client/server/server_test.go @@ -191,16 +191,16 @@ func startManagement(t *testing.T, signalAddr string, counter *int) (*grpc.Serve } t.Cleanup(cleanUp) - peersUpdateManager := server.NewPeersUpdateManager(nil) + metrics, err := telemetry.NewDefaultAppMetrics(context.Background()) + require.NoError(t, err) + + peersUpdateManager := server.NewPeersUpdateManager(metrics) eventStore := &activity.InMemoryEventStore{} if err != nil { return nil, "", err } ia, _ := integrations.NewIntegratedValidator(context.Background(), eventStore) - metrics, err := telemetry.NewDefaultAppMetrics(context.Background()) - require.NoError(t, err) - ctrl := gomock.NewController(t) t.Cleanup(ctrl.Finish) settingsMockManager := settings.NewMockManager(ctrl) diff --git a/management/client/client_test.go b/management/client/client_test.go index b22a79930..25a317a21 100644 --- a/management/client/client_test.go +++ b/management/client/client_test.go @@ -68,13 +68,13 @@ func startManagement(t *testing.T) (*grpc.Server, net.Listener) { } t.Cleanup(cleanUp) - peersUpdateManager := mgmt.NewPeersUpdateManager(nil) - eventStore := &activity.InMemoryEventStore{} - ia, _ := integrations.NewIntegratedValidator(context.Background(), eventStore) - metrics, err := telemetry.NewDefaultAppMetrics(context.Background()) require.NoError(t, err) + peersUpdateManager := mgmt.NewPeersUpdateManager(metrics) + eventStore := &activity.InMemoryEventStore{} + ia, _ := integrations.NewIntegratedValidator(context.Background(), eventStore) + ctrl := gomock.NewController(t) t.Cleanup(ctrl.Finish) settingsMockManager := settings.NewMockManager(ctrl) diff --git a/management/server/dns_test.go b/management/server/dns_test.go index 0577e1d30..944b4bd8c 100644 --- a/management/server/dns_test.go +++ b/management/server/dns_test.go @@ -217,7 +217,7 @@ func createDNSManager(t *testing.T) (*DefaultAccountManager, error) { settingsMockManager := settings.NewMockManager(ctrl) permissionsManager := permissions.NewManager(store) - return BuildManager(context.Background(), store, NewPeersUpdateManager(nil), nil, "", "netbird.test", eventStore, nil, false, MocIntegratedValidator{}, metrics, port_forwarding.NewControllerMock(), settingsMockManager, permissionsManager) + return BuildManager(context.Background(), store, NewPeersUpdateManager(metrics), nil, "", "netbird.test", eventStore, nil, false, MocIntegratedValidator{}, metrics, port_forwarding.NewControllerMock(), settingsMockManager, permissionsManager) } func createDNSStore(t *testing.T) (store.Store, error) { diff --git a/management/server/management_proto_test.go b/management/server/management_proto_test.go index b85a43da4..838301a5b 100644 --- a/management/server/management_proto_test.go +++ b/management/server/management_proto_test.go @@ -424,14 +424,14 @@ func startManagementForTest(t *testing.T, testFile string, config *types.Config) t.Fatal(err) } - peersUpdateManager := NewPeersUpdateManager(nil) + metrics, err := telemetry.NewDefaultAppMetrics(context.Background()) + require.NoError(t, err) + + peersUpdateManager := NewPeersUpdateManager(metrics) eventStore := &activity.InMemoryEventStore{} ctx := context.WithValue(context.Background(), hook.ExecutionContextKey, hook.SystemSource) //nolint:staticcheck - metrics, err := telemetry.NewDefaultAppMetrics(context.Background()) - require.NoError(t, err) - ctrl := gomock.NewController(t) t.Cleanup(ctrl.Finish) settingsMockManager := settings.NewMockManager(ctrl) diff --git a/management/server/nameserver_test.go b/management/server/nameserver_test.go index 0fe2a3aa3..26fa0ee7a 100644 --- a/management/server/nameserver_test.go +++ b/management/server/nameserver_test.go @@ -779,7 +779,7 @@ func createNSManager(t *testing.T) (*DefaultAccountManager, error) { t.Cleanup(ctrl.Finish) settingsMockManager := settings.NewMockManager(ctrl) permissionsManager := permissions.NewManager(store) - return BuildManager(context.Background(), store, NewPeersUpdateManager(nil), nil, "", "netbird.selfhosted", eventStore, nil, false, MocIntegratedValidator{}, metrics, port_forwarding.NewControllerMock(), settingsMockManager, permissionsManager) + return BuildManager(context.Background(), store, NewPeersUpdateManager(metrics), nil, "", "netbird.selfhosted", eventStore, nil, false, MocIntegratedValidator{}, metrics, port_forwarding.NewControllerMock(), settingsMockManager, permissionsManager) } func createNSStore(t *testing.T) (store.Store, error) { diff --git a/management/server/peer_test.go b/management/server/peer_test.go index 6a67dd126..a8ba0fae7 100644 --- a/management/server/peer_test.go +++ b/management/server/peer_test.go @@ -1279,7 +1279,7 @@ func Test_RegisterPeerByUser(t *testing.T) { settingsMockManager := settings.NewMockManager(ctrl) permissionsManager := permissions.NewManager(s) - am, err := BuildManager(context.Background(), s, NewPeersUpdateManager(nil), nil, "", "netbird.cloud", eventStore, nil, false, MocIntegratedValidator{}, metrics, port_forwarding.NewControllerMock(), settingsMockManager, permissionsManager) + am, err := BuildManager(context.Background(), s, NewPeersUpdateManager(metrics), nil, "", "netbird.cloud", eventStore, nil, false, MocIntegratedValidator{}, metrics, port_forwarding.NewControllerMock(), settingsMockManager, permissionsManager) assert.NoError(t, err) existingAccountID := "bf1c8084-ba50-4ce7-9439-34653001fc3b" @@ -1354,7 +1354,7 @@ func Test_RegisterPeerBySetupKey(t *testing.T) { settingsMockManager := settings.NewMockManager(ctrl) permissionsManager := permissions.NewManager(s) - am, err := BuildManager(context.Background(), s, NewPeersUpdateManager(nil), nil, "", "netbird.cloud", eventStore, nil, false, MocIntegratedValidator{}, metrics, port_forwarding.NewControllerMock(), settingsMockManager, permissionsManager) + am, err := BuildManager(context.Background(), s, NewPeersUpdateManager(metrics), nil, "", "netbird.cloud", eventStore, nil, false, MocIntegratedValidator{}, metrics, port_forwarding.NewControllerMock(), settingsMockManager, permissionsManager) assert.NoError(t, err) existingAccountID := "bf1c8084-ba50-4ce7-9439-34653001fc3b" @@ -1489,7 +1489,7 @@ func Test_RegisterPeerRollbackOnFailure(t *testing.T) { permissionsManager := permissions.NewManager(s) - am, err := BuildManager(context.Background(), s, NewPeersUpdateManager(nil), nil, "", "netbird.cloud", eventStore, nil, false, MocIntegratedValidator{}, metrics, port_forwarding.NewControllerMock(), settingsMockManager, permissionsManager) + am, err := BuildManager(context.Background(), s, NewPeersUpdateManager(metrics), nil, "", "netbird.cloud", eventStore, nil, false, MocIntegratedValidator{}, metrics, port_forwarding.NewControllerMock(), settingsMockManager, permissionsManager) assert.NoError(t, err) existingAccountID := "bf1c8084-ba50-4ce7-9439-34653001fc3b" @@ -1558,7 +1558,7 @@ func Test_LoginPeer(t *testing.T) { settingsMockManager := settings.NewMockManager(ctrl) permissionsManager := permissions.NewManager(s) - am, err := BuildManager(context.Background(), s, NewPeersUpdateManager(nil), nil, "", "netbird.cloud", eventStore, nil, false, MocIntegratedValidator{}, metrics, port_forwarding.NewControllerMock(), settingsMockManager, permissionsManager) + am, err := BuildManager(context.Background(), s, NewPeersUpdateManager(metrics), nil, "", "netbird.cloud", eventStore, nil, false, MocIntegratedValidator{}, metrics, port_forwarding.NewControllerMock(), settingsMockManager, permissionsManager) assert.NoError(t, err) existingAccountID := "bf1c8084-ba50-4ce7-9439-34653001fc3b" diff --git a/management/server/token_mgr_test.go b/management/server/token_mgr_test.go index 150ab28ab..c4b8fb609 100644 --- a/management/server/token_mgr_test.go +++ b/management/server/token_mgr_test.go @@ -30,7 +30,11 @@ var TurnTestHost = &types.Host{ func TestTimeBasedAuthSecretsManager_GenerateCredentials(t *testing.T) { ttl := util.Duration{Duration: time.Hour} secret := "some_secret" - peersManager := NewPeersUpdateManager(nil) + metrics, err := telemetry.NewDefaultAppMetrics(context.Background()) + if err != nil { + t.Fatalf("failed to create metrics: %v", err) + } + peersManager := NewPeersUpdateManager(metrics) rc := &types.Relay{ Addresses: []string{"localhost:0"}, @@ -198,7 +202,11 @@ loop: func TestTimeBasedAuthSecretsManager_CancelRefresh(t *testing.T) { ttl := util.Duration{Duration: time.Hour} secret := "some_secret" - peersManager := NewPeersUpdateManager(nil) + metrics, err := telemetry.NewDefaultAppMetrics(context.Background()) + if err != nil { + t.Fatalf("failed to create metrics: %v", err) + } + peersManager := NewPeersUpdateManager(metrics) peer := "some_peer" rc := &types.Relay{