mirror of
https://github.com/netbirdio/netbird.git
synced 2026-05-05 08:36:37 +00:00
Always remove invalid-routed block rules in DisableRouting
This commit is contained in:
@@ -1552,16 +1552,6 @@ func (m *Manager) DisableRouting() error {
|
||||
m.routingEnabled.Store(false)
|
||||
m.nativeRouter.Store(false)
|
||||
|
||||
// don't stop forwarder if in use by netstack
|
||||
if m.netstack && m.localForwarding {
|
||||
return nil
|
||||
}
|
||||
|
||||
fwder.Stop()
|
||||
m.forwarder.Store(nil)
|
||||
|
||||
log.Debug("forwarder stopped")
|
||||
|
||||
var merr *multierror.Error
|
||||
for _, rule := range m.blockRules {
|
||||
if err := m.deleteRouteRule(rule); err != nil {
|
||||
@@ -1570,6 +1560,15 @@ func (m *Manager) DisableRouting() error {
|
||||
}
|
||||
m.blockRules = nil
|
||||
|
||||
if m.netstack && m.localForwarding {
|
||||
return nberrors.FormatErrorOrNil(merr)
|
||||
}
|
||||
|
||||
fwder.Stop()
|
||||
m.forwarder.Store(nil)
|
||||
|
||||
log.Debug("forwarder stopped")
|
||||
|
||||
return nberrors.FormatErrorOrNil(merr)
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user