diff --git a/client/iface/bind/ice_bind.go b/client/iface/bind/ice_bind.go index a9c25950d..41f415af7 100644 --- a/client/iface/bind/ice_bind.go +++ b/client/iface/bind/ice_bind.go @@ -12,6 +12,7 @@ import ( "github.com/pion/transport/v3" log "github.com/sirupsen/logrus" "golang.org/x/net/ipv4" + "golang.org/x/net/ipv6" wgConn "golang.zx2c4.com/wireguard/conn" ) @@ -24,8 +25,8 @@ type receiverCreator struct { iceBind *ICEBind } -func (rc receiverCreator) CreateIPv4ReceiverFn(msgPool *sync.Pool, pc *ipv4.PacketConn, conn *net.UDPConn) wgConn.ReceiveFunc { - return rc.iceBind.createIPv4ReceiverFn(msgPool, pc, conn) +func (rc receiverCreator) CreateIPv4ReceiverFn(pc *ipv4.PacketConn, conn *net.UDPConn, rxOffload bool, msgPool *sync.Pool) wgConn.ReceiveFunc { + return rc.iceBind.createIPv4ReceiverFn(pc, conn, rxOffload, msgPool) } // ICEBind is a bind implementation with two main features: @@ -154,7 +155,7 @@ func (b *ICEBind) Send(bufs [][]byte, ep wgConn.Endpoint) error { return nil } -func (s *ICEBind) createIPv4ReceiverFn(ipv4MsgsPool *sync.Pool, pc *ipv4.PacketConn, conn *net.UDPConn) wgConn.ReceiveFunc { +func (s *ICEBind) createIPv4ReceiverFn(pc *ipv4.PacketConn, conn *net.UDPConn, rxOffload bool, msgsPool *sync.Pool) wgConn.ReceiveFunc { s.muUDPMux.Lock() defer s.muUDPMux.Unlock() @@ -166,16 +167,30 @@ func (s *ICEBind) createIPv4ReceiverFn(ipv4MsgsPool *sync.Pool, pc *ipv4.PacketC }, ) return func(bufs [][]byte, sizes []int, eps []wgConn.Endpoint) (n int, err error) { - msgs := ipv4MsgsPool.Get().(*[]ipv4.Message) - defer ipv4MsgsPool.Put(msgs) + msgs := getMessages(msgsPool) for i := range bufs { (*msgs)[i].Buffers[0] = bufs[i] + (*msgs)[i].OOB = (*msgs)[i].OOB[:cap((*msgs)[i].OOB)] } + defer putMessages(msgs, msgsPool) var numMsgs int - if runtime.GOOS == "linux" { - numMsgs, err = pc.ReadBatch(*msgs, 0) - if err != nil { - return 0, err + if runtime.GOOS == "linux" || runtime.GOOS == "android" { + if rxOffload { + readAt := len(*msgs) - (wgConn.IdealBatchSize / wgConn.UdpSegmentMaxDatagrams) + //nolint + numMsgs, err = pc.ReadBatch((*msgs)[readAt:], 0) + if err != nil { + return 0, err + } + numMsgs, err = wgConn.SplitCoalescedMessages(*msgs, readAt, wgConn.GetGSOSize) + if err != nil { + return 0, err + } + } else { + numMsgs, err = pc.ReadBatch(*msgs, 0) + if err != nil { + return 0, err + } } } else { msg := &(*msgs)[0] @@ -191,11 +206,12 @@ func (s *ICEBind) createIPv4ReceiverFn(ipv4MsgsPool *sync.Pool, pc *ipv4.PacketC // todo: handle err ok, _ := s.filterOutStunMessages(msg.Buffers, msg.N, msg.Addr) if ok { - sizes[i] = 0 - } else { - sizes[i] = msg.N + continue + } + sizes[i] = msg.N + if sizes[i] == 0 { + continue } - addrPort := msg.Addr.(*net.UDPAddr).AddrPort() ep := &wgConn.StdNetEndpoint{AddrPort: addrPort} // TODO: remove allocation wgConn.GetSrcFromControl(msg.OOB[:msg.NN], ep) @@ -273,3 +289,15 @@ func fakeAddress(peerAddress *net.UDPAddr) (*net.UDPAddr, error) { } return newAddr, nil } + +func getMessages(msgsPool *sync.Pool) *[]ipv6.Message { + return msgsPool.Get().(*[]ipv6.Message) +} + +func putMessages(msgs *[]ipv6.Message, msgsPool *sync.Pool) { + for i := range *msgs { + (*msgs)[i].OOB = (*msgs)[i].OOB[:0] + (*msgs)[i] = ipv6.Message{Buffers: (*msgs)[i].Buffers, OOB: (*msgs)[i].OOB} + } + msgsPool.Put(msgs) +} diff --git a/go.mod b/go.mod index 51e2eed8d..f3b633dfc 100644 --- a/go.mod +++ b/go.mod @@ -240,7 +240,7 @@ replace github.com/kardianos/service => github.com/netbirdio/service v0.0.0-2024 replace github.com/getlantern/systray => github.com/netbirdio/systray v0.0.0-20231030152038-ef1ed2a27949 -replace golang.zx2c4.com/wireguard => github.com/netbirdio/wireguard-go v0.0.0-20240105182236-6c340dd55aed +replace golang.zx2c4.com/wireguard => github.com/netbirdio/wireguard-go v0.0.0-20241107152827-57d8513b5f73 replace github.com/cloudflare/circl => github.com/cunicu/circl v0.0.0-20230801113412-fec58fc7b5f6 diff --git a/go.sum b/go.sum index 247c10f64..59cbdd959 100644 --- a/go.sum +++ b/go.sum @@ -532,8 +532,8 @@ github.com/netbirdio/service v0.0.0-20240911161631-f62744f42502 h1:3tHlFmhTdX9ax github.com/netbirdio/service v0.0.0-20240911161631-f62744f42502/go.mod h1:CIMRFEJVL+0DS1a3Nx06NaMn4Dz63Ng6O7dl0qH0zVM= github.com/netbirdio/signal-dispatcher/dispatcher v0.0.0-20241010133937-e0df50df217d h1:bRq5TKgC7Iq20pDiuC54yXaWnAVeS5PdGpSokFTlR28= github.com/netbirdio/signal-dispatcher/dispatcher v0.0.0-20241010133937-e0df50df217d/go.mod h1:5/sjFmLb8O96B5737VCqhHyGRzNFIaN/Bu7ZodXc3qQ= -github.com/netbirdio/wireguard-go v0.0.0-20240105182236-6c340dd55aed h1:t0UADZUJDaaZgfKrt8JUPrOLL9Mg/ryjP85RAH53qgs= -github.com/netbirdio/wireguard-go v0.0.0-20240105182236-6c340dd55aed/go.mod h1:tkCQ4FQXmpAgYVh++1cq16/dH4QJtmvpRv19DWGAHSA= +github.com/netbirdio/wireguard-go v0.0.0-20241107152827-57d8513b5f73 h1:jayg97LH/jJlvpIHVxueTfa+tfQ+FY8fy2sIhCwkz0g= +github.com/netbirdio/wireguard-go v0.0.0-20241107152827-57d8513b5f73/go.mod h1:tkCQ4FQXmpAgYVh++1cq16/dH4QJtmvpRv19DWGAHSA= github.com/nicksnyder/go-i18n/v2 v2.4.0 h1:3IcvPOAvnCKwNm0TB0dLDTuawWEj+ax/RERNC+diLMM= github.com/nicksnyder/go-i18n/v2 v2.4.0/go.mod h1:nxYSZE9M0bf3Y70gPQjN9ha7XNHX7gMc814+6wVyEI4= github.com/nxadm/tail v1.4.4/go.mod h1:kenIhsEOeOJmVchQTgglprH7qJGnHDVpk1VPCcaMI8A= diff --git a/management/server/account_test.go b/management/server/account_test.go index 31405e3af..6a2d85fe8 100644 --- a/management/server/account_test.go +++ b/management/server/account_test.go @@ -982,6 +982,110 @@ func TestAccountManager_DeleteAccount(t *testing.T) { } } +func BenchmarkTest_GetAccountWithclaims(b *testing.B) { + claims := jwtclaims.AuthorizationClaims{ + Domain: "example.com", + UserId: "pvt-domain-user", + DomainCategory: PrivateCategory, + } + + publicClaims := jwtclaims.AuthorizationClaims{ + Domain: "test.com", + UserId: "public-domain-user", + DomainCategory: PublicCategory, + } + + am, err := createManager(b) + if err != nil { + b.Fatal(err) + return + } + id, err := am.getAccountIDWithAuthorizationClaims(context.Background(), claims) + if err != nil { + b.Fatal(err) + } + + pid, err := am.getAccountIDWithAuthorizationClaims(context.Background(), publicClaims) + if err != nil { + b.Fatal(err) + } + + users := genUsers("priv", 100) + + acc, err := am.Store.GetAccount(context.Background(), id) + if err != nil { + b.Fatal(err) + } + acc.Users = users + + err = am.Store.SaveAccount(context.Background(), acc) + if err != nil { + b.Fatal(err) + } + + userP := genUsers("pub", 100) + + pacc, err := am.Store.GetAccount(context.Background(), pid) + if err != nil { + b.Fatal(err) + } + + pacc.Users = userP + + err = am.Store.SaveAccount(context.Background(), pacc) + if err != nil { + b.Fatal(err) + } + + b.Run("public without account ID", func(b *testing.B) { + //b.ResetTimer() + for i := 0; i < b.N; i++ { + _, err := am.getAccountIDWithAuthorizationClaims(context.Background(), publicClaims) + if err != nil { + b.Fatal(err) + } + } + }) + + b.Run("private without account ID", func(b *testing.B) { + //b.ResetTimer() + for i := 0; i < b.N; i++ { + _, err := am.getAccountIDWithAuthorizationClaims(context.Background(), claims) + if err != nil { + b.Fatal(err) + } + } + }) + + b.Run("private with account ID", func(b *testing.B) { + claims.AccountId = id + //b.ResetTimer() + for i := 0; i < b.N; i++ { + _, err := am.getAccountIDWithAuthorizationClaims(context.Background(), claims) + if err != nil { + b.Fatal(err) + } + } + }) + +} + +func genUsers(p string, n int) map[string]*User { + users := map[string]*User{} + now := time.Now() + for i := 0; i < n; i++ { + users[fmt.Sprintf("%s-%d", p, i)] = &User{ + Id: fmt.Sprintf("%s-%d", p, i), + Role: UserRoleAdmin, + LastLogin: now, + CreatedAt: now, + Issued: "api", + AutoGroups: []string{"one", "two", "three", "four", "five", "six", "seven", "eight", "nine", "ten"}, + } + } + return users +} + func TestAccountManager_AddPeer(t *testing.T) { manager, err := createManager(t) if err != nil { diff --git a/management/server/grpcserver.go b/management/server/grpcserver.go index 4c4ef6c3c..efe088b27 100644 --- a/management/server/grpcserver.go +++ b/management/server/grpcserver.go @@ -6,6 +6,7 @@ import ( "net" "net/netip" "strings" + "sync" "time" pb "github.com/golang/protobuf/proto" // nolint @@ -38,6 +39,7 @@ type GRPCServer struct { jwtClaimsExtractor *jwtclaims.ClaimsExtractor appMetrics telemetry.AppMetrics ephemeralManager *EphemeralManager + peerLocks sync.Map } // NewServer creates a new Management server @@ -148,6 +150,13 @@ func (s *GRPCServer) Sync(req *proto.EncryptedMessage, srv proto.ManagementServi // nolint:staticcheck ctx = context.WithValue(ctx, nbContext.PeerIDKey, peerKey.String()) + unlock := s.acquirePeerLockByUID(ctx, peerKey.String()) + defer func() { + if unlock != nil { + unlock() + } + }() + accountID, err := s.accountManager.GetAccountIDForPeerKey(ctx, peerKey.String()) if err != nil { // nolint:staticcheck @@ -190,6 +199,9 @@ func (s *GRPCServer) Sync(req *proto.EncryptedMessage, srv proto.ManagementServi s.appMetrics.GRPCMetrics().CountSyncRequestDuration(time.Since(reqStart)) } + unlock() + unlock = nil + return s.handleUpdates(ctx, accountID, peerKey, peer, updates, srv) } @@ -245,9 +257,12 @@ func (s *GRPCServer) sendUpdate(ctx context.Context, accountID string, peerKey w } func (s *GRPCServer) cancelPeerRoutines(ctx context.Context, accountID string, peer *nbpeer.Peer) { + unlock := s.acquirePeerLockByUID(ctx, peer.Key) + defer unlock() + + _ = s.accountManager.OnPeerDisconnected(ctx, accountID, peer.Key) s.peersUpdateManager.CloseChannel(ctx, peer.ID) s.secretsManager.CancelRefresh(peer.ID) - _ = s.accountManager.OnPeerDisconnected(ctx, accountID, peer.Key) s.ephemeralManager.OnPeerDisconnected(ctx, peer) } @@ -274,6 +289,24 @@ func (s *GRPCServer) validateToken(ctx context.Context, jwtToken string) (string return claims.UserId, nil } +func (s *GRPCServer) acquirePeerLockByUID(ctx context.Context, uniqueID string) (unlock func()) { + log.WithContext(ctx).Tracef("acquiring peer lock for ID %s", uniqueID) + + start := time.Now() + value, _ := s.peerLocks.LoadOrStore(uniqueID, &sync.RWMutex{}) + mtx := value.(*sync.RWMutex) + mtx.Lock() + log.WithContext(ctx).Tracef("acquired peer lock for ID %s in %v", uniqueID, time.Since(start)) + start = time.Now() + + unlock = func() { + mtx.Unlock() + log.WithContext(ctx).Tracef("released peer lock for ID %s in %v", uniqueID, time.Since(start)) + } + + return unlock +} + // maps internal internalStatus.Error to gRPC status.Error func mapError(ctx context.Context, err error) error { if e, ok := internalStatus.FromError(err); ok { diff --git a/management/server/sql_store.go b/management/server/sql_store.go index dea724ebb..ce04b1459 100644 --- a/management/server/sql_store.go +++ b/management/server/sql_store.go @@ -321,13 +321,11 @@ func (s *SqlStore) GetInstallationID() string { } func (s *SqlStore) SavePeer(ctx context.Context, accountID string, peer *nbpeer.Peer) error { - startTime := time.Now() - // To maintain data integrity, we create a copy of the peer's to prevent unintended updates to other fields. peerCopy := peer.Copy() peerCopy.AccountID = accountID - err := s.db.WithContext(ctx).Transaction(func(tx *gorm.DB) error { + err := s.db.Transaction(func(tx *gorm.DB) error { // check if peer exists before saving var peerID string result := tx.Model(&nbpeer.Peer{}).Select("id").Find(&peerID, accountAndIDQueryCondition, accountID, peer.ID) @@ -348,9 +346,6 @@ func (s *SqlStore) SavePeer(ctx context.Context, accountID string, peer *nbpeer. }) if err != nil { - if errors.Is(err, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } return err } @@ -358,8 +353,6 @@ func (s *SqlStore) SavePeer(ctx context.Context, accountID string, peer *nbpeer. } func (s *SqlStore) UpdateAccountDomainAttributes(ctx context.Context, accountID string, domain string, category string, isPrimaryDomain bool) error { - startTime := time.Now() - accountCopy := Account{ Domain: domain, DomainCategory: category, @@ -367,14 +360,11 @@ func (s *SqlStore) UpdateAccountDomainAttributes(ctx context.Context, accountID } fieldsToUpdate := []string{"domain", "domain_category", "is_domain_primary_account"} - result := s.db.WithContext(ctx).Model(&Account{}). + result := s.db.Model(&Account{}). Select(fieldsToUpdate). Where(idQueryCondition, accountID). Updates(&accountCopy) if result.Error != nil { - if errors.Is(result.Error, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } return result.Error } @@ -386,8 +376,6 @@ func (s *SqlStore) UpdateAccountDomainAttributes(ctx context.Context, accountID } func (s *SqlStore) SavePeerStatus(accountID, peerID string, peerStatus nbpeer.PeerStatus) error { - startTime := time.Now() - var peerCopy nbpeer.Peer peerCopy.Status = &peerStatus @@ -400,9 +388,6 @@ func (s *SqlStore) SavePeerStatus(accountID, peerID string, peerStatus nbpeer.Pe Where(accountAndIDQueryCondition, accountID, peerID). Updates(&peerCopy) if result.Error != nil { - if errors.Is(result.Error, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } return result.Error } @@ -414,8 +399,6 @@ func (s *SqlStore) SavePeerStatus(accountID, peerID string, peerStatus nbpeer.Pe } func (s *SqlStore) SavePeerLocation(accountID string, peerWithLocation *nbpeer.Peer) error { - startTime := time.Now() - // To maintain data integrity, we create a copy of the peer's location to prevent unintended updates to other fields. var peerCopy nbpeer.Peer // Since the location field has been migrated to JSON serialization, @@ -427,9 +410,6 @@ func (s *SqlStore) SavePeerLocation(accountID string, peerWithLocation *nbpeer.P Updates(peerCopy) if result.Error != nil { - if errors.Is(result.Error, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } return result.Error } @@ -443,8 +423,6 @@ func (s *SqlStore) SavePeerLocation(accountID string, peerWithLocation *nbpeer.P // SaveUsers saves the given list of users to the database. // It updates existing users if a conflict occurs. func (s *SqlStore) SaveUsers(accountID string, users map[string]*User) error { - startTime := time.Now() - usersToSave := make([]User, 0, len(users)) for _, user := range users { user.AccountID = accountID @@ -458,9 +436,6 @@ func (s *SqlStore) SaveUsers(accountID string, users map[string]*User) error { Clauses(clause.OnConflict{UpdateAll: true}). Create(&usersToSave).Error if err != nil { - if errors.Is(err, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } return status.Errorf(status.Internal, "failed to save users to store: %v", err) } @@ -469,13 +444,8 @@ func (s *SqlStore) SaveUsers(accountID string, users map[string]*User) error { // SaveUser saves the given user to the database. func (s *SqlStore) SaveUser(ctx context.Context, lockStrength LockingStrength, user *User) error { - startTime := time.Now() - - result := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}).Save(user) + result := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}).Save(user) if result.Error != nil { - if errors.Is(result.Error, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } return status.Errorf(status.Internal, "failed to save user to store: %v", result.Error) } return nil @@ -483,17 +453,12 @@ func (s *SqlStore) SaveUser(ctx context.Context, lockStrength LockingStrength, u // SaveGroups saves the given list of groups to the database. func (s *SqlStore) SaveGroups(ctx context.Context, lockStrength LockingStrength, groups []*nbgroup.Group) error { - startTime := time.Now() - if len(groups) == 0 { return nil } - result := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}).Save(&groups) + result := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}).Save(&groups) if result.Error != nil { - if errors.Is(result.Error, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } return status.Errorf(status.Internal, "failed to save groups to store: %v", result.Error) } return nil @@ -520,10 +485,8 @@ func (s *SqlStore) GetAccountByPrivateDomain(ctx context.Context, domain string) } func (s *SqlStore) GetAccountIDByPrivateDomain(ctx context.Context, lockStrength LockingStrength, domain string) (string, error) { - startTime := time.Now() - var accountID string - result := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&Account{}).Select("id"). + result := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&Account{}).Select("id"). Where("domain = ? and is_domain_primary_account = ? and domain_category = ?", strings.ToLower(domain), true, PrivateCategory, ).First(&accountID) @@ -531,9 +494,6 @@ func (s *SqlStore) GetAccountIDByPrivateDomain(ctx context.Context, lockStrength if errors.Is(result.Error, gorm.ErrRecordNotFound) { return "", status.Errorf(status.NotFound, "account not found: provided domain is not registered or is not private") } - if errors.Is(result.Error, context.Canceled) { - return "", status.NewStoreContextCanceledError(time.Since(startTime)) - } log.WithContext(ctx).Errorf("error when getting account from the store: %s", result.Error) return "", status.NewGetAccountFromStoreError(result.Error) } @@ -542,17 +502,13 @@ func (s *SqlStore) GetAccountIDByPrivateDomain(ctx context.Context, lockStrength } func (s *SqlStore) GetAccountBySetupKey(ctx context.Context, setupKey string) (*Account, error) { - startTime := time.Now() - var key SetupKey - result := s.db.WithContext(ctx).Select("account_id").First(&key, GetKeyQueryCondition(s), setupKey) + result := s.db.Select("account_id").First(&key, GetKeyQueryCondition(s), setupKey) + if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return nil, status.Errorf(status.NotFound, "account not found: index lookup failed") } - if errors.Is(result.Error, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } return nil, status.NewSetupKeyNotFoundError(result.Error) } @@ -564,17 +520,12 @@ func (s *SqlStore) GetAccountBySetupKey(ctx context.Context, setupKey string) (* } func (s *SqlStore) GetTokenIDByHashedToken(ctx context.Context, hashedToken string) (string, error) { - startTime := time.Now() - var token PersonalAccessToken result := s.db.First(&token, "hashed_token = ?", hashedToken) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return "", status.Errorf(status.NotFound, "account not found: index lookup failed") } - if errors.Is(result.Error, context.Canceled) { - return "", status.NewStoreContextCanceledError(time.Since(startTime)) - } log.WithContext(ctx).Errorf("error when getting token from the store: %s", result.Error) return "", status.NewGetAccountFromStoreError(result.Error) } @@ -583,17 +534,12 @@ func (s *SqlStore) GetTokenIDByHashedToken(ctx context.Context, hashedToken stri } func (s *SqlStore) GetUserByTokenID(ctx context.Context, tokenID string) (*User, error) { - startTime := time.Now() - var token PersonalAccessToken result := s.db.First(&token, idQueryCondition, tokenID) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return nil, status.Errorf(status.NotFound, "account not found: index lookup failed") } - if errors.Is(result.Error, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } log.WithContext(ctx).Errorf("error when getting token from the store: %s", result.Error) return nil, status.NewGetAccountFromStoreError(result.Error) } @@ -617,18 +563,13 @@ func (s *SqlStore) GetUserByTokenID(ctx context.Context, tokenID string) (*User, } func (s *SqlStore) GetUserByUserID(ctx context.Context, lockStrength LockingStrength, userID string) (*User, error) { - startTime := time.Now() - var user User - result := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}). + result := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}). Preload(clause.Associations).First(&user, idQueryCondition, userID) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return nil, status.NewUserNotFoundError(userID) } - if errors.Is(result.Error, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } return nil, status.NewGetUserFromStoreError() } @@ -636,17 +577,12 @@ func (s *SqlStore) GetUserByUserID(ctx context.Context, lockStrength LockingStre } func (s *SqlStore) GetAccountUsers(ctx context.Context, accountID string) ([]*User, error) { - startTime := time.Now() - var users []*User result := s.db.Find(&users, accountIDCondition, accountID) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return nil, status.Errorf(status.NotFound, "accountID not found: index lookup failed") } - if errors.Is(result.Error, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } log.WithContext(ctx).Errorf("error when getting users from the store: %s", result.Error) return nil, status.Errorf(status.Internal, "issue getting users from store") } @@ -655,17 +591,12 @@ func (s *SqlStore) GetAccountUsers(ctx context.Context, accountID string) ([]*Us } func (s *SqlStore) GetAccountGroups(ctx context.Context, accountID string) ([]*nbgroup.Group, error) { - startTime := time.Now() - var groups []*nbgroup.Group result := s.db.Find(&groups, accountIDCondition, accountID) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return nil, status.Errorf(status.NotFound, "accountID not found: index lookup failed") } - if errors.Is(result.Error, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } log.WithContext(ctx).Errorf("error when getting groups from the store: %s", result.Error) return nil, status.Errorf(status.Internal, "issue getting groups from store") } @@ -765,17 +696,12 @@ func (s *SqlStore) GetAccount(ctx context.Context, accountID string) (*Account, } func (s *SqlStore) GetAccountByUser(ctx context.Context, userID string) (*Account, error) { - startTime := time.Now() - var user User - result := s.db.WithContext(ctx).Select("account_id").First(&user, idQueryCondition, userID) + result := s.db.Select("account_id").First(&user, idQueryCondition, userID) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return nil, status.Errorf(status.NotFound, "account not found: index lookup failed") } - if errors.Is(result.Error, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } return nil, status.NewGetAccountFromStoreError(result.Error) } @@ -787,17 +713,12 @@ func (s *SqlStore) GetAccountByUser(ctx context.Context, userID string) (*Accoun } func (s *SqlStore) GetAccountByPeerID(ctx context.Context, peerID string) (*Account, error) { - startTime := time.Now() - var peer nbpeer.Peer - result := s.db.WithContext(ctx).Select("account_id").First(&peer, idQueryCondition, peerID) + result := s.db.Select("account_id").First(&peer, idQueryCondition, peerID) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return nil, status.Errorf(status.NotFound, "account not found: index lookup failed") } - if errors.Is(result.Error, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } return nil, status.NewGetAccountFromStoreError(result.Error) } @@ -809,17 +730,13 @@ func (s *SqlStore) GetAccountByPeerID(ctx context.Context, peerID string) (*Acco } func (s *SqlStore) GetAccountByPeerPubKey(ctx context.Context, peerKey string) (*Account, error) { - startTime := time.Now() - var peer nbpeer.Peer - result := s.db.WithContext(ctx).Select("account_id").First(&peer, GetKeyQueryCondition(s), peerKey) + result := s.db.Select("account_id").First(&peer, GetKeyQueryCondition(s), peerKey) + if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return nil, status.Errorf(status.NotFound, "account not found: index lookup failed") } - if errors.Is(result.Error, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } return nil, status.NewGetAccountFromStoreError(result.Error) } @@ -831,18 +748,13 @@ func (s *SqlStore) GetAccountByPeerPubKey(ctx context.Context, peerKey string) ( } func (s *SqlStore) GetAccountIDByPeerPubKey(ctx context.Context, peerKey string) (string, error) { - startTime := time.Now() - var peer nbpeer.Peer var accountID string - result := s.db.WithContext(ctx).Model(&peer).Select("account_id").Where(GetKeyQueryCondition(s), peerKey).First(&accountID) + result := s.db.Model(&peer).Select("account_id").Where(GetKeyQueryCondition(s), peerKey).First(&accountID) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return "", status.Errorf(status.NotFound, "account not found: index lookup failed") } - if errors.Is(result.Error, context.Canceled) { - return "", status.NewStoreContextCanceledError(time.Since(startTime)) - } return "", status.NewGetAccountFromStoreError(result.Error) } @@ -850,17 +762,12 @@ func (s *SqlStore) GetAccountIDByPeerPubKey(ctx context.Context, peerKey string) } func (s *SqlStore) GetAccountIDByUserID(userID string) (string, error) { - startTime := time.Now() - var accountID string result := s.db.Model(&User{}).Select("account_id").Where(idQueryCondition, userID).First(&accountID) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return "", status.Errorf(status.NotFound, "account not found: index lookup failed") } - if errors.Is(result.Error, context.Canceled) { - return "", status.NewStoreContextCanceledError(time.Since(startTime)) - } return "", status.NewGetAccountFromStoreError(result.Error) } @@ -868,17 +775,12 @@ func (s *SqlStore) GetAccountIDByUserID(userID string) (string, error) { } func (s *SqlStore) GetAccountIDBySetupKey(ctx context.Context, setupKey string) (string, error) { - startTime := time.Now() - var accountID string - result := s.db.WithContext(ctx).Model(&SetupKey{}).Select("account_id").Where(GetKeyQueryCondition(s), setupKey).First(&accountID) + result := s.db.Model(&SetupKey{}).Select("account_id").Where(GetKeyQueryCondition(s), setupKey).First(&accountID) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return "", status.Errorf(status.NotFound, "account not found: index lookup failed") } - if errors.Is(result.Error, context.Canceled) { - return "", status.NewStoreContextCanceledError(time.Since(startTime)) - } return "", status.NewSetupKeyNotFoundError(result.Error) } @@ -890,21 +792,16 @@ func (s *SqlStore) GetAccountIDBySetupKey(ctx context.Context, setupKey string) } func (s *SqlStore) GetTakenIPs(ctx context.Context, lockStrength LockingStrength, accountID string) ([]net.IP, error) { - startTime := time.Now() - var ipJSONStrings []string // Fetch the IP addresses as JSON strings - result := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&nbpeer.Peer{}). + result := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&nbpeer.Peer{}). Where("account_id = ?", accountID). Pluck("ip", &ipJSONStrings) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return nil, status.Errorf(status.NotFound, "no peers found for the account") } - if errors.Is(result.Error, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } return nil, status.Errorf(status.Internal, "issue getting IPs from store: %s", result.Error) } @@ -922,10 +819,8 @@ func (s *SqlStore) GetTakenIPs(ctx context.Context, lockStrength LockingStrength } func (s *SqlStore) GetPeerLabelsInAccount(ctx context.Context, lockStrength LockingStrength, accountID string) ([]string, error) { - startTime := time.Now() - var labels []string - result := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&nbpeer.Peer{}). + result := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&nbpeer.Peer{}). Where("account_id = ?", accountID). Pluck("dns_label", &labels) @@ -933,9 +828,6 @@ func (s *SqlStore) GetPeerLabelsInAccount(ctx context.Context, lockStrength Lock if errors.Is(result.Error, gorm.ErrRecordNotFound) { return nil, status.Errorf(status.NotFound, "no peers found for the account") } - if errors.Is(result.Error, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } log.WithContext(ctx).Errorf("error when getting dns labels from the store: %s", result.Error) return nil, status.Errorf(status.Internal, "issue getting dns labels from store: %s", result.Error) } @@ -944,33 +836,24 @@ func (s *SqlStore) GetPeerLabelsInAccount(ctx context.Context, lockStrength Lock } func (s *SqlStore) GetAccountNetwork(ctx context.Context, lockStrength LockingStrength, accountID string) (*Network, error) { - startTime := time.Now() - var accountNetwork AccountNetwork - if err := s.db.WithContext(ctx).Model(&Account{}).Where(idQueryCondition, accountID).First(&accountNetwork).Error; err != nil { + if err := s.db.Model(&Account{}).Where(idQueryCondition, accountID).First(&accountNetwork).Error; err != nil { if errors.Is(err, gorm.ErrRecordNotFound) { return nil, status.NewAccountNotFoundError(accountID) } - if errors.Is(err, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } return nil, status.Errorf(status.Internal, "issue getting network from store: %s", err) } return accountNetwork.Network, nil } func (s *SqlStore) GetPeerByPeerPubKey(ctx context.Context, lockStrength LockingStrength, peerKey string) (*nbpeer.Peer, error) { - startTime := time.Now() - var peer nbpeer.Peer - result := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}).First(&peer, GetKeyQueryCondition(s), peerKey) + result := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}).First(&peer, GetKeyQueryCondition(s), peerKey) + if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return nil, status.Errorf(status.NotFound, "peer not found") } - if errors.Is(result.Error, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } return nil, status.Errorf(status.Internal, "issue getting peer from store: %s", result.Error) } @@ -978,16 +861,11 @@ func (s *SqlStore) GetPeerByPeerPubKey(ctx context.Context, lockStrength Locking } func (s *SqlStore) GetAccountSettings(ctx context.Context, lockStrength LockingStrength, accountID string) (*Settings, error) { - startTime := time.Now() - var accountSettings AccountSettings - if err := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&Account{}).Where(idQueryCondition, accountID).First(&accountSettings).Error; err != nil { + if err := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&Account{}).Where(idQueryCondition, accountID).First(&accountSettings).Error; err != nil { if errors.Is(err, gorm.ErrRecordNotFound) { return nil, status.Errorf(status.NotFound, "settings not found") } - if errors.Is(err, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } return nil, status.Errorf(status.Internal, "issue getting settings from store: %s", err) } return accountSettings.Settings, nil @@ -995,17 +873,13 @@ func (s *SqlStore) GetAccountSettings(ctx context.Context, lockStrength LockingS // SaveUserLastLogin stores the last login time for a user in DB. func (s *SqlStore) SaveUserLastLogin(ctx context.Context, accountID, userID string, lastLogin time.Time) error { - startTime := time.Now() - var user User - result := s.db.WithContext(ctx).First(&user, accountAndIDQueryCondition, accountID, userID) + result := s.db.First(&user, accountAndIDQueryCondition, accountID, userID) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return status.NewUserNotFoundError(userID) } - if errors.Is(result.Error, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } + return status.NewGetUserFromStoreError() } user.LastLogin = lastLogin @@ -1014,8 +888,6 @@ func (s *SqlStore) SaveUserLastLogin(ctx context.Context, accountID, userID stri } func (s *SqlStore) GetPostureCheckByChecksDefinition(accountID string, checks *posture.ChecksDefinition) (*posture.Checks, error) { - startTime := time.Now() - definitionJSON, err := json.Marshal(checks) if err != nil { return nil, err @@ -1024,9 +896,6 @@ func (s *SqlStore) GetPostureCheckByChecksDefinition(accountID string, checks *p var postureCheck posture.Checks err = s.db.Where("account_id = ? AND checks = ?", accountID, string(definitionJSON)).First(&postureCheck).Error if err != nil { - if errors.Is(err, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } return nil, err } @@ -1177,27 +1046,21 @@ func NewMysqlStoreFromSqlStore(ctx context.Context, sqliteStore *SqlStore, dsn s } func (s *SqlStore) GetSetupKeyBySecret(ctx context.Context, lockStrength LockingStrength, key string) (*SetupKey, error) { - startTime := time.Now() - var setupKey SetupKey - result := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}). + result := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}). First(&setupKey, GetKeyQueryCondition(s), key) + if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return nil, status.Errorf(status.NotFound, "setup key not found") } - if errors.Is(result.Error, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } return nil, status.NewSetupKeyNotFoundError(result.Error) } return &setupKey, nil } func (s *SqlStore) IncrementSetupKeyUsage(ctx context.Context, setupKeyID string) error { - startTime := time.Now() - - result := s.db.WithContext(ctx).Model(&SetupKey{}). + result := s.db.Model(&SetupKey{}). Where(idQueryCondition, setupKeyID). Updates(map[string]interface{}{ "used_times": gorm.Expr("used_times + 1"), @@ -1205,9 +1068,6 @@ func (s *SqlStore) IncrementSetupKeyUsage(ctx context.Context, setupKeyID string }) if result.Error != nil { - if errors.Is(result.Error, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } return status.Errorf(status.Internal, "issue incrementing setup key usage count: %s", result.Error) } @@ -1219,17 +1079,12 @@ func (s *SqlStore) IncrementSetupKeyUsage(ctx context.Context, setupKeyID string } func (s *SqlStore) AddPeerToAllGroup(ctx context.Context, accountID string, peerID string) error { - startTime := time.Now() - var group nbgroup.Group - result := s.db.WithContext(ctx).Where("account_id = ? AND name = ?", accountID, "All").First(&group) + result := s.db.Where("account_id = ? AND name = ?", accountID, "All").First(&group) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return status.Errorf(status.NotFound, "group 'All' not found for account") } - if errors.Is(result.Error, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } return status.Errorf(status.Internal, "issue finding group 'All': %s", result.Error) } @@ -1242,9 +1097,6 @@ func (s *SqlStore) AddPeerToAllGroup(ctx context.Context, accountID string, peer group.Peers = append(group.Peers, peerID) if err := s.db.Save(&group).Error; err != nil { - if errors.Is(result.Error, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } return status.Errorf(status.Internal, "issue updating group 'All': %s", err) } @@ -1252,17 +1104,13 @@ func (s *SqlStore) AddPeerToAllGroup(ctx context.Context, accountID string, peer } func (s *SqlStore) AddPeerToGroup(ctx context.Context, accountId string, peerId string, groupID string) error { - startTime := time.Now() - var group nbgroup.Group - result := s.db.WithContext(ctx).Where(accountAndIDQueryCondition, accountId, groupID).First(&group) + result := s.db.Where(accountAndIDQueryCondition, accountId, groupID).First(&group) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return status.Errorf(status.NotFound, "group not found for account") } - if errors.Is(result.Error, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } + return status.Errorf(status.Internal, "issue finding group: %s", result.Error) } @@ -1275,9 +1123,6 @@ func (s *SqlStore) AddPeerToGroup(ctx context.Context, accountId string, peerId group.Peers = append(group.Peers, peerId) if err := s.db.Save(&group).Error; err != nil { - if errors.Is(result.Error, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } return status.Errorf(status.Internal, "issue updating group: %s", err) } @@ -1286,16 +1131,11 @@ func (s *SqlStore) AddPeerToGroup(ctx context.Context, accountId string, peerId // GetUserPeers retrieves peers for a user. func (s *SqlStore) GetUserPeers(ctx context.Context, lockStrength LockingStrength, accountID, userID string) ([]*nbpeer.Peer, error) { - return getRecords[*nbpeer.Peer](s.db.WithContext(ctx).Where("user_id = ?", userID), lockStrength, accountID) + return getRecords[*nbpeer.Peer](s.db.Where("user_id = ?", userID), lockStrength, accountID) } func (s *SqlStore) AddPeerToAccount(ctx context.Context, peer *nbpeer.Peer) error { - startTime := time.Now() - - if err := s.db.WithContext(ctx).Create(peer).Error; err != nil { - if errors.Is(err, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } + if err := s.db.Create(peer).Error; err != nil { return status.Errorf(status.Internal, "issue adding peer to account: %s", err) } @@ -1303,20 +1143,15 @@ func (s *SqlStore) AddPeerToAccount(ctx context.Context, peer *nbpeer.Peer) erro } func (s *SqlStore) IncrementNetworkSerial(ctx context.Context, accountId string) error { - startTime := time.Now() - - result := s.db.WithContext(ctx).Model(&Account{}).Where(idQueryCondition, accountId).Update("network_serial", gorm.Expr("network_serial + 1")) + result := s.db.Model(&Account{}).Where(idQueryCondition, accountId).Update("network_serial", gorm.Expr("network_serial + 1")) if result.Error != nil { - if errors.Is(result.Error, context.Canceled) { - return status.NewStoreContextCanceledError(time.Since(startTime)) - } return status.Errorf(status.Internal, "issue incrementing network serial count: %s", result.Error) } return nil } func (s *SqlStore) ExecuteInTransaction(ctx context.Context, operation func(store Store) error) error { - tx := s.db.WithContext(ctx).Begin() + tx := s.db.Begin() if tx.Error != nil { return tx.Error } @@ -1340,18 +1175,13 @@ func (s *SqlStore) GetDB() *gorm.DB { } func (s *SqlStore) GetAccountDNSSettings(ctx context.Context, lockStrength LockingStrength, accountID string) (*DNSSettings, error) { - startTime := time.Now() - var accountDNSSettings AccountDNSSettings - result := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&Account{}). + result := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&Account{}). First(&accountDNSSettings, idQueryCondition, accountID) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return nil, status.Errorf(status.NotFound, "dns settings not found") } - if errors.Is(result.Error, context.Canceled) { - return nil, status.NewStoreContextCanceledError(time.Since(startTime)) - } return nil, status.Errorf(status.Internal, "failed to get dns settings from store: %v", result.Error) } return &accountDNSSettings.DNSSettings, nil @@ -1359,18 +1189,13 @@ func (s *SqlStore) GetAccountDNSSettings(ctx context.Context, lockStrength Locki // AccountExists checks whether an account exists by the given ID. func (s *SqlStore) AccountExists(ctx context.Context, lockStrength LockingStrength, id string) (bool, error) { - startTime := time.Now() - var accountID string - result := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&Account{}). + result := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&Account{}). Select("id").First(&accountID, idQueryCondition, id) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return false, nil } - if errors.Is(result.Error, context.Canceled) { - return false, status.NewStoreContextCanceledError(time.Since(startTime)) - } return false, result.Error } @@ -1379,18 +1204,13 @@ func (s *SqlStore) AccountExists(ctx context.Context, lockStrength LockingStreng // GetAccountDomainAndCategory retrieves the Domain and DomainCategory fields for an account based on the given accountID. func (s *SqlStore) GetAccountDomainAndCategory(ctx context.Context, lockStrength LockingStrength, accountID string) (string, string, error) { - startTime := time.Now() - var account Account - result := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&Account{}).Select("domain", "domain_category"). + result := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}).Model(&Account{}).Select("domain", "domain_category"). Where(idQueryCondition, accountID).First(&account) if result.Error != nil { if errors.Is(result.Error, gorm.ErrRecordNotFound) { return "", "", status.Errorf(status.NotFound, "account not found") } - if errors.Is(result.Error, context.Canceled) { - return "", "", status.NewStoreContextCanceledError(time.Since(startTime)) - } return "", "", status.Errorf(status.Internal, "failed to get domain category from store: %v", result.Error) } @@ -1399,7 +1219,7 @@ func (s *SqlStore) GetAccountDomainAndCategory(ctx context.Context, lockStrength // GetGroupByID retrieves a group by ID and account ID. func (s *SqlStore) GetGroupByID(ctx context.Context, lockStrength LockingStrength, groupID, accountID string) (*nbgroup.Group, error) { - return getRecordByID[nbgroup.Group](s.db.WithContext(ctx).Preload(clause.Associations), lockStrength, groupID, accountID) + return getRecordByID[nbgroup.Group](s.db.Preload(clause.Associations), lockStrength, groupID, accountID) } // GetGroupByName retrieves a group by name and account ID. @@ -1408,7 +1228,7 @@ func (s *SqlStore) GetGroupByName(ctx context.Context, lockStrength LockingStren // TODO: This fix is accepted for now, but if we need to handle this more frequently // we may need to reconsider changing the types. - query := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}).Preload(clause.Associations) + query := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}).Preload(clause.Associations) switch s.storeEngine { case PostgresStoreEngine: @@ -1431,7 +1251,7 @@ func (s *SqlStore) GetGroupByName(ctx context.Context, lockStrength LockingStren // SaveGroup saves a group to the store. func (s *SqlStore) SaveGroup(ctx context.Context, lockStrength LockingStrength, group *nbgroup.Group) error { - result := s.db.WithContext(ctx).Clauses(clause.Locking{Strength: string(lockStrength)}).Save(group) + result := s.db.Clauses(clause.Locking{Strength: string(lockStrength)}).Save(group) if result.Error != nil { return status.Errorf(status.Internal, "failed to save group to store: %v", result.Error) } @@ -1440,56 +1260,56 @@ func (s *SqlStore) SaveGroup(ctx context.Context, lockStrength LockingStrength, // GetAccountPolicies retrieves policies for an account. func (s *SqlStore) GetAccountPolicies(ctx context.Context, lockStrength LockingStrength, accountID string) ([]*Policy, error) { - return getRecords[*Policy](s.db.WithContext(ctx).Preload(clause.Associations), lockStrength, accountID) + return getRecords[*Policy](s.db.Preload(clause.Associations), lockStrength, accountID) } // GetPolicyByID retrieves a policy by its ID and account ID. func (s *SqlStore) GetPolicyByID(ctx context.Context, lockStrength LockingStrength, policyID string, accountID string) (*Policy, error) { - return getRecordByID[Policy](s.db.WithContext(ctx).Preload(clause.Associations), lockStrength, policyID, accountID) + return getRecordByID[Policy](s.db.Preload(clause.Associations), lockStrength, policyID, accountID) } // GetAccountPostureChecks retrieves posture checks for an account. func (s *SqlStore) GetAccountPostureChecks(ctx context.Context, lockStrength LockingStrength, accountID string) ([]*posture.Checks, error) { - return getRecords[*posture.Checks](s.db.WithContext(ctx), lockStrength, accountID) + return getRecords[*posture.Checks](s.db, lockStrength, accountID) } // GetPostureChecksByID retrieves posture checks by their ID and account ID. func (s *SqlStore) GetPostureChecksByID(ctx context.Context, lockStrength LockingStrength, postureCheckID string, accountID string) (*posture.Checks, error) { - return getRecordByID[posture.Checks](s.db.WithContext(ctx), lockStrength, postureCheckID, accountID) + return getRecordByID[posture.Checks](s.db, lockStrength, postureCheckID, accountID) } // GetAccountRoutes retrieves network routes for an account. func (s *SqlStore) GetAccountRoutes(ctx context.Context, lockStrength LockingStrength, accountID string) ([]*route.Route, error) { - return getRecords[*route.Route](s.db.WithContext(ctx), lockStrength, accountID) + return getRecords[*route.Route](s.db, lockStrength, accountID) } // GetRouteByID retrieves a route by its ID and account ID. func (s *SqlStore) GetRouteByID(ctx context.Context, lockStrength LockingStrength, routeID string, accountID string) (*route.Route, error) { - return getRecordByID[route.Route](s.db.WithContext(ctx), lockStrength, routeID, accountID) + return getRecordByID[route.Route](s.db, lockStrength, routeID, accountID) } // GetAccountSetupKeys retrieves setup keys for an account. func (s *SqlStore) GetAccountSetupKeys(ctx context.Context, lockStrength LockingStrength, accountID string) ([]*SetupKey, error) { - return getRecords[*SetupKey](s.db.WithContext(ctx), lockStrength, accountID) + return getRecords[*SetupKey](s.db, lockStrength, accountID) } // GetSetupKeyByID retrieves a setup key by its ID and account ID. func (s *SqlStore) GetSetupKeyByID(ctx context.Context, lockStrength LockingStrength, setupKeyID string, accountID string) (*SetupKey, error) { - return getRecordByID[SetupKey](s.db.WithContext(ctx), lockStrength, setupKeyID, accountID) + return getRecordByID[SetupKey](s.db, lockStrength, setupKeyID, accountID) } // GetAccountNameServerGroups retrieves name server groups for an account. func (s *SqlStore) GetAccountNameServerGroups(ctx context.Context, lockStrength LockingStrength, accountID string) ([]*nbdns.NameServerGroup, error) { - return getRecords[*nbdns.NameServerGroup](s.db.WithContext(ctx), lockStrength, accountID) + return getRecords[*nbdns.NameServerGroup](s.db, lockStrength, accountID) } // GetNameServerGroupByID retrieves a name server group by its ID and account ID. func (s *SqlStore) GetNameServerGroupByID(ctx context.Context, lockStrength LockingStrength, nsGroupID string, accountID string) (*nbdns.NameServerGroup, error) { - return getRecordByID[nbdns.NameServerGroup](s.db.WithContext(ctx), lockStrength, nsGroupID, accountID) + return getRecordByID[nbdns.NameServerGroup](s.db, lockStrength, nsGroupID, accountID) } func (s *SqlStore) DeleteSetupKey(ctx context.Context, accountID, keyID string) error { - return deleteRecordByID[SetupKey](s.db.WithContext(ctx), LockingStrengthUpdate, keyID, accountID) + return deleteRecordByID[SetupKey](s.db, LockingStrengthUpdate, keyID, accountID) } // getRecords retrieves records from the database based on the account ID.