From 02958887bc658b91b43eb6580c8115ca148a488b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Papp?= Date: Tue, 14 Apr 2026 17:43:12 +0200 Subject: [PATCH] [management] Fix peer update test for MetricsConfig in NetbirdConfig Update TestUpdateAccountPeers assertions: NetbirdConfig is no longer nil in peer update responses since it now carries MetricsConfig even when STUN/TURN config is absent. --- client/internal/metrics/metrics.go | 2 +- management/server/peer_test.go | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/client/internal/metrics/metrics.go b/client/internal/metrics/metrics.go index f080ab21a..1c30b1089 100644 --- a/client/internal/metrics/metrics.go +++ b/client/internal/metrics/metrics.go @@ -224,7 +224,7 @@ func (c *ClientMetrics) UpdatePushFromMgm(ctx context.Context, enabled bool) { if c.push == nil { return } - log.Infof("disabled metrics push by managmenet") + log.Infof("disabled metrics push by management") c.stopPushLocked() } } diff --git a/management/server/peer_test.go b/management/server/peer_test.go index 51c16d730..a2c66646a 100644 --- a/management/server/peer_test.go +++ b/management/server/peer_test.go @@ -1062,7 +1062,11 @@ func testUpdateAccountPeers(t *testing.T) { for _, channel := range peerChannels { update := <-channel - assert.Nil(t, update.Update.NetbirdConfig) + assert.NotNil(t, update.Update.NetbirdConfig) + assert.Nil(t, update.Update.NetbirdConfig.Stuns) + assert.Nil(t, update.Update.NetbirdConfig.Turns) + assert.Nil(t, update.Update.NetbirdConfig.Signal) + assert.Nil(t, update.Update.NetbirdConfig.Relay) assert.Equal(t, tc.peers, len(update.Update.NetworkMap.RemotePeers)) assert.Equal(t, tc.peers*2, len(update.Update.NetworkMap.FirewallRules)) }