From 01d01ac16fbcfbcf83bc305f4734b379fedd0e43 Mon Sep 17 00:00:00 2001 From: Hakan Sariman Date: Tue, 18 Mar 2025 19:22:46 +0800 Subject: [PATCH] Remove event generation check for non-echo requests in ICMP tracker test --- client/firewall/uspfilter/conntrack/icmp_test.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/client/firewall/uspfilter/conntrack/icmp_test.go b/client/firewall/uspfilter/conntrack/icmp_test.go index a26abad29..500c23623 100644 --- a/client/firewall/uspfilter/conntrack/icmp_test.go +++ b/client/firewall/uspfilter/conntrack/icmp_test.go @@ -33,9 +33,6 @@ func TestICMPTracker_TrackOutbound_NonEcho(t *testing.T) { // Since type != EchoRequest the connection should not be stored. require.Equal(t, 0, len(tracker.connections), "Non-echo request should not be tracked") - // No events should be generated for non-echo requests. - events := flowLogger.GetEvents() - require.Equal(t, len(events), 0, "Non-echo request should not generate an event") } func TestICMPTracker_TrackOutbound_Echo(t *testing.T) {