Update common.ts

.github/ISSUE_TEMPLATE/01_bug-report.yml

@@ -9,7 +9,6 @@ body:
         Thanks for reporting!
         First, in order to avoid duplicate Issues, please search to see if the problem you found has already been reported.
         Also, If you are NOT owner/admin of server, PLEASE DONT REPORT SERVER SPECIFIC ISSUES TO HERE! (e.g. feature XXX is not working in misskey.example) Please try with another misskey servers, and if your issue is only reproducible with specific server, contact your server's owner/admin first.
-        Finally, this is not place to ask trouble shooting. Please use Duscussions for it.
 
   - type: textarea
     attributes:

CHANGELOG.md

@@ -4,10 +4,10 @@
 -
 
 ### Client
-- サイズ制限を超過するファイルをアップロードしようとした際にエラーを出すように
+-
 
 ### Server
-- ファイルがサイズの制限を超えてアップロードされた際にエラーを返さなかった問題を修正
+-
 
 
 ## 2024.8.0

locales/index.d.ts

@@ -5068,10 +5068,6 @@ export interface Locale extends ILocale {
      * 作成したアンテナ
      */
     "createdAntennas": string;
-    /**
-     * これ以上このクリップにノートを追加できません。
-     */
-    "clipNoteLimitExceeded": string;
     "_delivery": {
         /**
          * 配信状態

locales/ja-JP.yml

@@ -1263,7 +1263,6 @@ confirmWhenRevealingSensitiveMedia: "センシティブなメディアを表示
 sensitiveMediaRevealConfirm: "センシティブなメディアです。表示しますか？"
 createdLists: "作成したリスト"
 createdAntennas: "作成したアンテナ"
-clipNoteLimitExceeded: "これ以上このクリップにノートを追加できません。"
 
 _delivery:
   status: "配信状態"

packages/backend/src/config.ts

@@ -133,7 +133,7 @@ export type Config = {
 	proxySmtp: string | undefined;
 	proxyBypassHosts: string[] | undefined;
 	allowedPrivateNetworks: string[] | undefined;
-	maxFileSize: number;
+	maxFileSize: number | undefined;
 	clusterLimit: number | undefined;
 	id: string;
 	outgoingAddress: string | undefined;
@@ -250,7 +250,7 @@ export function loadConfig(): Config {
 		proxySmtp: config.proxySmtp,
 		proxyBypassHosts: config.proxyBypassHosts,
 		allowedPrivateNetworks: config.allowedPrivateNetworks,
-		maxFileSize: config.maxFileSize ?? 262144000,
+		maxFileSize: config.maxFileSize,
 		clusterLimit: config.clusterLimit,
 		outgoingAddress: config.outgoingAddress,
 		outgoingAddressFamily: config.outgoingAddressFamily,

packages/backend/src/core/DownloadService.ts

@@ -42,7 +42,7 @@ export class DownloadService {
 
 		const timeout = 30 * 1000;
 		const operationTimeout = 60 * 1000;
-		const maxSize = this.config.maxFileSize;
+		const maxSize = this.config.maxFileSize ?? 262144000;
 
 		const urlObj = new URL(url);
 		let filename = urlObj.pathname.split('/').pop() ?? 'untitled';

packages/backend/src/core/entities/MetaEntityService.ts

@@ -129,7 +129,6 @@ export class MetaEntityService {
 			mediaProxy: this.config.mediaProxy,
 			enableUrlPreview: instance.urlPreviewEnabled,
 			noteSearchableScope: (this.config.meilisearch == null || this.config.meilisearch.scope !== 'local') ? 'global' : 'local',
-			maxFileSize: this.config.maxFileSize,
 		};
 
 		return packed;

packages/backend/src/models/json-schema/meta.ts

@@ -253,10 +253,6 @@ export const packedMetaLiteSchema = {
 			optional: false, nullable: false,
 			default: 'local',
 		},
-		maxFileSize: {
-			type: 'number',
-			optional: false, nullable: false,
-		},
 	},
 } as const;
 

packages/backend/src/server/api/ApiCallService.ts

@@ -199,18 +199,9 @@ export class ApiCallService implements OnApplicationShutdown {
 			return;
 		}
 
-		const [path, cleanup] = await createTemp();
+		const [path] = await createTemp();
 		await stream.pipeline(multipartData.file, fs.createWriteStream(path));
 
-		// ファイルサイズが制限を超えていた場合
-		// なお truncated はストリームを読み切ってからでないと機能しないため、stream.pipeline より後にある必要がある
-		if (multipartData.file.truncated) {
-			cleanup();
-			reply.code(413);
-			reply.send();
-			return;
-		}
-
 		const fields = {} as Record<string, unknown>;
 		for (const [k, v] of Object.entries(multipartData.fields)) {
 			fields[k] = typeof v === 'object' && 'value' in v ? v.value : undefined;

packages/backend/src/server/api/ApiServerService.ts

@@ -49,7 +49,7 @@ export class ApiServerService {
 
 		fastify.register(multipart, {
 			limits: {
-				fileSize: this.config.maxFileSize,
+				fileSize: this.config.maxFileSize ?? 262144000,
 				files: 1,
 			},
 		});

packages/backend/src/server/web/boot.js

@@ -33,59 +33,6 @@
 		return;
 	}
 
-	//#region Detect language & fetch translations
-	if (!localStorage.hasOwnProperty('locale')) {
-		const supportedLangs = LANGS;
-		let lang = localStorage.getItem('lang');
-		if (lang == null || !supportedLangs.includes(lang)) {
-			if (supportedLangs.includes(navigator.language)) {
-				lang = navigator.language;
-			} else {
-				lang = supportedLangs.find(x => x.split('-')[0] === navigator.language);
-
-				// Fallback
-				if (lang == null) lang = 'en-US';
-			}
-		}
-
-		const metaRes = await window.fetch('/api/meta', {
-			method: 'POST',
-			body: JSON.stringify({}),
-			credentials: 'omit',
-			cache: 'no-cache',
-			headers: {
-				'Content-Type': 'application/json',
-			},
-		});
-		if (metaRes.status !== 200) {
-			renderError('META_FETCH');
-			return;
-		}
-		const meta = await metaRes.json();
-		const v = meta.version;
-		if (v == null) {
-			renderError('META_FETCH_V');
-			return;
-		}
-
-		// for https://github.com/misskey-dev/misskey/issues/10202
-		if (lang == null || lang.toString == null || lang.toString() === 'null') {
-			console.error('invalid lang value detected!!!', typeof lang, lang);
-			lang = 'en-US';
-		}
-
-		const localRes = await window.fetch(`/assets/locales/${lang}.${v}.json`);
-		if (localRes.status === 200) {
-			localStorage.setItem('lang', lang);
-			localStorage.setItem('locale', await localRes.text());
-			localStorage.setItem('localeVersion', v);
-		} else {
-			renderError('LOCALE_FETCH');
-			return;
-		}
-	}
-	//#endregion
-
 	//#region Script
 	async function importAppScript() {
 		await import(`/vite/${CLIENT_ENTRY}`)
@@ -178,7 +125,7 @@
 			<p><b>The following actions may solve the problem. / 以下を行うと解決する可能性があります。</b></p>
 			<p>Update your os and browser / ブラウザおよびOSを最新バージョンに更新する</p>
 			<p>Disable an adblocker / アドブロッカーを無効にする</p>
-	 		<p>Clear the browser cache / ブラウザのキャッシュをクリアする</p>
+			<p>Clear the browser cache / ブラウザのキャッシュをクリアする</p>
 			<p>&#40;Tor Browser&#41; Set dom.webaudio.enabled to true / dom.webaudio.enabledをtrueに設定する</p>
 			<details style="color: #86b300;">
 				<summary>Other options / その他のオプション</summary>
@@ -320,6 +267,6 @@
 			#errorInfo {
 				width: 50%;
 			}
-		}`)
+		}`);
 	}
 })();

packages/frontend/src/_dev_boot_.ts

@@ -23,27 +23,6 @@ async function main() {
 
 	//#region Detect language & fetch translations
 
-	// dev-modeの場合は常に取り直す
-	const supportedLangs = _LANGS_.map(it => it[0]);
-	let lang: string | null | undefined = localStorage.getItem('lang');
-	if (lang == null || !supportedLangs.includes(lang)) {
-		if (supportedLangs.includes(navigator.language)) {
-			lang = navigator.language;
-		} else {
-			lang = supportedLangs.find(x => x.split('-')[0] === navigator.language);
-
-			// Fallback
-			if (lang == null) lang = 'en-US';
-		}
-	}
-
-	// TODO:今のままだと言語ファイル変更後はpnpm devをリスタートする必要があるので、chokidarを使ったり等で対応できるようにする
-	const locale = _LANGS_FULL_.find(it => it[0] === lang);
-	localStorage.setItem('lang', lang);
-	localStorage.setItem('locale', JSON.stringify(locale[1]));
-	localStorage.setItem('localeVersion', _VERSION_);
-	//#endregion
-
 	//#region Theme
 	const theme = localStorage.getItem('theme');
 	if (theme) {

packages/frontend/src/boot/common.ts

@@ -8,10 +8,10 @@ import { compareVersions } from 'compare-versions';
 import widgets from '@/widgets/index.js';
 import directives from '@/directives/index.js';
 import components from '@/components/index.js';
-import { version, lang, updateLocale, locale } from '@/config.js';
+import { version, lang } from '@/config.js';
 import { applyTheme } from '@/scripts/theme.js';
 import { isDeviceDarkmode } from '@/scripts/is-device-darkmode.js';
-import { updateI18n } from '@/i18n.js';
+import { locale, updateI18n, updateLocale } from '@/i18n.js';
 import { $i, refreshAccount, login } from '@/account.js';
 import { defaultStore, ColdDeviceStorage } from '@/store.js';
 import { fetchInstance, instance } from '@/instance.js';
@@ -78,22 +78,6 @@ export async function common(createVue: () => App<Element>) {
 	}
 	//#endregion
 
-	//#region Detect language & fetch translations
-	const localeVersion = miLocalStorage.getItem('localeVersion');
-	const localeOutdated = (localeVersion == null || localeVersion !== version || locale == null);
-	if (localeOutdated) {
-		const res = await window.fetch(`/assets/locales/${lang}.${version}.json`);
-		if (res.status === 200) {
-			const newLocale = await res.text();
-			const parsedNewLocale = JSON.parse(newLocale);
-			miLocalStorage.setItem('locale', newLocale);
-			miLocalStorage.setItem('localeVersion', version);
-			updateLocale(parsedNewLocale);
-			updateI18n(parsedNewLocale);
-		}
-	}
-	//#endregion
-
 	// タッチデバイスでCSSの:hoverを機能させる
 	document.addEventListener('touchend', () => {}, { passive: true });
 

packages/frontend/src/config.ts

@@ -5,6 +5,28 @@
 
 import { miLocalStorage } from '@/local-storage.js';
 
+//#region language detection
+const supportedLangs = _LANGS_.map(it => it[0]);
+let _lang = miLocalStorage.getItem('lang');
+if (_lang == null || !supportedLangs.includes(_lang)) {
+	if (supportedLangs.includes(navigator.language)) {
+		_lang = navigator.language;
+	} else {
+		_lang = supportedLangs.find(x => x.split('-')[0] === navigator.language) ?? null;
+
+		// Fallback
+		if (_lang == null) _lang = 'en-US';
+	}
+	miLocalStorage.setItem('lang', _lang);
+}
+// for https://github.com/misskey-dev/misskey/issues/10202
+if (_lang.toString == null || _lang.toString() === 'null') {
+	console.error('invalid lang value detected!!!', typeof _lang, _lang);
+	_lang = 'en-US';
+	miLocalStorage.setItem('lang', _lang);
+}
+//#endregion
+
 const address = new URL(document.querySelector<HTMLMetaElement>('meta[property="instance_url"]')?.content || location.href);
 const siteName = document.querySelector<HTMLMetaElement>('meta[property="og:site_name"]')?.content;
 
@@ -13,15 +35,9 @@ export const hostname = address.hostname;
 export const url = address.origin;
 export const apiUrl = location.origin + '/api';
 export const wsOrigin = location.origin;
-export const lang = miLocalStorage.getItem('lang') ?? 'en-US';
+export const lang = _lang;
 export const langs = _LANGS_;
-const preParseLocale = miLocalStorage.getItem('locale');
-export let locale = preParseLocale ? JSON.parse(preParseLocale) : null;
 export const version = _VERSION_;
 export const instanceName = siteName === 'Misskey' || siteName == null ? host : siteName;
 export const ui = miLocalStorage.getItem('ui');
 export const debug = miLocalStorage.getItem('debug') === 'true';
-
-export function updateLocale(newLocale): void {
-	locale = newLocale;
-}

packages/frontend/src/i18n.ts

@@ -5,8 +5,50 @@
 
 import { markRaw } from 'vue';
 import type { Locale } from '../../../locales/index.js';
-import { locale } from '@/config.js';
 import { I18n } from '@/scripts/i18n.js';
+import { miLocalStorage } from '@/local-storage.js';
+import { version, lang } from '@/config.js';
+
+const preParseLocale = miLocalStorage.getItem('locale');
+export let locale = preParseLocale ? JSON.parse(preParseLocale) : null;
+
+if (locale == null) {
+	const localRes = await window.fetch(`/assets/locales/${lang}.${version}.json`);
+	if (localRes.status === 200) {
+		locale = await localRes.json();
+		localStorage.setItem('locale', JSON.stringify(locale));
+		localStorage.setItem('localeVersion', version);
+	} else {
+		throw new Error('Failed to fetch locale file');
+	}
+}
+
+//#region Detect language & fetch translations
+const localeVersion = miLocalStorage.getItem('localeVersion');
+const localeOutdated = (localeVersion == null || localeVersion !== version);
+if (localeOutdated) {
+	const res = await window.fetch(`/assets/locales/${lang}.${version}.json`);
+	if (res.status === 200) {
+		const newLocale = await res.text();
+		const parsedNewLocale = JSON.parse(newLocale);
+		miLocalStorage.setItem('locale', newLocale);
+		miLocalStorage.setItem('localeVersion', version);
+		locale = parsedNewLocale;
+	}
+}
+//#endregion
+
+// dev-modeの場合は常に取り直す
+if (_DEV_) {
+	const x = _LANGS_FULL_.find(it => it[0] === lang)!;
+	localStorage.setItem('locale', JSON.stringify(x[1]));
+	localStorage.setItem('localeVersion', version);
+	locale = x[1];
+}
+
+export function updateLocale(newLocale): void {
+	locale = newLocale;
+}
 
 export const i18n = markRaw(new I18n<Locale>(locale));
 

packages/frontend/src/scripts/get-note-menu.ts

@@ -66,11 +66,6 @@ export async function getNoteClipMenu(props: {
 							});
 							if (props.currentClip?.id === clip.id) props.isDeleted.value = true;
 						}
-					} else if (err.id === 'f0dba960-ff73-4615-8df4-d6ac5d9dc118') {
-						os.alert({
-							type: 'error',
-							text: i18n.ts.clipNoteLimitExceeded,
-						});
 					} else {
 						os.alert({
 							type: 'error',

packages/frontend/src/scripts/upload.ts

@@ -13,7 +13,6 @@ import { apiUrl } from '@/config.js';
 import { $i } from '@/account.js';
 import { alert } from '@/os.js';
 import { i18n } from '@/i18n.js';
-import { instance } from '@/instance.js';
 
 type Uploading = {
 	id: string;
@@ -40,15 +39,6 @@ export function uploadFile(
 
 	if (folder && typeof folder === 'object') folder = folder.id;
 
-	if (file.size > instance.maxFileSize) {
-		alert({
-			type: 'error',
-			title: i18n.ts.failedToUpload,
-			text: i18n.ts.cannotUploadBecauseExceedsFileSizeLimit,
-		});
-		return Promise.reject();
-	}
-
 	return new Promise((resolve, reject) => {
 		const id = uuid();
 

packages/misskey-js/src/autogen/types.ts

@@ -4947,7 +4947,6 @@ export type components = {
        * @enum {string}
        */
       noteSearchableScope: 'local' | 'global';
-      maxFileSize: number;
     };
     MetaDetailedOnly: {
       features?: {