Improve error handling of API (#4345)

* wip

* wip

* wip

* Update attached_notes.ts

* wip

* Refactor

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* Update call.ts

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* ✌️

* Fix

src/server/api/endpoints/notes/reactions/create.ts

@@ -1,11 +1,10 @@
-import * as mongo from 'mongodb';
 import $ from 'cafy';
 import ID, { transform } from '../../../../../misc/cafy-id';
 import createReaction from '../../../../../services/note/reaction/create';
 import { validateReaction } from '../../../../../models/note-reaction';
 import define from '../../../define';
-import { IUser } from '../../../../../models/user';
 import { getValiedNote } from '../../../common/getters';
+import { ApiError } from '../../../error';
 
 export const meta = {
 	stability: 'stable',
@@ -34,15 +33,38 @@ export const meta = {
 				'ja-JP': 'リアクションの種類'
 			}
 		}
+	},
+
+	errors: {
+		noSuchNote: {
+			message: 'No such note.',
+			code: 'NO_SUCH_NOTE',
+			id: '033d0620-5bfe-4027-965d-980b0c85a3ea'
+		},
+
+		isMyNote: {
+			message: 'You can not react to your own notes.',
+			code: 'IS_MY_NOTE',
+			id: '7eeb9714-b047-43b5-b559-7b1b72810f53'
+		},
+
+		alreadyReacted: {
+			message: 'You are already reacting to that note.',
+			code: 'ALREADY_REACTED',
+			id: '71efcf98-86d6-4e2b-b2ad-9d032369366b'
+		}
 	}
 };
 
-export default define(meta, (ps, user) => new Promise((res, rej) => {
-	createReactionById(user, ps.noteId, ps.reaction)
-		.then(r => res(r)).catch(e => rej(e));
-}));
-
-async function createReactionById(user: IUser, noteId: mongo.ObjectID, reaction: string) {
-	const note = await getValiedNote(noteId);
-	await createReaction(user, note, reaction);
-}
+export default define(meta, async (ps, user) => {
+	const note = await getValiedNote(ps.noteId).catch(e => {
+		if (e.id === '9725d0ce-ba28-4dde-95a7-2cbb2c15de24') throw new ApiError(meta.errors.noSuchNote);
+		throw e;
+	});
+	await createReaction(user, note, ps.reaction).catch(e => {
+		if (e.id === '2d8e7297-1873-4c00-8404-792c68d7bef0') throw new ApiError(meta.errors.isMyNote);
+		if (e.id === '51c42bb4-931a-456b-bff7-e5a8a70dd298') throw new ApiError(meta.errors.alreadyReacted);
+		throw e;
+	});
+	return;
+});