fix: use || for emoji url fallback instead of ??

2022-12-30 13:37:58 +00:00
parent 8090850ed6
commit 1a408db3b1
5 changed files with 10 additions and 6 deletions
--- a/packages/backend/src/core/ReactionService.ts
+++ b/packages/backend/src/core/ReactionService.ts
@@ -161,7 +161,8 @@ export class ReactionService {
 			reaction: decodedReaction.reaction,
 			emoji: emoji != null ? {
 				name: emoji.host ? `${emoji.name}@${emoji.host}` : `${emoji.name}@.`,
-				url: emoji.publicUrl ?? emoji.originalUrl, // || emoji.originalUrl してるのは後方互換性のため
+				// || emoji.originalUrl してるのは後方互換性のため（publicUrlはstringなので??はだめ）
+				url: emoji.publicUrl || emoji.originalUrl,
 			} : null,
 			userId: user.id,
 		});