pangolin_mirror/pangolin
1
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-03-06 18:56:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1900 from fosrl/copilot/fix-hc-health-status-unknown

Browse Source 
Reset hcHealth to "unknown" when health check is disabled
This commit is contained in:
Owen Schwartz
2025-12-06 11:20:38 -05:00
committed by GitHub
parent b9c0089fac be4d697dfe
commit a92edf519e
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
server/routers/target/updateTarget.ts
View File

@@ -208,6 +208,12 @@ export async function updateTarget(
hcHeaders = JSON.stringify(parsedBody.data.hcHeaders); hcHeaders = JSON.stringify(parsedBody.data.hcHeaders);
} }
// When health check is disabled, reset hcHealth to "unknown"
// to prevent previously unhealthy targets from being excluded
const hcHealthValue = (parsedBody.data.hcEnabled === false || parsedBody.data.hcEnabled === null)
? "unknown"
: undefined;
const [updatedHc] = await db const [updatedHc] = await db
.update(targetHealthCheck) .update(targetHealthCheck)
.set({ .set({
@@ -223,7 +229,8 @@ export async function updateTarget(
hcHeaders: hcHeaders, hcHeaders: hcHeaders,
hcFollowRedirects: parsedBody.data.hcFollowRedirects, hcFollowRedirects: parsedBody.data.hcFollowRedirects,
hcMethod: parsedBody.data.hcMethod, hcMethod: parsedBody.data.hcMethod,
hcStatus: parsedBody.data.hcStatus hcStatus: parsedBody.data.hcStatus,
...(hcHealthValue !== undefined && { hcHealth: hcHealthValue })
}) })
.where(eq(targetHealthCheck.targetId, targetId)) .where(eq(targetHealthCheck.targetId, targetId))
.returning(); .returning();