♻️ set approval state nullable

server/db/pg/schema/schema.ts

@@ -693,9 +693,9 @@ export const clients = pgTable("clients", {
     maxConnections: integer("maxConnections"),
     archived: boolean("archived").notNull().default(false),
     blocked: boolean("blocked").notNull().default(false),
-    approvalState: varchar("approvalState")
+    approvalState: varchar("approvalState").$type<
-        .$type<"pending" | "approved" | "denied">()
+        "pending" | "approved" | "denied"
-        .default("approved")
+    >()
 });
 
 export const clientSitesAssociationsCache = pgTable(

server/db/sqlite/schema/schema.ts

@@ -388,9 +388,9 @@ export const clients = sqliteTable("clients", {
     lastHolePunch: integer("lastHolePunch"),
     archived: integer("archived", { mode: "boolean" }).notNull().default(false),
     blocked: integer("blocked", { mode: "boolean" }).notNull().default(false),
-    approvalState: text("approvalState")
+    approvalState: text("approvalState").$type<
-        .$type<"pending" | "approved" | "denied">()
+        "pending" | "approved" | "denied"
-        .default("approved")
+    >()
 });
 
 export const clientSitesAssociationsCache = sqliteTable(

server/lib/calculateUserClientsForOrgs.ts

@@ -204,7 +204,7 @@ export async function calculateUserClientsForOrgs(
                     olmId: olm.olmId,
                     type: "olm",
                     niceId,
-                    approvalState: requireApproval ? "pending" : "approved"
+                    approvalState: requireApproval ? "pending" : null
                 };
 
                 // Create the client

src/app/[orgId]/settings/clients/user/page.tsx

@@ -58,7 +58,7 @@ export default async function ClientsPage(props: ClientsPageProps) {
             agent: client.agent,
             archived: client.archived || false,
             blocked: client.blocked || false,
-            approvalState: client.approvalState ?? "approved"
+            approvalState: client.approvalState
         };
     };
 

src/app/navigation.tsx

@@ -141,15 +141,6 @@ export const orgNavSections = (env?: Env): SidebarNavSection[] => [
                       }
                   ]
                 : []),
-            ...(build !== "oss"
-                ? [
-                      {
-                          title: "sidebarApprovals",
-                          href: "/{orgId}/settings/access/approvals",
-                          icon: <UserCog className="size-4 flex-none" />
-                      }
-                  ]
-                : []),
             {
                 title: "sidebarShareableLinks",
                 href: "/{orgId}/settings/share-links",

src/components/UserDevicesTable.tsx

@@ -45,7 +45,7 @@ export type ClientRow = {
     userEmail: string | null;
     niceId: string;
     agent: string | null;
-    approvalState: "approved" | "pending" | "denied";
+    approvalState: "approved" | "pending" | "denied" | null;
     archived?: boolean;
     blocked?: boolean;
 };
@@ -430,12 +430,18 @@ export default function UserDevicesTable({ userClients }: ClientTableProps) {
                             );
                         case "denied":
                             return <Badge variant="red">{t("denied")}</Badge>;
-                        default:
+                        case "pending":
                             return (
                                 <Badge variant="secondary">
                                     {t("pending")}
                                 </Badge>
                             );
+                        default:
+                            return (
+                                <span className="text-muted-foreground">
+                                    N/A
+                                </span>
+                            );
                     }
                 }
             });