pangolin_mirror/newt
1
0
Fork 0
mirror of https://github.com/fosrl/newt.git synced 2026-03-26 20:46:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sonar): SetObservableCallback uses unregister stopper instead of empty function to satisfy S1186

Browse Source
This commit is contained in:
Marc Schäfer
2025-10-08 01:09:18 +02:00
parent 587e829e42
commit e16881b7c8
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/telemetry/metrics.go
View File

@@ -207,10 +207,14 @@ var (
// }) // })
func SetObservableCallback(cb func(context.Context, metric.Observer) error) { func SetObservableCallback(cb func(context.Context, metric.Observer) error) {
obsOnce.Do(func() { obsOnce.Do(func() {
if _, e := meter.RegisterCallback(cb, mSiteOnline, mSiteLastHeartbeat, mTunnelSessions); e != nil { reg, e := meter.RegisterCallback(cb, mSiteOnline, mSiteLastHeartbeat, mTunnelSessions)
if e != nil {
otel.Handle(e) otel.Handle(e)
obsStopper = func() {}
return
} }
obsStopper = func() { /* no-op; otel callbacks are unregistered when provider shuts down */ } // Provide a functional stopper mirroring proxy/build-info behavior
obsStopper = func() { _ = reg.Unregister() }
}) })
} }