From 8d26de5f4da731181231327cca1135f0ad56773d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc=20Sch=C3=A4fer?= Date: Fri, 10 Oct 2025 15:29:24 +0200 Subject: [PATCH] fix(docker-compose): improve comments for clarity on port mapping and collector usage --- docker-compose.metrics.collector.yml | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/docker-compose.metrics.collector.yml b/docker-compose.metrics.collector.yml index 8d0d536..040f410 100644 --- a/docker-compose.metrics.collector.yml +++ b/docker-compose.metrics.collector.yml @@ -9,8 +9,19 @@ services: - NEWT_METRICS_OTLP_ENABLED=true # OTLP to the Collector # optional: # - NEWT_METRICS_INCLUDE_TUNNEL_ID=false - # If Newt itself exposes ports, DO NOT map 2112 here - # ports: [] + # When using the Collector pattern, do NOT map the Newt admin/metrics port + # (2112) on the application service. Mapping 2112 here can cause port + # conflicts and may result in duplicated Prometheus scraping (app AND + # collector being scraped for the same metrics). Instead either: + # - leave ports unset on the app service (recommended), or + # - map 2112 only on a dedicated metrics/collector service that is + # responsible for exposing metrics to Prometheus. + # Example: do NOT map here + # ports: [] + # Example: map 2112 only on a collector service + # collector: + # ports: + # - "2112:2112" # collector's prometheus exporter (scraped by Prometheus) otel-collector: image: otel/opentelemetry-collector-contrib:latest