groot/automatisch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: add DISABLE_FAVICON feature flag

Browse Source
This commit is contained in:
Ali BARIN
2024-02-07 11:48:03 +00:00
parent 6ec5872391
commit e6b806616f
7 changed files with 24 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/backend/src/config/app.js
View File

@@ -89,6 +89,7 @@ const appConfig = {
sentryDsn: process.env.SENTRY_DSN, sentryDsn: process.env.SENTRY_DSN,
CI: process.env.CI === 'true', CI: process.env.CI === 'true',
disableNotificationsPage: process.env.DISABLE_NOTIFICATIONS_PAGE === 'true', disableNotificationsPage: process.env.DISABLE_NOTIFICATIONS_PAGE === 'true',
disableFavicon: process.env.DISABLE_FAVICON === 'true',
}; };
if (!appConfig.encryptionKey) { if (!appConfig.encryptionKey) {

1
packages/backend/src/graphql/queries/get-config.ee.js
View File

@@ -4,6 +4,7 @@ import Config from '../../models/config.js';
const defaultConfig = { const defaultConfig = {
disableNotificationsPage: appConfig.disableNotificationsPage, disableNotificationsPage: appConfig.disableNotificationsPage,
disableFavicon: appConfig.disableFavicon,
}; };
const getConfig = async (_parent, params) => { const getConfig = async (_parent, params) => {

1
packages/docs/pages/advanced/configuration.md
View File

@@ -43,3 +43,4 @@ Please be careful with the `ENCRYPTION_KEY` and `WEBHOOK_SECRET_KEY` environment
| `BULLMQ_DASHBOARD_USERNAME` | string | | Username to login BullMQ Dashboard | | `BULLMQ_DASHBOARD_USERNAME` | string | | Username to login BullMQ Dashboard |
| `BULLMQ_DASHBOARD_PASSWORD` | string | | Password to login BullMQ Dashboard | | `BULLMQ_DASHBOARD_PASSWORD` | string | | Password to login BullMQ Dashboard |
| `DISABLE_NOTIFICATIONS_PAGE` | boolean | `false` | Enable/Disable notifications page | | `DISABLE_NOTIFICATIONS_PAGE` | boolean | `false` | Enable/Disable notifications page |
| `DISABLE_FAVICON` | boolean | `false` | Enable/Disable favicon |

0
packages/web/public/favicon.ico → packages/web/public/browser-tab.ico
View File

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 15 KiB

After

Width:  |  Height:  |  Size: 15 KiB

1
packages/web/public/index.html
View File

@@ -2,7 +2,6 @@
<html lang="en"> <html lang="en">
<head> <head>
<meta charset="utf-8" /> <meta charset="utf-8" />
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" /> <meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#0059F7" /> <meta name="theme-color" content="#0059F7" />
<meta <meta

7
packages/web/public/manifest.json
View File

@@ -2,13 +2,6 @@
"short_name": "automatisch", "short_name": "automatisch",
"name": "automatisch", "name": "automatisch",
"description": "Build workflow automation without spending time and money. No code is required.", "description": "Build workflow automation without spending time and money. No code is required.",
"icons": [
{
"src": "favicon.ico",
"sizes": "64x64 32x32 24x24 16x16",
"type": "image/x-icon"
}
],
"start_url": ".", "start_url": ".",
"display": "standalone", "display": "standalone",
"theme_color": "#000000", "theme_color": "#000000",

21
packages/web/src/components/MetadataProvider/index.tsx
View File

@@ -15,6 +15,27 @@ const MetadataProvider = ({
document.title = (config?.title as string) || 'Automatisch'; document.title = (config?.title as string) || 'Automatisch';
}, [config?.title]); }, [config?.title]);
React.useEffect(() => {
const existingFaviconElement = document.querySelector(
"link[rel~='icon']"
) as HTMLLinkElement | null;
if (config?.disableFavicon === true) {
existingFaviconElement?.remove();
}
if (config?.disableFavicon === false) {
if (existingFaviconElement) {
existingFaviconElement.href = '/browser-tab.ico';
} else {
const newFaviconElement = document.createElement('link');
newFaviconElement.rel = 'icon';
document.head.appendChild(newFaviconElement);
newFaviconElement.href = '/browser-tab.ico';
}
}
}, [config?.disableFavicon]);
return <>{children}</>; return <>{children}</>;
}; };