refactor: Fetch role and permissions for current user in create connection tests

packages/backend/src/controllers/api/v1/apps/create-connection.test.js

@@ -29,6 +29,17 @@ describe('POST /api/v1/apps/:appKey/connections', () => {
 
     currentUser = await createUser({ roleId: role.id });
 
+    currentUser = await currentUser
+      .$query()
+      .leftJoinRelated({
+        role: true,
+        permissions: true,
+      })
+      .withGraphFetched({
+        role: true,
+        permissions: true,
+      });
+
     token = await createAuthTokenByUserId(currentUser.id);
   });
 

packages/backend/test/factories/user.js

@@ -10,17 +10,5 @@ export const createUser = async (params = {}) => {
 
   const user = await User.query().insertAndFetch(params);
 
-  // important to mimic request.currentUser functionality.
+  return user;
-  const userWithRoleAndPermissions = await user
-    .$query()
-    .leftJoinRelated({
-      role: true,
-      permissions: true,
-    })
-    .withGraphFetched({
-      role: true,
-      permissions: true,
-    });
-
-  return userWithRoleAndPermissions;
 };