From ddc9867058429754c056632394900982a6922c3c Mon Sep 17 00:00:00 2001 From: Ali BARIN Date: Wed, 11 Sep 2024 13:08:53 +0000 Subject: [PATCH] chore: remove redundant register user mutation --- .../backend/src/graphql/mutation-resolvers.js | 2 -- .../src/graphql/mutations/register-user.ee.js | 30 ------------------- packages/backend/src/graphql/schema.graphql | 7 ----- .../backend/src/helpers/authentication.js | 3 +- .../src/graphql/mutations/register-user.ee.js | 10 ------- 5 files changed, 1 insertion(+), 51 deletions(-) delete mode 100644 packages/backend/src/graphql/mutations/register-user.ee.js delete mode 100644 packages/web/src/graphql/mutations/register-user.ee.js diff --git a/packages/backend/src/graphql/mutation-resolvers.js b/packages/backend/src/graphql/mutation-resolvers.js index 49b5e898..4dfe49a4 100644 --- a/packages/backend/src/graphql/mutation-resolvers.js +++ b/packages/backend/src/graphql/mutation-resolvers.js @@ -3,7 +3,6 @@ import createUser from './mutations/create-user.ee.js'; import deleteFlow from './mutations/delete-flow.js'; import duplicateFlow from './mutations/duplicate-flow.js'; import generateAuthUrl from './mutations/generate-auth-url.js'; -import registerUser from './mutations/register-user.ee.js'; import resetConnection from './mutations/reset-connection.js'; import updateConnection from './mutations/update-connection.js'; import updateFlowStatus from './mutations/update-flow-status.js'; @@ -28,7 +27,6 @@ const mutationResolvers = { duplicateFlow, executeFlow, generateAuthUrl, - registerUser, resetConnection, updateConnection, updateCurrentUser, diff --git a/packages/backend/src/graphql/mutations/register-user.ee.js b/packages/backend/src/graphql/mutations/register-user.ee.js deleted file mode 100644 index c084af9b..00000000 --- a/packages/backend/src/graphql/mutations/register-user.ee.js +++ /dev/null @@ -1,30 +0,0 @@ -import appConfig from '../../config/app.js'; -import User from '../../models/user.js'; -import Role from '../../models/role.js'; - -const registerUser = async (_parent, params) => { - if (!appConfig.isCloud) return; - - const { fullName, email, password } = params.input; - - const existingUser = await User.query().findOne({ - email: email.toLowerCase(), - }); - - if (existingUser) { - throw new Error('User already exists!'); - } - - const role = await Role.query().findOne({ name: 'User' }); - - const user = await User.query().insert({ - fullName, - email, - password, - roleId: role.id, - }); - - return user; -}; - -export default registerUser; diff --git a/packages/backend/src/graphql/schema.graphql b/packages/backend/src/graphql/schema.graphql index c28f46e6..5b4520b5 100644 --- a/packages/backend/src/graphql/schema.graphql +++ b/packages/backend/src/graphql/schema.graphql @@ -11,7 +11,6 @@ type Mutation { duplicateFlow(input: DuplicateFlowInput): Flow executeFlow(input: ExecuteFlowInput): executeFlowType generateAuthUrl(input: GenerateAuthUrlInput): AuthLink - registerUser(input: RegisterUserInput): User resetConnection(input: ResetConnectionInput): Connection updateConnection(input: UpdateConnectionInput): Connection updateCurrentUser(input: UpdateCurrentUserInput): User @@ -296,12 +295,6 @@ input UpdateUserInput { role: UserRoleInput } -input RegisterUserInput { - fullName: String! - email: String! - password: String! -} - input UpdateCurrentUserInput { email: String password: String diff --git a/packages/backend/src/helpers/authentication.js b/packages/backend/src/helpers/authentication.js index 9f01d21d..b2eeeffa 100644 --- a/packages/backend/src/helpers/authentication.js +++ b/packages/backend/src/helpers/authentication.js @@ -1,4 +1,4 @@ -import { allow, rule, shield } from 'graphql-shield'; +import { rule, shield } from 'graphql-shield'; import User from '../models/user.js'; import AccessToken from '../models/access-token.js'; @@ -53,7 +53,6 @@ const isAuthenticatedRule = rule()(isAuthenticated); export const authenticationRules = { Mutation: { '*': isAuthenticatedRule, - registerUser: allow, }, }; diff --git a/packages/web/src/graphql/mutations/register-user.ee.js b/packages/web/src/graphql/mutations/register-user.ee.js deleted file mode 100644 index 54f852ac..00000000 --- a/packages/web/src/graphql/mutations/register-user.ee.js +++ /dev/null @@ -1,10 +0,0 @@ -import { gql } from '@apollo/client'; -export const REGISTER_USER = gql` - mutation RegisterUser($input: RegisterUserInput) { - registerUser(input: $input) { - id - email - fullName - } - } -`;