From d8e1f6df81ed6351e633bc3e8620054826924ae7 Mon Sep 17 00:00:00 2001
From: Faruk AYDIN <omerfaruk26@gmail.com>
Date: Fri, 28 Oct 2022 13:43:01 +0200
Subject: [PATCH] refactor: Remove test run and completion check for flick
 triggers

---
 .../apps/flickr/triggers/new-albums/new-albums.ts   | 13 +++++--------
 .../new-favorite-photos/new-favorite-photos.ts      | 11 ++++-------
 .../new-photos-in-album/new-photos-in-album.ts      | 11 ++++-------
 3 files changed, 13 insertions(+), 22 deletions(-)

diff --git a/packages/backend/src/apps/flickr/triggers/new-albums/new-albums.ts b/packages/backend/src/apps/flickr/triggers/new-albums/new-albums.ts
index 08779cda..918ac412 100644
--- a/packages/backend/src/apps/flickr/triggers/new-albums/new-albums.ts
+++ b/packages/backend/src/apps/flickr/triggers/new-albums/new-albums.ts
@@ -19,7 +19,7 @@ const extraFields = [
   'url_t',
   'url_s',
   'url_m',
-  'url_o'
+  'url_o',
 ].join(',');
 
 const newAlbums = async ($: IGlobalVariable) => {
@@ -42,17 +42,14 @@ const newAlbums = async ($: IGlobalVariable) => {
     pages = photosets.pages;
 
     for (const photoset of photosets.photoset) {
-      if ($.flow.isAlreadyProcessed(photoset.id) && !$.execution.testRun)
-        return;
-
       $.pushTriggerItem({
         raw: photoset,
         meta: {
-          internalId: photoset.id as string
-        }
-      })
+          internalId: photoset.id as string,
+        },
+      });
     }
-  } while (page <= pages && !$.execution.testRun);
+  } while (page <= pages);
 };
 
 export default newAlbums;
diff --git a/packages/backend/src/apps/flickr/triggers/new-favorite-photos/new-favorite-photos.ts b/packages/backend/src/apps/flickr/triggers/new-favorite-photos/new-favorite-photos.ts
index 61feb645..4e7f9842 100644
--- a/packages/backend/src/apps/flickr/triggers/new-favorite-photos/new-favorite-photos.ts
+++ b/packages/backend/src/apps/flickr/triggers/new-favorite-photos/new-favorite-photos.ts
@@ -48,17 +48,14 @@ const newPhotos = async ($: IGlobalVariable) => {
     pages = photos.pages;
 
     for (const photo of photos.photo) {
-      if ($.flow.isAlreadyProcessed(photo.date_faved) && !$.execution.testRun)
-        return;
-
       $.pushTriggerItem({
         raw: photo,
         meta: {
-          internalId: photo.date_faved as string
-        }
-      })
+          internalId: photo.date_faved as string,
+        },
+      });
     }
-  } while (page <= pages && !$.execution.testRun);
+  } while (page <= pages);
 };
 
 export default newPhotos;
diff --git a/packages/backend/src/apps/flickr/triggers/new-photos-in-album/new-photos-in-album.ts b/packages/backend/src/apps/flickr/triggers/new-photos-in-album/new-photos-in-album.ts
index 0ac6c601..98ba9ff3 100644
--- a/packages/backend/src/apps/flickr/triggers/new-photos-in-album/new-photos-in-album.ts
+++ b/packages/backend/src/apps/flickr/triggers/new-photos-in-album/new-photos-in-album.ts
@@ -43,17 +43,14 @@ const newPhotosInAlbum = async ($: IGlobalVariable) => {
     pages = photoset.pages;
 
     for (const photo of photoset.photo) {
-      if ($.flow.isAlreadyProcessed(photo.id) && !$.execution.testRun)
-        return;
-
       $.pushTriggerItem({
         raw: photo,
         meta: {
-          internalId: photo.id as string
-        }
-      })
+          internalId: photo.id as string,
+        },
+      });
     }
-  } while (page <= pages && !$.execution.testRun);
+  } while (page <= pages);
 };
 
 export default newPhotosInAlbum;