From d812bb431f130bd29b03e1bb1edce5df7715125d Mon Sep 17 00:00:00 2001 From: Faruk AYDIN Date: Sun, 11 Sep 2022 15:21:25 +0300 Subject: [PATCH] fix: Throw error before getting slack messages for find messages action --- .../slack/client/endpoints/find-messages.ts | 26 +++++++------------ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/packages/backend/src/apps/slack/client/endpoints/find-messages.ts b/packages/backend/src/apps/slack/client/endpoints/find-messages.ts index c343a833..50d99819 100644 --- a/packages/backend/src/apps/slack/client/endpoints/find-messages.ts +++ b/packages/backend/src/apps/slack/client/endpoints/find-messages.ts @@ -7,12 +7,7 @@ export default class FindMessages { this.client = client; } - async run( - query: string, - sortBy: string, - sortDirection: string, - count = 1, - ) { + async run(query: string, sortBy: string, sortDirection: string, count = 1) { const headers = { Authorization: `Bearer ${this.client.connection.formattedData.accessToken}`, }; @@ -24,27 +19,26 @@ export default class FindMessages { count, }; - const response = await this.client.httpClient.get( - '/search.messages', - { headers, params } - ); + const response = await this.client.httpClient.get('/search.messages', { + headers, + params, + }); const data = response.data; - const messages = data.messages.matches; - const message = messages?.[0]; if (!data.ok) { if (data.error === 'missing_scope') { throw new Error( `Error occured while finding messages; ${data.error}: ${data.needed}` - ) + ); } - throw new Error( - `Error occured while finding messages; ${data.error}` - ); + throw new Error(`Error occured while finding messages; ${data.error}`); } + const messages = data.messages.matches; + const message = messages?.[0]; + return message; } }