groot/automatisch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: Cover bad request responses for API endpoint tests

Browse Source
This commit is contained in:
Faruk AYDIN
2024-02-26 13:30:30 +01:00
parent 404ea94dd2
commit d74b215169
6 changed files with 74 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/backend/src/controllers/api/v1/admin/app-auth-clients/get-app-auth-client.test.js
View File

@@ -33,13 +33,20 @@ describe('GET /api/v1/admin/app-auth-clients/:appAuthClientId', () => {
expect(response.body).toEqual(expectedPayload);
});
it('should return not found response for not existing app auth client ID', async () => {
const invalidAppAuthClientId = Crypto.randomUUID();
it('should return not found response for not existing app auth client UUID', async () => {
const notExistingAppAuthClientUUID = Crypto.randomUUID();
await request(app)
.get(`/api/v1/admin/app-auth-clients/${invalidAppAuthClientId}`)
.get(`/api/v1/admin/app-auth-clients/${notExistingAppAuthClientUUID}`)
.set('Authorization', token)
.expect(404);
});
it('should return bad request response for invalid UUID', async () => {
await request(app)
.get('/api/v1/admin/app-auth-clients/invalidAppAuthClientUUID')
.set('Authorization', token)
.expect(400);
});
});
});

15
packages/backend/src/controllers/api/v1/admin/roles/get-role.ee.test.js
View File

@@ -37,14 +37,23 @@ describe('GET /api/v1/admin/roles/:roleId', () => {
expect(response.body).toEqual(expectedPayload);
});
it('should return not found response for not existing role ID', async () => {
it('should return not found response for not existing role UUID', async () => {
vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true);
const invalidRoleId = Crypto.randomUUID();
const notExistingRoleUUID = Crypto.randomUUID();
await request(app)
.get(`/api/v1/admin/roles/${invalidRoleId}`)
.get(`/api/v1/admin/roles/${notExistingRoleUUID}`)
.set('Authorization', token)
.expect(404);
});
it('should return bad request response for invalid UUID', async () => {
vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true);
await request(app)
.get('/api/v1/admin/roles/invalidRoleUUID')
.set('Authorization', token)
.expect(400);
});
});

17
packages/backend/src/controllers/api/v1/admin/saml-auth-providers/get-saml-auth-provider.ee.test.js
View File

@@ -33,14 +33,25 @@ describe('GET /api/v1/admin/saml-auth-provider/:samlAuthProviderId', () => {
expect(response.body).toEqual(expectedPayload);
});
it('should return not found response for not existing saml auth provider ID', async () => {
it('should return not found response for not existing saml auth provider UUID', async () => {
vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true);
const invalidSamlAuthProviderId = Crypto.randomUUID();
const notExistingSamlAuthProviderUUID = Crypto.randomUUID();
await request(app)
.get(`/api/v1/admin/saml-auth-providers/${invalidSamlAuthProviderId}`)
.get(
`/api/v1/admin/saml-auth-providers/${notExistingSamlAuthProviderUUID}`
)
.set('Authorization', token)
.expect(404);
});
it('should return bad request response for invalid UUID', async () => {
vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true);
await request(app)
.get('/api/v1/admin/saml-auth-providers/invalidSamlAuthProviderUUID')
.set('Authorization', token)
.expect(400);
});
});

15
packages/backend/src/controllers/api/v1/admin/users/get-user.ee.test.js
View File

@@ -33,14 +33,23 @@ describe('GET /api/v1/admin/users/:userId', () => {
expect(response.body).toEqual(expectedPayload);
});
it('should return not found response for not existing user ID', async () => {
it('should return not found response for not existing user UUID', async () => {
vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true);
const invalidUserId = Crypto.randomUUID();
const notExistingUserUUID = Crypto.randomUUID();
await request(app)
.get(`/api/v1/admin/users/${invalidUserId}`)
.get(`/api/v1/admin/users/${notExistingUserUUID}`)
.set('Authorization', token)
.expect(404);
});
it('should return bad request response for invalid UUID', async () => {
vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true);
await request(app)
.get('/api/v1/admin/users/invalidUserUUID')
.set('Authorization', token)
.expect(400);
});
});

11
packages/backend/src/controllers/api/v1/app-auth-clients/get-app-auth-client.test.js
View File

@@ -31,11 +31,18 @@ describe('GET /api/v1/app-auth-clients/:id', () => {
});
it('should return not found response for not existing app auth client ID', async () => {
const invalidAppAuthClientId = Crypto.randomUUID();
const notExistingAppAuthClientUUID = Crypto.randomUUID();
await request(app)
.get(`/api/v1/app-auth-clients/${invalidAppAuthClientId}`)
.get(`/api/v1/app-auth-clients/${notExistingAppAuthClientUUID}`)
.set('Authorization', token)
.expect(404);
});
it('should return bad request response for invalid UUID', async () => {
await request(app)
.get('/api/v1/app-auth-clients/invalidAppAuthClientUUID')
.set('Authorization', token)
.expect(400);
});
});

20
packages/backend/src/controllers/api/v1/flows/get-flow.test.js
View File

@@ -70,7 +70,7 @@ describe('GET /api/v1/flows/:flowId', () => {
expect(response.body).toEqual(expectedPayload);
});
it('should return not found response for not existing flow id', async () => {
it('should return not found response for not existing flow UUID', async () => {
await createPermission({
action: 'read',
subject: 'Flow',
@@ -78,11 +78,25 @@ describe('GET /api/v1/flows/:flowId', () => {
conditions: [],
});
const invalidFlowId = Crypto.randomUUID();
const notExistingFlowUUID = Crypto.randomUUID();
await request(app)
.get(`/api/v1/flows/${invalidFlowId}`)
.get(`/api/v1/flows/${notExistingFlowUUID}`)
.set('Authorization', token)
.expect(404);
});
it('should return bad request response for invalid UUID', async () => {
await createPermission({
action: 'read',
subject: 'Flow',
roleId: currentUserRole.id,
conditions: [],
});
await request(app)
.get('/api/v1/flows/invalidFlowUUID')
.set('Authorization', token)
.expect(400);
});
});