From d66be231b3bd29a9d6c70dfee7bcb467a6b97455 Mon Sep 17 00:00:00 2001
From: Faruk AYDIN <omerfaruk26@gmail.com>
Date: Thu, 24 Oct 2024 17:00:47 +0200
Subject: [PATCH] refactor: Remove redundant updateConnectionAllowedProperty

---
 packages/backend/src/models/app-config.js     |  8 ------
 .../backend/src/models/app-config.test.js     | 25 -------------------
 2 files changed, 33 deletions(-)

diff --git a/packages/backend/src/models/app-config.js b/packages/backend/src/models/app-config.js
index a996f378..2511f437 100644
--- a/packages/backend/src/models/app-config.js
+++ b/packages/backend/src/models/app-config.js
@@ -42,14 +42,6 @@ class AppConfig extends Base {
     return await App.findOneByKey(this.key);
   }
 
-  async updateConnectionAllowedProperty() {
-    const connectionAllowed = await this.computeConnectionAllowedProperty();
-
-    return await this.$query().patch({
-      connectionAllowed,
-    });
-  }
-
   async computeAndAssignConnectionAllowedProperty() {
     this.connectionAllowed = await this.computeConnectionAllowedProperty();
   }
diff --git a/packages/backend/src/models/app-config.test.js b/packages/backend/src/models/app-config.test.js
index 410d31b5..4945066c 100644
--- a/packages/backend/src/models/app-config.test.js
+++ b/packages/backend/src/models/app-config.test.js
@@ -56,31 +56,6 @@ describe('AppConfig model', () => {
     });
   });
 
-  describe('updateConnectionAllowedProperty', () => {
-    it('should call computeConnectionAllowedProperty and patch the result', async () => {
-      const appConfig = await createAppConfig();
-
-      const computeConnectionAllowedPropertySpy = vi
-        .spyOn(appConfig, 'computeConnectionAllowedProperty')
-        .mockResolvedValue(true);
-
-      const patchSpy = vi
-        .fn()
-        .mockImplementation((newAppConfig) => newAppConfig);
-
-      vi.spyOn(appConfig, '$query').mockImplementation(() => ({
-        patch: patchSpy,
-      }));
-
-      await appConfig.updateConnectionAllowedProperty();
-
-      expect(computeConnectionAllowedPropertySpy).toHaveBeenCalled();
-      expect(patchSpy).toHaveBeenCalledWith({
-        connectionAllowed: true,
-      });
-    });
-  });
-
   describe('computeAndAssignConnectionAllowedProperty', () => {
     it('should call computeConnectionAllowedProperty and assign the result', async () => {
       const appConfig = await createAppConfig();