groot/automatisch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Remove license check for admin, since it is middleware responsibility

Browse Source
This commit is contained in:
Faruk AYDIN
2024-02-24 01:22:27 +01:00
parent ad67b13270
commit c0a216f109
1 changed files with 4 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
packages/backend/src/controllers/api/v1/admin/app-auth-clients/get-app-auth-client.test.js
View File

@@ -5,53 +5,20 @@ import createAuthTokenByUserId from '../../../../../helpers/create-auth-token-by
import { createUser } from '../../../../../../test/factories/user.js'; import { createUser } from '../../../../../../test/factories/user.js';
import getAdminAppAuthClientMock from '../../../../../../test/mocks/rest/api/v1/admin/get-app-auth-client.js'; import getAdminAppAuthClientMock from '../../../../../../test/mocks/rest/api/v1/admin/get-app-auth-client.js';
import { createAppAuthClient } from '../../../../../../test/factories/app-auth-client.js'; import { createAppAuthClient } from '../../../../../../test/factories/app-auth-client.js';
import { createPermission } from '../../../../../../test/factories/permission.js'; import { createRole } from '../../../../../../test/factories/role.js';
import * as license from '../../../../../helpers/license.ee.js'; import * as license from '../../../../../helpers/license.ee.js';
describe('GET /api/v1/admin/app-auth-clients/:appAuthClientId', () => { describe('GET /api/v1/admin/app-auth-clients/:appAuthClientId', () => {
let currentUser, currentAppAuthClient, token; let currentUser, currentUserRole, currentAppAuthClient, token;
describe('without valid license key', () => {
beforeEach(async () => {
vi.spyOn(license, 'hasValidLicense').mockResolvedValue(false);
currentUser = await createUser();
currentAppAuthClient = await createAppAuthClient();
await createPermission({
roleId: currentUser.roleId,
action: 'read',
subject: 'App',
conditions: [],
});
token = createAuthTokenByUserId(currentUser.id);
});
it('should return empty object', async () => {
const response = await request(app)
.get(`/api/v1/admin/app-auth-clients/${currentAppAuthClient.id}`)
.set('Authorization', token)
.expect(403);
expect(response.body).toEqual({});
});
});
describe('with valid license key', () => { describe('with valid license key', () => {
beforeEach(async () => { beforeEach(async () => {
vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true); vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true);
currentUser = await createUser(); currentUserRole = await createRole({ key: 'admin' });
currentUser = await createUser({ roleId: currentUserRole.id });
currentAppAuthClient = await createAppAuthClient(); currentAppAuthClient = await createAppAuthClient();
await createPermission({
roleId: currentUser.roleId,
action: 'read',
subject: 'App',
conditions: [],
});
token = createAuthTokenByUserId(currentUser.id); token = createAuthTokenByUserId(currentUser.id);
}); });