From bcff9f5a9e1741369cb2281b6ad800d78744978e Mon Sep 17 00:00:00 2001
From: Faruk AYDIN <omerfaruk26@gmail.com>
Date: Fri, 21 Oct 2022 19:38:33 +0200
Subject: [PATCH] refactor: Remove dedundant httpError assignment

---
 .../backend/src/apps/github/common/paginate-all.ts    | 11 ++---------
 .../src/apps/slack/data/list-channels/index.ts        |  8 +-------
 .../src/apps/twitter/common/get-user-followers.ts     |  8 +-------
 3 files changed, 4 insertions(+), 23 deletions(-)

diff --git a/packages/backend/src/apps/github/common/paginate-all.ts b/packages/backend/src/apps/github/common/paginate-all.ts
index aa5ed1b8..8a6d6d35 100644
--- a/packages/backend/src/apps/github/common/paginate-all.ts
+++ b/packages/backend/src/apps/github/common/paginate-all.ts
@@ -24,15 +24,8 @@ export default async function paginateAll(
       url: links.next.uri,
     });
 
-    if (nextPageResponse.httpError) {
-      aggregatedResponse.error = nextPageResponse.httpError;
-
-      links = null;
-    } else {
-      aggregatedResponse.data.push(...nextPageResponse.data);
-
-      links = parseLinkHeader(nextPageResponse.headers.link);
-    }
+    aggregatedResponse.data.push(...nextPageResponse.data);
+    links = parseLinkHeader(nextPageResponse.headers.link);
   }
 
   return aggregatedResponse;
diff --git a/packages/backend/src/apps/slack/data/list-channels/index.ts b/packages/backend/src/apps/slack/data/list-channels/index.ts
index e95fed0b..93b7e37a 100644
--- a/packages/backend/src/apps/slack/data/list-channels/index.ts
+++ b/packages/backend/src/apps/slack/data/list-channels/index.ts
@@ -15,14 +15,8 @@ export default {
 
     const response = await $.http.get('/conversations.list');
 
-    if (response.httpError) {
-      channels.error = response.httpError;
-      return channels;
-    }
-
     if (response.data.ok === false) {
-      channels.error = response.data;
-      return channels;
+      throw new Error(response.data);
     }
 
     channels.data = response.data.channels.map((channel: IJSONObject) => {
diff --git a/packages/backend/src/apps/twitter/common/get-user-followers.ts b/packages/backend/src/apps/twitter/common/get-user-followers.ts
index 849b5f29..45d47d3f 100644
--- a/packages/backend/src/apps/twitter/common/get-user-followers.ts
+++ b/packages/backend/src/apps/twitter/common/get-user-followers.ts
@@ -33,14 +33,8 @@ const getUserFollowers = async (
 
     response = await $.http.get(requestPath);
 
-    if (response.httpError) {
-      followers.error = response.httpError;
-      return followers;
-    }
-
     if (response.data?.errors) {
-      followers.error = response.data.errors;
-      return followers;
+      throw new Error(response.data.errors);
     }
 
     if (response.data.meta.result_count > 0) {