From b5e5ae73217050451eaf07d4bdaf5c315988d669 Mon Sep 17 00:00:00 2001
From: Faruk AYDIN <omerfaruk26@gmail.com>
Date: Sat, 15 Oct 2022 11:38:10 +0200
Subject: [PATCH] fix: Do not sort user tweets since it's in
 reverse-chronological order

---
 .../src/apps/twitter/common/get-user-tweets.ts     | 14 +++++---------
 .../src/apps/twitter/triggers/my-tweets/index.ts   |  1 -
 .../src/apps/twitter/triggers/user-tweets/index.ts |  2 --
 3 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/packages/backend/src/apps/twitter/common/get-user-tweets.ts b/packages/backend/src/apps/twitter/common/get-user-tweets.ts
index 4cce058f..6a2f5360 100644
--- a/packages/backend/src/apps/twitter/common/get-user-tweets.ts
+++ b/packages/backend/src/apps/twitter/common/get-user-tweets.ts
@@ -12,8 +12,6 @@ import getUserByUsername from './get-user-by-username';
 
 type IGetUserTweetsOptions = {
   currentUser: boolean;
-  userId?: string;
-  lastInternalId?: string;
 };
 
 const getUserTweets = async (
@@ -39,7 +37,7 @@ const getUserTweets = async (
 
   do {
     const params: IJSONObject = {
-      since_id: options.lastInternalId,
+      since_id: $.execution.testRun ? null : $.flow.lastInternalId,
       pagination_token: response?.data?.meta?.next_token,
     };
 
@@ -63,15 +61,13 @@ const getUserTweets = async (
       response.data.data.forEach((tweet: IJSONObject) => {
         tweets.data.push({
           raw: tweet,
-          meta: { internalId: tweet.id as string },
+          meta: {
+            internalId: tweet.id as string,
+          },
         });
       });
     }
-  } while (response.data.meta.next_token && options.lastInternalId);
-
-  tweets.data.sort((tweet, nextTweet) => {
-    return (tweet.raw.id as number) - (nextTweet.raw.id as number);
-  });
+  } while (response.data.meta.next_token && !$.execution.testRun);
 
   return tweets;
 };
diff --git a/packages/backend/src/apps/twitter/triggers/my-tweets/index.ts b/packages/backend/src/apps/twitter/triggers/my-tweets/index.ts
index bd033d35..7e33be4f 100644
--- a/packages/backend/src/apps/twitter/triggers/my-tweets/index.ts
+++ b/packages/backend/src/apps/twitter/triggers/my-tweets/index.ts
@@ -20,7 +20,6 @@ export default {
   async run($: IGlobalVariable) {
     return await getUserTweets($, {
       currentUser: true,
-      lastInternalId: $.flow.lastInternalId,
     });
   },
 };
diff --git a/packages/backend/src/apps/twitter/triggers/user-tweets/index.ts b/packages/backend/src/apps/twitter/triggers/user-tweets/index.ts
index fe981cb9..db576159 100644
--- a/packages/backend/src/apps/twitter/triggers/user-tweets/index.ts
+++ b/packages/backend/src/apps/twitter/triggers/user-tweets/index.ts
@@ -32,8 +32,6 @@ export default {
   async run($: IGlobalVariable) {
     return await getUserTweets($, {
       currentUser: false,
-      userId: $.step.parameters.username as string,
-      lastInternalId: $.flow.lastInternalId,
     });
   },
 };