groot/automatisch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(e2e): update expect to web-first assertion, wait for edit form to load

Browse Source
This commit is contained in:
QAComet
2024-03-18 10:32:56 -06:00
parent f3d20ab769
commit ad144206dd
4 changed files with 22 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
packages/e2e-tests/tests/admin/manage-roles.spec.js
View File

@@ -5,8 +5,7 @@ test.describe('Role management page', () => {
test('Admin role is not deletable', async ({ adminRolesPage }) => {
await adminRolesPage.navigateTo();
const adminRow = await adminRolesPage.getRoleRowByName('Admin');
const rowCount = await adminRow.count();
await expect(rowCount).toBe(1);
await expect(adminRow).toHaveCount(1);
const data = await adminRolesPage.getRowData(adminRow);
await expect(data.role).toBe('Admin');
await expect(data.canEdit).toBe(true);
@@ -42,8 +41,7 @@ test.describe('Role management page', () => {
const roleRow = await adminRolesPage.getRoleRowByName(
'Create Edit Test'
);
const rowCount = await roleRow.count();
await expect(rowCount).toBe(1);
await expect(roleRow).toHaveCount(1);
const roleData = await adminRolesPage.getRowData(roleRow);
await expect(roleData.role).toBe('Create Edit Test');
await expect(roleData.description).toBe('Test description');
@@ -76,8 +74,7 @@ test.describe('Role management page', () => {
const roleRow = await adminRolesPage.getRoleRowByName(
'Create Update Test'
);
const rowCount = await roleRow.count();
await expect(rowCount).toBe(1);
await expect(roleRow).toHaveCount(1);
const roleData = await adminRolesPage.getRowData(roleRow);
await expect(roleData.role).toBe('Create Update Test');
await expect(roleData.description).toBe('Update test description');
@@ -105,8 +102,7 @@ test.describe('Role management page', () => {
await deleteModal.modal.waitFor({
state: 'detached',
});
const rowCount = await roleRow.count();
await expect(rowCount).toBe(0);
await expect(roleRow).toHaveCount(0);
});
});
@@ -468,7 +464,6 @@ test('Accessibility of role management page', async ({
await deleteModal.modal.waitFor({
state: 'detached',
});
const rowCount = await roleRow.count();
await expect(rowCount).toBe(0);
await expect(roleRow).toHaveCount(0);
});
});

3
packages/e2e-tests/tests/admin/manage-users.spec.js
View File

@@ -60,6 +60,7 @@ test.describe('User management page', () => {
let userRow = await adminUsersPage.getUserRowByEmail(user.email);
await adminUsersPage.clickEditUser(userRow);
await adminEditUserPage.waitForLoad(user.fullName);
const newUserInfo = adminEditUserPage.generateUser();
await adminEditUserPage.fullNameInput.fill(newUserInfo.fullName);
await adminEditUserPage.updateButton.click();
@@ -269,7 +270,7 @@ test.describe('User management page', () => {
await adminUsersPage.findUserPageWithEmail(user2.email);
let userRow = await adminUsersPage.getUserRowByEmail(user2.email);
await adminUsersPage.clickEditUser(userRow);
await adminEditUserPage.waitForLoad(user2.fullName);
await adminEditUserPage.emailInput.fill(user1.email);
const editPageUrl = page.url();
await adminEditUserPage.updateButton.click();