From a769f7880144049e5693fafda2c9649d68646247 Mon Sep 17 00:00:00 2001 From: Faruk AYDIN Date: Wed, 14 Feb 2024 01:20:29 +0100 Subject: [PATCH] test: Add tests for api/v1/users API endpoint --- .../api/v1/users/get-users.test.js | 56 +++++++++++++++++++ packages/backend/src/helpers/authorization.js | 4 ++ .../test/mocks/rest/api/v1/users/get-users.js | 38 +++++++++++++ 3 files changed, 98 insertions(+) create mode 100644 packages/backend/src/controllers/api/v1/users/get-users.test.js create mode 100644 packages/backend/test/mocks/rest/api/v1/users/get-users.js diff --git a/packages/backend/src/controllers/api/v1/users/get-users.test.js b/packages/backend/src/controllers/api/v1/users/get-users.test.js new file mode 100644 index 00000000..ed8baeba --- /dev/null +++ b/packages/backend/src/controllers/api/v1/users/get-users.test.js @@ -0,0 +1,56 @@ +import { describe, it, expect, beforeEach } from 'vitest'; +import request from 'supertest'; +import app from '../../../../app'; +import createAuthTokenByUserId from '../../../../helpers/create-auth-token-by-user-id'; +import { createRole } from '../../../../../test/factories/role'; +import { createPermission } from '../../../../../test/factories/permission'; +import { createUser } from '../../../../../test/factories/user'; +import getUsersMock from '../../../../../test/mocks/rest/api/v1/users/get-users'; + +describe('GET /api/v1/users', () => { + let currentUser, currentUserRole, anotherUser, anotherUserRole, token; + + beforeEach(async () => { + currentUserRole = await createRole({ + key: 'currentUser', + name: 'Current user role', + }); + + await createPermission({ + action: 'read', + subject: 'User', + roleId: currentUserRole.id, + }); + + currentUser = await createUser({ + roleId: currentUserRole.id, + fullName: 'Current User', + }); + + anotherUserRole = await createRole({ + key: 'anotherUser', + name: 'Another user role', + }); + + anotherUser = await createUser({ + roleId: anotherUserRole.id, + fullName: 'Another User', + }); + + token = createAuthTokenByUserId(currentUser.id); + }); + + it('should return users data', async () => { + const response = await request(app) + .get('/api/v1/users') + .set('Authorization', token) + .expect(200); + + const expectedResponsePayload = await getUsersMock( + [anotherUser, currentUser], + [anotherUserRole, currentUserRole] + ); + + expect(response.body).toEqual(expectedResponsePayload); + }); +}); diff --git a/packages/backend/src/helpers/authorization.js b/packages/backend/src/helpers/authorization.js index a027dbac..28cefc59 100644 --- a/packages/backend/src/helpers/authorization.js +++ b/packages/backend/src/helpers/authorization.js @@ -3,6 +3,10 @@ const authorizationList = { action: 'read', subject: 'User', }, + '/api/v1/users/': { + action: 'read', + subject: 'User', + }, }; export const authorizeUser = async (request, response, next) => { diff --git a/packages/backend/test/mocks/rest/api/v1/users/get-users.js b/packages/backend/test/mocks/rest/api/v1/users/get-users.js new file mode 100644 index 00000000..73d27474 --- /dev/null +++ b/packages/backend/test/mocks/rest/api/v1/users/get-users.js @@ -0,0 +1,38 @@ +const getUsersMock = async (users, roles) => { + const data = users.map((user) => { + const role = roles.find((r) => r.id === user.roleId); + return { + createdAt: user.createdAt.toISOString(), + email: user.email, + fullName: user.fullName, + id: user.id, + role: role + ? { + createdAt: role.createdAt.toISOString(), + description: role.description, + id: role.id, + isAdmin: role.isAdmin, + key: role.key, + name: role.name, + updatedAt: role.updatedAt.toISOString(), + } + : null, // Fallback to null if role not found + roleId: user.roleId, + trialExpiryDate: user.trialExpiryDate.toISOString(), + updatedAt: user.updatedAt.toISOString(), + }; + }); + + return { + data: data, + meta: { + count: data.length, + currentPage: 1, + isArray: true, + totalPages: 1, + type: 'User', + }, + }; +}; + +export default getUsersMock;