test(queries/get-config): incorporate feature flags
cover disableNotificationsPage and disableFavicon feature flags
This commit is contained in:
@@ -2,14 +2,14 @@ import appConfig from '../../config/app.js';
|
|||||||
import { hasValidLicense } from '../../helpers/license.ee.js';
|
import { hasValidLicense } from '../../helpers/license.ee.js';
|
||||||
import Config from '../../models/config.js';
|
import Config from '../../models/config.js';
|
||||||
|
|
||||||
const defaultConfig = {
|
|
||||||
disableNotificationsPage: appConfig.disableNotificationsPage,
|
|
||||||
disableFavicon: appConfig.disableFavicon,
|
|
||||||
};
|
|
||||||
|
|
||||||
const getConfig = async (_parent, params) => {
|
const getConfig = async (_parent, params) => {
|
||||||
if (!(await hasValidLicense())) return {};
|
if (!(await hasValidLicense())) return {};
|
||||||
|
|
||||||
|
const defaultConfig = {
|
||||||
|
disableNotificationsPage: appConfig.disableNotificationsPage,
|
||||||
|
disableFavicon: appConfig.disableFavicon,
|
||||||
|
};
|
||||||
|
|
||||||
const configQuery = Config.query();
|
const configQuery = Config.query();
|
||||||
|
|
||||||
if (Array.isArray(params.keys)) {
|
if (Array.isArray(params.keys)) {
|
||||||
|
@@ -2,6 +2,7 @@ import { vi, describe, it, expect, beforeEach } from 'vitest';
|
|||||||
import request from 'supertest';
|
import request from 'supertest';
|
||||||
import app from '../../app';
|
import app from '../../app';
|
||||||
import { createConfig } from '../../../test/factories/config';
|
import { createConfig } from '../../../test/factories/config';
|
||||||
|
import appConfig from '../../config/app';
|
||||||
import * as license from '../../helpers/license.ee';
|
import * as license from '../../helpers/license.ee';
|
||||||
|
|
||||||
describe('graphQL getConfig query', () => {
|
describe('graphQL getConfig query', () => {
|
||||||
@@ -56,6 +57,8 @@ describe('graphQL getConfig query', () => {
|
|||||||
[configOne.key]: configOne.value.data,
|
[configOne.key]: configOne.value.data,
|
||||||
[configTwo.key]: configTwo.value.data,
|
[configTwo.key]: configTwo.value.data,
|
||||||
[configThree.key]: configThree.value.data,
|
[configThree.key]: configThree.value.data,
|
||||||
|
disableNotificationsPage: false,
|
||||||
|
disableFavicon: false,
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
@@ -82,6 +85,38 @@ describe('graphQL getConfig query', () => {
|
|||||||
getConfig: {
|
getConfig: {
|
||||||
[configOne.key]: configOne.value.data,
|
[configOne.key]: configOne.value.data,
|
||||||
[configTwo.key]: configTwo.value.data,
|
[configTwo.key]: configTwo.value.data,
|
||||||
|
disableNotificationsPage: false,
|
||||||
|
disableFavicon: false,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
expect(response.body).toEqual(expectedResponsePayload);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('and with different defaults', () => {
|
||||||
|
beforeEach(async () => {
|
||||||
|
vi.spyOn(appConfig, 'disableNotificationsPage', 'get').mockReturnValue(
|
||||||
|
true
|
||||||
|
);
|
||||||
|
vi.spyOn(appConfig, 'disableFavicon', 'get').mockReturnValue(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('should return custom config', async () => {
|
||||||
|
const response = await request(app)
|
||||||
|
.post('/graphql')
|
||||||
|
.send({ query })
|
||||||
|
.expect(200);
|
||||||
|
|
||||||
|
const expectedResponsePayload = {
|
||||||
|
data: {
|
||||||
|
getConfig: {
|
||||||
|
[configOne.key]: configOne.value.data,
|
||||||
|
[configTwo.key]: configTwo.value.data,
|
||||||
|
[configThree.key]: configThree.value.data,
|
||||||
|
disableNotificationsPage: true,
|
||||||
|
disableFavicon: true,
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
Reference in New Issue
Block a user