From 96007a1f4818c452a477c53cb562adb2fe4e5682 Mon Sep 17 00:00:00 2001 From: Faruk AYDIN Date: Fri, 28 Oct 2022 00:25:33 +0200 Subject: [PATCH] refactor: Remove pagination and test run checks from user tweets --- packages/backend/src/apps/twitter/common/get-user-tweets.ts | 4 ++-- packages/backend/src/apps/twitter/triggers/my-tweets/index.ts | 4 ---- .../backend/src/apps/twitter/triggers/user-tweets/index.ts | 4 ---- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/packages/backend/src/apps/twitter/common/get-user-tweets.ts b/packages/backend/src/apps/twitter/common/get-user-tweets.ts index 6d0f2807..2eb2aa11 100644 --- a/packages/backend/src/apps/twitter/common/get-user-tweets.ts +++ b/packages/backend/src/apps/twitter/common/get-user-tweets.ts @@ -16,7 +16,7 @@ const fetchTweets = async ($: IGlobalVariable, username: string) => { do { const params: IJSONObject = { - since_id: $.execution.testRun ? null : $.flow.lastInternalId, + since_id: $.flow.lastInternalId, pagination_token: response?.data?.meta?.next_token, }; @@ -40,7 +40,7 @@ const fetchTweets = async ($: IGlobalVariable, username: string) => { $.pushTriggerItem(dataItem); }); } - } while (response.data.meta.next_token && !$.execution.testRun); + } while (response.data.meta.next_token); return $.triggerOutput; }; diff --git a/packages/backend/src/apps/twitter/triggers/my-tweets/index.ts b/packages/backend/src/apps/twitter/triggers/my-tweets/index.ts index cfcd13f2..134e9084 100644 --- a/packages/backend/src/apps/twitter/triggers/my-tweets/index.ts +++ b/packages/backend/src/apps/twitter/triggers/my-tweets/index.ts @@ -20,8 +20,4 @@ export default defineTrigger({ async run($) { await getUserTweets($, { currentUser: true }); }, - - sort(tweet, nextTweet) { - return Number(nextTweet.meta.internalId) - Number(tweet.meta.internalId); - }, }); diff --git a/packages/backend/src/apps/twitter/triggers/user-tweets/index.ts b/packages/backend/src/apps/twitter/triggers/user-tweets/index.ts index dab530ae..4e07959b 100644 --- a/packages/backend/src/apps/twitter/triggers/user-tweets/index.ts +++ b/packages/backend/src/apps/twitter/triggers/user-tweets/index.ts @@ -32,8 +32,4 @@ export default defineTrigger({ async run($) { await getUserTweets($, { currentUser: false }); }, - - sort(tweet, nextTweet) { - return Number(nextTweet.meta.internalId) - Number(tweet.meta.internalId); - }, });