Merge pull request #2119 from automatisch/execution-step-test

tests: Implement tests for ExecutionStep model

packages/backend/src/models/__snapshots__/execution-step.test.js.snap

@@ -0,0 +1,54 @@
+// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
+
+exports[`ExecutionStep model > jsonSchema should have correct validations 1`] = `
+{
+  "properties": {
+    "createdAt": {
+      "type": "string",
+    },
+    "dataIn": {
+      "type": [
+        "object",
+        "null",
+      ],
+    },
+    "dataOut": {
+      "type": [
+        "object",
+        "null",
+      ],
+    },
+    "deletedAt": {
+      "type": "string",
+    },
+    "errorDetails": {
+      "type": [
+        "object",
+        "null",
+      ],
+    },
+    "executionId": {
+      "format": "uuid",
+      "type": "string",
+    },
+    "id": {
+      "format": "uuid",
+      "type": "string",
+    },
+    "status": {
+      "enum": [
+        "success",
+        "failure",
+      ],
+      "type": "string",
+    },
+    "stepId": {
+      "type": "string",
+    },
+    "updatedAt": {
+      "type": "string",
+    },
+  },
+  "type": "object",
+}
+`;

packages/backend/src/models/execution-step.js

@@ -47,21 +47,31 @@ class ExecutionStep extends Base {
     return this.status === 'failure';
   }
 
+  async isSucceededNonTestRun() {
+    const execution = await this.$relatedQuery('execution');
+    return !execution.testRun && !this.isFailed;
+  }
+
+  async updateUsageData() {
+    const execution = await this.$relatedQuery('execution');
+
+    const flow = await execution.$relatedQuery('flow');
+    const user = await flow.$relatedQuery('user');
+    const usageData = await user.$relatedQuery('currentUsageData');
+
+    await usageData.increaseConsumedTaskCountByOne();
+  }
+
+  async increaseUsageCount() {
+    if (appConfig.isCloud && this.isSucceededNonTestRun()) {
+      await this.updateUsageData();
+    }
+  }
+
   async $afterInsert(queryContext) {
     await super.$afterInsert(queryContext);
     Telemetry.executionStepCreated(this);
-
+    await this.increaseUsageCount();
-    if (appConfig.isCloud) {
-      const execution = await this.$relatedQuery('execution');
-
-      if (!execution.testRun && !this.isFailed) {
-        const flow = await execution.$relatedQuery('flow');
-        const user = await flow.$relatedQuery('user');
-        const usageData = await user.$relatedQuery('currentUsageData');
-
-        await usageData.increaseConsumedTaskCountByOne();
-      }
-    }
   }
 }
 

packages/backend/src/models/execution-step.test.js

@@ -0,0 +1,152 @@
+import { vi, describe, it, expect } from 'vitest';
+import Execution from './execution';
+import ExecutionStep from './execution-step';
+import Step from './step';
+import Base from './base';
+import UsageData from './usage-data.ee';
+import Telemetry from '../helpers/telemetry';
+import appConfig from '../config/app';
+import { createExecution } from '../../test/factories/execution';
+import { createExecutionStep } from '../../test/factories/execution-step';
+
+describe('ExecutionStep model', () => {
+  it('tableName should return correct name', () => {
+    expect(ExecutionStep.tableName).toBe('execution_steps');
+  });
+
+  it('jsonSchema should have correct validations', () => {
+    expect(ExecutionStep.jsonSchema).toMatchSnapshot();
+  });
+
+  it('relationMappings should return correct associations', () => {
+    const relationMappings = ExecutionStep.relationMappings();
+
+    const expectedRelations = {
+      execution: {
+        relation: Base.BelongsToOneRelation,
+        modelClass: Execution,
+        join: {
+          from: 'execution_steps.execution_id',
+          to: 'executions.id',
+        },
+      },
+      step: {
+        relation: Base.BelongsToOneRelation,
+        modelClass: Step,
+        join: {
+          from: 'execution_steps.step_id',
+          to: 'steps.id',
+        },
+      },
+    };
+
+    expect(relationMappings).toStrictEqual(expectedRelations);
+  });
+
+  describe('isFailed', () => {
+    it('should return true if status is failure', async () => {
+      const executionStep = new ExecutionStep();
+      executionStep.status = 'failure';
+
+      expect(executionStep.isFailed).toBe(true);
+    });
+
+    it('should return false if status is not failure', async () => {
+      const executionStep = new ExecutionStep();
+      executionStep.status = 'success';
+
+      expect(executionStep.isFailed).toBe(false);
+    });
+  });
+
+  describe('isSucceededNonTestRun', () => {
+    it('should return false if it has a test run execution', async () => {
+      const execution = await createExecution({
+        testRun: true,
+      });
+
+      const executionStep = await createExecutionStep({
+        executionId: execution.id,
+      });
+
+      expect(await executionStep.isSucceededNonTestRun()).toBe(false);
+    });
+
+    it('should return false if it has a failure status', async () => {
+      const executionStep = await createExecutionStep({
+        status: 'failure',
+      });
+
+      expect(await executionStep.isSucceededNonTestRun()).toBe(false);
+    });
+
+    it('should return true if it has a succeeded non test run', async () => {
+      const executionStep = await createExecutionStep({
+        status: 'success',
+      });
+
+      expect(await executionStep.isSucceededNonTestRun()).toBe(true);
+    });
+  });
+
+  describe('updateUsageData', () => {
+    it('should call usageData.increaseConsumedTaskCountByOne', async () => {
+      const executionStep = await createExecutionStep();
+
+      const increaseConsumedTaskCountByOneSpy = vi.spyOn(
+        UsageData.prototype,
+        'increaseConsumedTaskCountByOne'
+      );
+
+      await executionStep.updateUsageData();
+
+      expect(increaseConsumedTaskCountByOneSpy).toHaveBeenCalledOnce();
+    });
+  });
+
+  describe('increaseUsageCount', () => {
+    it('should call updateUsageData for cloud and succeeded non test run', async () => {
+      vi.spyOn(appConfig, 'isCloud', 'get').mockReturnValue(true);
+      vi.spyOn(
+        ExecutionStep.prototype,
+        'isSucceededNonTestRun'
+      ).mockReturnValue(true);
+
+      const executionStep = await createExecutionStep();
+
+      const updateUsageDataSpy = vi.spyOn(
+        ExecutionStep.prototype,
+        'updateUsageData'
+      );
+
+      await executionStep.increaseUsageCount();
+
+      expect(updateUsageDataSpy).toHaveBeenCalledOnce();
+    });
+  });
+
+  describe('$afterInsert', () => {
+    it('should call Telemetry.executionStepCreated', async () => {
+      const telemetryExecutionStepCreatedSpy = vi
+        .spyOn(Telemetry, 'executionStepCreated')
+        .mockImplementation(() => {});
+
+      const executionStep = await createExecutionStep();
+
+      expect(telemetryExecutionStepCreatedSpy).toHaveBeenCalledWith(
+        executionStep
+      );
+    });
+
+    it('should call increaseUsageCount', async () => {
+      const increaseUsageCountSpy = vi.spyOn(
+        ExecutionStep.prototype,
+        'increaseUsageCount'
+      );
+
+      await createExecutionStep();
+
+      expect(increaseUsageCountSpy).toHaveBeenCalledOnce();
+    });
+  });
+});