groot/automatisch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: AppConfig model and corresponding tests

Browse Source
This commit is contained in:
Faruk AYDIN
2024-10-15 14:22:38 +02:00
parent d87ee4daa3
commit 91993dbb07
2 changed files with 111 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
packages/backend/src/models/app-config.js
View File

@@ -38,48 +38,45 @@ class AppConfig extends Base {
return await App.findOneByKey(this.key);
}
async computeConnectionAllowedProperty(oldAppConfig) {
const appAuthClients = await oldAppConfig.$relatedQuery('appAuthClients');
const hasSomeActiveAppAuthClients = !!appAuthClients?.some(
(appAuthClient) => appAuthClient.active
);
const shared = this.shared ?? oldAppConfig.shared;
const disabled = this.disabled ?? oldAppConfig.disabled;
const active = disabled === false;
const conditions = [hasSomeActiveAppAuthClients, shared, active];
const connectionAllowed = conditions.every(Boolean);
return connectionAllowed;
}
async updateConnectionAllowedProperty() {
const connectionAllowed = await this.computeConnectionAllowedProperty(this);
const connectionAllowed = await this.computeConnectionAllowedProperty();
return await this.$query().patch({
connectionAllowed,
});
}
async computeAndAssignConnectionAllowedProperty(oldAppConfig) {
this.connectionAllowed = await this.computeConnectionAllowedProperty(
oldAppConfig
);
async computeAndAssignConnectionAllowedProperty() {
this.connectionAllowed = await this.computeConnectionAllowedProperty();
}
async computeConnectionAllowedProperty() {
const appAuthClients = await this.$relatedQuery('appAuthClients');
const hasSomeActiveAppAuthClients =
appAuthClients?.some((appAuthClient) => appAuthClient.active) || false;
const conditions = [
hasSomeActiveAppAuthClients,
this.shared,
!this.disabled,
];
const connectionAllowed = conditions.every(Boolean);
return connectionAllowed;
}
async $beforeInsert(queryContext) {
await super.$beforeInsert(queryContext);
await this.computeAndAssignConnectionAllowedProperty(this);
await this.computeAndAssignConnectionAllowedProperty();
}
async $beforeUpdate(opt, queryContext) {
await super.$beforeUpdate(opt, queryContext);
const oldAppConfig = opt.old;
await this.computeAndAssignConnectionAllowedProperty(oldAppConfig);
await this.computeAndAssignConnectionAllowedProperty();
}
}