From 9006a0c25f153241da5acc4c9b446dfceccc8698 Mon Sep 17 00:00:00 2001
From: Faruk AYDIN <omerfaruk26@gmail.com>
Date: Mon, 23 Sep 2024 16:32:36 +0300
Subject: [PATCH] refactor: Update required validations with custom assertion

---
 packages/backend/src/models/datastore.js      |  2 +-
 packages/backend/src/models/datastore.test.js | 22 ++++---------------
 2 files changed, 5 insertions(+), 19 deletions(-)

diff --git a/packages/backend/src/models/datastore.js b/packages/backend/src/models/datastore.js
index 015bb824..aad86de5 100644
--- a/packages/backend/src/models/datastore.js
+++ b/packages/backend/src/models/datastore.js
@@ -5,7 +5,7 @@ class Datastore extends Base {
 
   static jsonSchema = {
     type: 'object',
-    required: ['key', 'value', 'scope', 'scopeId'],
+    required: ['key', 'value', 'scopeId'],
 
     properties: {
       id: { type: 'string', format: 'uuid' },
diff --git a/packages/backend/src/models/datastore.test.js b/packages/backend/src/models/datastore.test.js
index cc5eda18..85d8c62d 100644
--- a/packages/backend/src/models/datastore.test.js
+++ b/packages/backend/src/models/datastore.test.js
@@ -6,23 +6,9 @@ describe('Datastore model', () => {
     expect(Datastore.tableName).toBe('datastore');
   });
 
-  it('jsonSchema should have the correct schema', () => {
-    const expectedSchema = {
-      type: 'object',
-      required: ['key', 'value', 'scope', 'scopeId'],
-      properties: {
-        id: { type: 'string', format: 'uuid' },
-        key: { type: 'string', minLength: 1 },
-        value: { type: 'string' },
-        scope: {
-          type: 'string',
-          enum: ['flow'],
-          default: 'flow',
-        },
-        scopeId: { type: 'string', format: 'uuid' },
-      },
-    };
-
-    expect(Datastore.jsonSchema).toStrictEqual(expectedSchema);
+  it('jsonSchema should have correct validations', () => {
+    expect(Datastore).toRequireProperty('key');
+    expect(Datastore).toRequireProperty('value');
+    expect(Datastore).toRequireProperty('scopeId');
   });
 });