From 882612584521f4ab6e452c7b9e34171111fb418a Mon Sep 17 00:00:00 2001
From: Faruk AYDIN <omerfaruk26@gmail.com>
Date: Mon, 19 Sep 2022 12:13:36 +0300
Subject: [PATCH] feat: Draft implementation to store and expose integration
 errors

---
 .../twitter/client/endpoints/search-tweets.ts | 25 ++++++-------
 .../backend/src/helpers/http-client/index.ts  |  7 +++-
 packages/backend/src/services/processor.ts    | 36 ++++++++++++++-----
 3 files changed, 47 insertions(+), 21 deletions(-)

diff --git a/packages/backend/src/apps/twitter/client/endpoints/search-tweets.ts b/packages/backend/src/apps/twitter/client/endpoints/search-tweets.ts
index 634c66cf..bd138c26 100644
--- a/packages/backend/src/apps/twitter/client/endpoints/search-tweets.ts
+++ b/packages/backend/src/apps/twitter/client/endpoints/search-tweets.ts
@@ -19,7 +19,13 @@ export default class SearchTweets {
     };
 
     let response;
-    const tweets: IJSONObject[] = [];
+    const tweets: {
+      data: IJSONObject[];
+      error: IJSONObject | null;
+    } = {
+      data: [],
+      error: null,
+    };
 
     do {
       const params: IJSONObject = {
@@ -47,10 +53,15 @@ export default class SearchTweets {
         headers: { ...authHeader },
       });
 
+      if (response.automatischError) {
+        tweets.error = response.automatischError;
+        return tweets;
+      }
+
       if (response.data.meta.result_count > 0) {
         response.data.data.forEach((tweet: IJSONObject) => {
           if (!lastInternalId || Number(tweet.id) > Number(lastInternalId)) {
-            tweets.push(tweet);
+            tweets.data.push(tweet);
           } else {
             return;
           }
@@ -58,16 +69,6 @@ export default class SearchTweets {
       }
     } while (response.data.meta.next_token && lastInternalId);
 
-    if (response.data?.errors) {
-      const errorMessages = response.data.errors
-        .map((error: IJSONObject) => error.detail)
-        .join(' ');
-
-      throw new Error(
-        `Error occured while fetching user data: ${errorMessages}`
-      );
-    }
-
     return tweets;
   }
 }
diff --git a/packages/backend/src/helpers/http-client/index.ts b/packages/backend/src/helpers/http-client/index.ts
index 505ab46e..ab8e103b 100644
--- a/packages/backend/src/helpers/http-client/index.ts
+++ b/packages/backend/src/helpers/http-client/index.ts
@@ -11,7 +11,12 @@ export default class HttpClient {
   }
 
   async get(path: string, options?: IJSONObject) {
-    return await this.instance.get(path, options);
+    try {
+      return await this.instance.get(path, options);
+    } catch (error) {
+      error.response.automatischError = error.response.data;
+      return error.response;
+    }
   }
 
   async post(path: string, body: IJSONObject | string, options?: IJSONObject) {
diff --git a/packages/backend/src/services/processor.ts b/packages/backend/src/services/processor.ts
index da4ddbe2..b54ec6f7 100644
--- a/packages/backend/src/services/processor.ts
+++ b/packages/backend/src/services/processor.ts
@@ -33,9 +33,9 @@ class Processor {
 
     const triggerStep = steps.find((step) => step.type === 'trigger');
     // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-    let initialTriggerData = await this.getInitialTriggerData(triggerStep!);
+    const initialTriggerData = await this.getInitialTriggerData(triggerStep!);
 
-    if (initialTriggerData.length === 0) {
+    if (!initialTriggerData.error && initialTriggerData.data.length === 0) {
       const lastInternalId = await this.flow.lastInternalId();
 
       const executionData: Partial<Execution> = {
@@ -52,12 +52,12 @@ class Processor {
       return;
     }
 
-    if (this.testRun) {
-      initialTriggerData = [initialTriggerData[0]];
+    if (this.testRun && initialTriggerData.data.length > 0) {
+      initialTriggerData.data = [initialTriggerData.data[0]];
     }
 
-    if (initialTriggerData.length > 1) {
-      initialTriggerData = initialTriggerData.sort(
+    if (initialTriggerData.data.length > 1) {
+      initialTriggerData.data = initialTriggerData.data.sort(
         (item: IJSONObject, nextItem: IJSONObject) => {
           return (item.id as number) - (nextItem.id as number);
         }
@@ -66,7 +66,7 @@ class Processor {
 
     const executions: Execution[] = [];
 
-    for await (const data of initialTriggerData) {
+    for await (const data of initialTriggerData.data) {
       const execution = await Execution.query().insert({
         flowId: this.flow.id,
         testRun: this.testRun,
@@ -118,6 +118,22 @@ class Processor {
       }
     }
 
+    if (initialTriggerData.error) {
+      const executionWithError = await Execution.query().insert({
+        flowId: this.flow.id,
+        testRun: this.testRun,
+      });
+
+      executions.push(executionWithError);
+
+      await executionWithError.$relatedQuery('executionSteps').insertAndFetch({
+        stepId: triggerStep.id,
+        status: 'failure',
+        dataIn: triggerStep.parameters,
+        errorDetails: initialTriggerData.error,
+      });
+    }
+
     if (!this.testRun) return;
 
     const lastExecutionStepFromFirstExecution = await executions[0]
@@ -125,7 +141,11 @@ class Processor {
       .orderBy('created_at', 'desc')
       .first();
 
-    return lastExecutionStepFromFirstExecution?.dataOut;
+    if (lastExecutionStepFromFirstExecution.errorDetails) {
+      return lastExecutionStepFromFirstExecution.errorDetails;
+    } else {
+      return lastExecutionStepFromFirstExecution?.dataOut;
+    }
   }
 
   async getInitialTriggerData(step: Step) {