From 74b7dd8f3402c3a280bafb27cda91083e15e475a Mon Sep 17 00:00:00 2001 From: Faruk AYDIN Date: Tue, 26 Mar 2024 21:19:10 +0100 Subject: [PATCH] chore: Remove old app auth clients API endpoint --- .../app-auth-clients/get-app-auth-clients.js | 10 ----- .../get-app-auth-clients.test.js | 37 ------------------- .../src/routes/api/v1/app-auth-clients.js | 8 ---- 3 files changed, 55 deletions(-) delete mode 100644 packages/backend/src/controllers/api/v1/app-auth-clients/get-app-auth-clients.js delete mode 100644 packages/backend/src/controllers/api/v1/app-auth-clients/get-app-auth-clients.test.js diff --git a/packages/backend/src/controllers/api/v1/app-auth-clients/get-app-auth-clients.js b/packages/backend/src/controllers/api/v1/app-auth-clients/get-app-auth-clients.js deleted file mode 100644 index ff1b9af1..00000000 --- a/packages/backend/src/controllers/api/v1/app-auth-clients/get-app-auth-clients.js +++ /dev/null @@ -1,10 +0,0 @@ -import { renderObject } from '../../../../helpers/renderer.js'; -import AppAuthClient from '../../../../models/app-auth-client.js'; - -export default async (request, response) => { - const appAuthClients = await AppAuthClient.query() - .where({ active: true }) - .orderBy('created_at', 'desc'); - - renderObject(response, appAuthClients); -}; diff --git a/packages/backend/src/controllers/api/v1/app-auth-clients/get-app-auth-clients.test.js b/packages/backend/src/controllers/api/v1/app-auth-clients/get-app-auth-clients.test.js deleted file mode 100644 index 0c92fe02..00000000 --- a/packages/backend/src/controllers/api/v1/app-auth-clients/get-app-auth-clients.test.js +++ /dev/null @@ -1,37 +0,0 @@ -import { vi, describe, it, expect, beforeEach } from 'vitest'; -import request from 'supertest'; -import app from '../../../../app.js'; -import createAuthTokenByUserId from '../../../../helpers/create-auth-token-by-user-id.js'; -import { createUser } from '../../../../../test/factories/user.js'; -import getAppAuthClientsMock from '../../../../../test/mocks/rest/api/v1/app-auth-clients/get-app-auth-clients.js'; -import { createAppAuthClient } from '../../../../../test/factories/app-auth-client.js'; -import * as license from '../../../../helpers/license.ee.js'; - -describe('GET /api/v1/app-auth-clients', () => { - let currentUser, token; - - beforeEach(async () => { - vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true); - - currentUser = await createUser(); - - token = createAuthTokenByUserId(currentUser.id); - }); - - it('should return specified app auth client info', async () => { - const appAuthClientOne = await createAppAuthClient(); - const appAuthClientTwo = await createAppAuthClient(); - - const response = await request(app) - .get('/api/v1/app-auth-clients') - .set('Authorization', token) - .expect(200); - - const expectedPayload = getAppAuthClientsMock([ - appAuthClientTwo, - appAuthClientOne, - ]); - - expect(response.body).toEqual(expectedPayload); - }); -}); diff --git a/packages/backend/src/routes/api/v1/app-auth-clients.js b/packages/backend/src/routes/api/v1/app-auth-clients.js index efbcceb4..6a15826f 100644 --- a/packages/backend/src/routes/api/v1/app-auth-clients.js +++ b/packages/backend/src/routes/api/v1/app-auth-clients.js @@ -3,17 +3,9 @@ import asyncHandler from 'express-async-handler'; import { authenticateUser } from '../../../helpers/authentication.js'; import { checkIsEnterprise } from '../../../helpers/check-is-enterprise.js'; import getAppAuthClientAction from '../../../controllers/api/v1/app-auth-clients/get-app-auth-client.js'; -import getAppAuthClientsAction from '../../../controllers/api/v1/app-auth-clients/get-app-auth-clients.js'; const router = Router(); -router.get( - '/', - authenticateUser, - checkIsEnterprise, - asyncHandler(getAppAuthClientsAction) -); - router.get( '/:appAuthClientId', authenticateUser,