From 9558e66abf4424d7b26e1a2f288e6f97b999afe9 Mon Sep 17 00:00:00 2001 From: Faruk AYDIN Date: Wed, 11 Dec 2024 12:27:15 +0100 Subject: [PATCH 1/2] test: Fix tests for get apps connection --- .../src/controllers/api/v1/apps/get-connections.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/backend/src/controllers/api/v1/apps/get-connections.test.js b/packages/backend/src/controllers/api/v1/apps/get-connections.test.js index 8afb7eef..272f24cf 100644 --- a/packages/backend/src/controllers/api/v1/apps/get-connections.test.js +++ b/packages/backend/src/controllers/api/v1/apps/get-connections.test.js @@ -87,14 +87,14 @@ describe('GET /api/v1/apps/:appKey/connections', () => { it('should return not found response for invalid connection UUID', async () => { await createPermission({ - action: 'update', + action: 'read', subject: 'Connection', roleId: currentUserRole.id, conditions: ['isCreator'], }); await request(app) - .get('/api/v1/connections/invalid-connection-id/connections') + .get('/api/v1/apps/invalid-connection-id/connections') .set('Authorization', token) .expect(404); }); From 39cba6bc74728b4af9dda142f0b90ef57981bf9f Mon Sep 17 00:00:00 2001 From: Faruk AYDIN Date: Wed, 11 Dec 2024 12:32:19 +0100 Subject: [PATCH 2/2] test: Fix tests for create dynamic data and fields endpoints --- .../controllers/api/v1/steps/create-dynamic-data.test.js | 4 ++-- .../controllers/api/v1/steps/create-dynamic-fields.test.js | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/backend/src/controllers/api/v1/steps/create-dynamic-data.test.js b/packages/backend/src/controllers/api/v1/steps/create-dynamic-data.test.js index 64b1c254..af3f22e2 100644 --- a/packages/backend/src/controllers/api/v1/steps/create-dynamic-data.test.js +++ b/packages/backend/src/controllers/api/v1/steps/create-dynamic-data.test.js @@ -193,7 +193,7 @@ describe('POST /api/v1/steps/:stepId/dynamic-data', () => { const notExistingStepUUID = Crypto.randomUUID(); await request(app) - .get(`/api/v1/steps/${notExistingStepUUID}/dynamic-data`) + .post(`/api/v1/steps/${notExistingStepUUID}/dynamic-data`) .set('Authorization', token) .expect(404); }); @@ -216,7 +216,7 @@ describe('POST /api/v1/steps/:stepId/dynamic-data', () => { const step = await createStep({ appKey: null }); await request(app) - .get(`/api/v1/steps/${step.id}/dynamic-data`) + .post(`/api/v1/steps/${step.id}/dynamic-data`) .set('Authorization', token) .expect(404); }); diff --git a/packages/backend/src/controllers/api/v1/steps/create-dynamic-fields.test.js b/packages/backend/src/controllers/api/v1/steps/create-dynamic-fields.test.js index 3081351d..49d7f57f 100644 --- a/packages/backend/src/controllers/api/v1/steps/create-dynamic-fields.test.js +++ b/packages/backend/src/controllers/api/v1/steps/create-dynamic-fields.test.js @@ -118,7 +118,7 @@ describe('POST /api/v1/steps/:stepId/dynamic-fields', () => { const notExistingStepUUID = Crypto.randomUUID(); await request(app) - .get(`/api/v1/steps/${notExistingStepUUID}/dynamic-fields`) + .post(`/api/v1/steps/${notExistingStepUUID}/dynamic-fields`) .set('Authorization', token) .expect(404); }); @@ -138,10 +138,11 @@ describe('POST /api/v1/steps/:stepId/dynamic-fields', () => { conditions: [], }); - const step = await createStep({ appKey: null }); + const step = await createStep(); + await step.$query().patch({ appKey: null }); await request(app) - .get(`/api/v1/steps/${step.id}/dynamic-fields`) + .post(`/api/v1/steps/${step.id}/dynamic-fields`) .set('Authorization', token) .expect(404); });