groot/automatisch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2027 from automatisch/harden-webhook-tests

Browse Source 
test: harden webhook tests
This commit is contained in:
Ali BARIN
2024-08-22 16:19:51 +02:00
committed by GitHub
parent 53f63996bd e008087c4a
commit 66f5003d91
2 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/e2e-tests/fixtures/flow-editor-page.js
View File

@@ -11,7 +11,6 @@ export class FlowEditorPage extends AuthenticatedPage {
constructor(page) { constructor(page) {
super(page); super(page);
this.page = page;
this.appAutocomplete = this.page.getByTestId('choose-app-autocomplete'); this.appAutocomplete = this.page.getByTestId('choose-app-autocomplete');
this.eventAutocomplete = this.page.getByTestId('choose-event-autocomplete'); this.eventAutocomplete = this.page.getByTestId('choose-event-autocomplete');
this.continueButton = this.page.getByTestId('flow-substep-continue-button'); this.continueButton = this.page.getByTestId('flow-substep-continue-button');
@@ -77,7 +76,8 @@ export class FlowEditorPage extends AuthenticatedPage {
} }
async testAndContinue() { async testAndContinue() {
await this.continueButton.last().click(); await expect(this.continueButton).toHaveCount(1);
await this.continueButton.click();
await expect(this.testOutput).toBeVisible(); await expect(this.testOutput).toBeVisible();
await this.continueButton.click(); await this.continueButton.click();
} }

13
packages/e2e-tests/tests/app-integrations/webhook.spec.js
View File

@@ -20,14 +20,16 @@ test.describe('Webhook flow', () => {
await flowEditorPage.chooseAppAndEvent('Webhook', 'Respond with'); await flowEditorPage.chooseAppAndEvent('Webhook', 'Respond with');
await expect(flowEditorPage.continueButton.last()).not.toBeEnabled(); await expect(flowEditorPage.continueButton).toHaveCount(1);
await expect(flowEditorPage.continueButton).not.toBeEnabled();
await page await page
.getByTestId('parameters.statusCode-power-input') .getByTestId('parameters.statusCode-power-input')
.locator('[contenteditable]') .locator('[contenteditable]')
.fill('200'); .fill('200');
await flowEditorPage.clickAway(); await flowEditorPage.clickAway();
await expect(flowEditorPage.continueButton.last()).not.toBeEnabled(); await expect(flowEditorPage.continueButton).toHaveCount(1);
await expect(flowEditorPage.continueButton).not.toBeEnabled();
await page await page
.getByTestId('parameters.body-power-input') .getByTestId('parameters.body-power-input')
@@ -54,15 +56,16 @@ test.describe('Webhook flow', () => {
const asyncWebhookUrl = await flowEditorPage.createWebhookTrigger(false); const asyncWebhookUrl = await flowEditorPage.createWebhookTrigger(false);
await flowEditorPage.chooseAppAndEvent('Webhook', 'Respond with'); await flowEditorPage.chooseAppAndEvent('Webhook', 'Respond with');
await expect(flowEditorPage.continueButton).toHaveCount(1);
await expect(flowEditorPage.continueButton.last()).not.toBeEnabled(); await expect(flowEditorPage.continueButton).not.toBeEnabled();
await page await page
.getByTestId('parameters.statusCode-power-input') .getByTestId('parameters.statusCode-power-input')
.locator('[contenteditable]') .locator('[contenteditable]')
.fill('200'); .fill('200');
await flowEditorPage.clickAway(); await flowEditorPage.clickAway();
await expect(flowEditorPage.continueButton.last()).not.toBeEnabled(); await expect(flowEditorPage.continueButton).toHaveCount(1);
await expect(flowEditorPage.continueButton).not.toBeEnabled();
await page await page
.getByTestId('parameters.body-power-input') .getByTestId('parameters.body-power-input')