refactor(dynamicFields): use thrown error instead of returning it

packages/backend/src/apps/slack/dynamic-fields/send-as-bot/index.ts

@@ -1,22 +1,12 @@
-import { IGlobalVariable, IField, IJSONObject } from '@automatisch/types';
+import { IGlobalVariable } from '@automatisch/types';
 
 export default {
   name: 'List fields after send as bot',
   key: 'listFieldsAfterSendAsBot',
 
   async run($: IGlobalVariable) {
-    const sendAsBot = $.step.parameters.sendAsBot as boolean;
-
-    const remainingArguments: {
-      data: IJSONObject[];
-      error: IJSONObject | null;
-    } = {
-      data: [],
-      error: null,
-    };
-
-    if (sendAsBot) {
-      remainingArguments.data = [
+    if ($.step.parameters.sendAsBot) {
+      return [
         {
           label: 'Bot name',
           key: 'botName',
@@ -38,7 +28,5 @@ export default {
         },
       ];
     }
-
-    return remainingArguments;
   },
 };

packages/backend/src/graphql/queries/get-dynamic-fields.ts

@@ -40,13 +40,9 @@ const getDynamicFields = async (
     $.step.parameters[parameterKey] = parameterValue;
   }
 
-  const remainingArguments = await command.run($);
+  const additionalFields = await command.run($) || [];
 
-  if (remainingArguments.error) {
-    throw new Error(JSON.stringify(remainingArguments.error));
-  }
-
-  return remainingArguments.data;
+  return additionalFields;
 };
 
 export default getDynamicFields;