From c18ab67a25cec4f2677a6024f93bf5c4ecda2a25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C4=B1dvan=20Akca?= Date: Mon, 13 May 2024 15:02:10 +0200 Subject: [PATCH 1/2] feat: remove checkIsEnterprise middleware from admin users --- packages/backend/src/routes/api/v1/admin/users.ee.js | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/packages/backend/src/routes/api/v1/admin/users.ee.js b/packages/backend/src/routes/api/v1/admin/users.ee.js index f80999e3..9752c6a0 100644 --- a/packages/backend/src/routes/api/v1/admin/users.ee.js +++ b/packages/backend/src/routes/api/v1/admin/users.ee.js @@ -2,25 +2,17 @@ import { Router } from 'express'; import asyncHandler from 'express-async-handler'; import { authenticateUser } from '../../../../helpers/authentication.js'; import { authorizeAdmin } from '../../../../helpers/authorization.js'; -import { checkIsEnterprise } from '../../../../helpers/check-is-enterprise.js'; import getUsersAction from '../../../../controllers/api/v1/admin/users/get-users.ee.js'; import getUserAction from '../../../../controllers/api/v1/admin/users/get-user.ee.js'; const router = Router(); -router.get( - '/', - authenticateUser, - authorizeAdmin, - checkIsEnterprise, - asyncHandler(getUsersAction) -); +router.get('/', authenticateUser, authorizeAdmin, asyncHandler(getUsersAction)); router.get( '/:userId', authenticateUser, authorizeAdmin, - checkIsEnterprise, asyncHandler(getUserAction) ); From c6c900bc399fbadfa57c6500d96ef39dff435cec Mon Sep 17 00:00:00 2001 From: Ali BARIN Date: Mon, 13 May 2024 13:20:48 +0000 Subject: [PATCH 2/2] test(get-users.ee): remove license mock --- .../src/controllers/api/v1/admin/users/get-users.ee.test.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/backend/src/controllers/api/v1/admin/users/get-users.ee.test.js b/packages/backend/src/controllers/api/v1/admin/users/get-users.ee.test.js index 25f5ee82..a7528de0 100644 --- a/packages/backend/src/controllers/api/v1/admin/users/get-users.ee.test.js +++ b/packages/backend/src/controllers/api/v1/admin/users/get-users.ee.test.js @@ -1,11 +1,10 @@ -import { vi, describe, it, expect, beforeEach } from 'vitest'; +import { describe, it, expect, beforeEach } from 'vitest'; import request from 'supertest'; import app from '../../../../../app'; import createAuthTokenByUserId from '../../../../../helpers/create-auth-token-by-user-id'; import { createRole } from '../../../../../../test/factories/role'; import { createUser } from '../../../../../../test/factories/user'; import getUsersMock from '../../../../../../test/mocks/rest/api/v1/admin/users/get-users.js'; -import * as license from '../../../../../helpers/license.ee.js'; describe('GET /api/v1/admin/users', () => { let currentUser, currentUserRole, anotherUser, anotherUserRole, token; @@ -32,8 +31,6 @@ describe('GET /api/v1/admin/users', () => { }); it('should return users data', async () => { - vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true); - const response = await request(app) .get('/api/v1/admin/users') .set('Authorization', token)