groot/automatisch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: Remove authentication cases from individual tests

Browse Source
This commit is contained in:
Faruk AYDIN
2024-01-15 15:27:30 +01:00
parent 782fa67320
commit 55c391afc8
8 changed files with 841 additions and 1004 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
packages/backend/src/graphql/queries/get-current-user.test.js
View File

@@ -6,31 +6,6 @@ import { createRole } from '../../../test/factories/role';
import { createUser } from '../../../test/factories/user'; import { createUser } from '../../../test/factories/user';
describe('graphQL getCurrentUser query', () => { describe('graphQL getCurrentUser query', () => {
describe('with unauthenticated user', () => {
it('should throw not authorized error', async () => {
const invalidUserToken = 'invalid-token';
const query = `
query {
getCurrentUser {
id
email
}
}
`;
const response = await request(app)
.post('/graphql')
.set('Authorization', invalidUserToken)
.send({ query })
.expect(200);
expect(response.body.errors).toBeDefined();
expect(response.body.errors[0].message).toEqual('Not Authorised!');
});
});
describe('with authenticated user', () => {
let role, currentUser, token, requestObject; let role, currentUser, token, requestObject;
beforeEach(async () => { beforeEach(async () => {
@@ -102,4 +77,3 @@ describe('graphQL getCurrentUser query', () => {
); );
}); });
}); });
});

19
packages/backend/src/graphql/queries/get-executions.test.js
View File

@@ -40,23 +40,7 @@ describe('graphQL getExecutions query', () => {
} }
`; `;
const invalidToken = 'invalid-token'; describe('and without correct permissions', () => {
describe('with unauthenticated user', () => {
it('should throw not authorized error', async () => {
const response = await request(app)
.post('/graphql')
.set('Authorization', invalidToken)
.send({ query })
.expect(200);
expect(response.body.errors).toBeDefined();
expect(response.body.errors[0].message).toEqual('Not Authorised!');
});
});
describe('with authenticated user', () => {
describe('and without permissions', () => {
it('should throw not authorized error', async () => { it('should throw not authorized error', async () => {
const userWithoutPermissions = await createUser(); const userWithoutPermissions = await createUser();
const token = createAuthTokenByUserId(userWithoutPermissions.id); const token = createAuthTokenByUserId(userWithoutPermissions.id);
@@ -486,4 +470,3 @@ describe('graphQL getExecutions query', () => {
}); });
}); });
}); });
});

26
packages/backend/src/graphql/queries/get-flow.test.js
View File

@@ -40,23 +40,6 @@ describe('graphQL getFlow query', () => {
`; `;
}; };
describe('with unauthenticated user', () => {
it('should throw not authorized error', async () => {
const invalidToken = 'invalid-token';
const flow = await createFlow();
const response = await request(app)
.post('/graphql')
.set('Authorization', invalidToken)
.send({ query: query(flow.id) })
.expect(200);
expect(response.body.errors).toBeDefined();
expect(response.body.errors[0].message).toEqual('Not Authorised!');
});
});
describe('with authenticated user', () => {
describe('and without permissions', () => { describe('and without permissions', () => {
it('should throw not authorized error', async () => { it('should throw not authorized error', async () => {
const userWithoutPermissions = await createUser(); const userWithoutPermissions = await createUser();
@@ -145,9 +128,7 @@ describe('graphQL getFlow query', () => {
{ {
appKey: actionStep.appKey, appKey: actionStep.appKey,
connection: { connection: {
createdAt: actionConnection.createdAt createdAt: actionConnection.createdAt.getTime().toString(),
.getTime()
.toString(),
id: actionConnection.id, id: actionConnection.id,
verified: actionConnection.verified, verified: actionConnection.verified,
}, },
@@ -234,9 +215,7 @@ describe('graphQL getFlow query', () => {
{ {
appKey: actionStep.appKey, appKey: actionStep.appKey,
connection: { connection: {
createdAt: actionConnection.createdAt createdAt: actionConnection.createdAt.getTime().toString(),
.getTime()
.toString(),
id: actionConnection.id, id: actionConnection.id,
verified: actionConnection.verified, verified: actionConnection.verified,
}, },
@@ -259,4 +238,3 @@ describe('graphQL getFlow query', () => {
}); });
}); });
}); });
});

18
packages/backend/src/graphql/queries/get-role.ee.test.js
View File

@@ -17,7 +17,6 @@ describe('graphQL getRole query', () => {
userWithoutPermissions, userWithoutPermissions,
tokenWithPermissions, tokenWithPermissions,
tokenWithoutPermissions, tokenWithoutPermissions,
invalidToken,
permissionOne, permissionOne,
permissionTwo; permissionTwo;
@@ -74,24 +73,8 @@ describe('graphQL getRole query', () => {
tokenWithoutPermissions = createAuthTokenByUserId( tokenWithoutPermissions = createAuthTokenByUserId(
userWithoutPermissions.id userWithoutPermissions.id
); );
invalidToken = 'invalid-token';
}); });
describe('with unauthenticated user', () => {
it('should throw not authorized error', async () => {
const response = await request(app)
.post('/graphql')
.set('Authorization', invalidToken)
.send({ query: queryWithValidRole })
.expect(200);
expect(response.body.errors).toBeDefined();
expect(response.body.errors[0].message).toEqual('Not Authorised!');
});
});
describe('with authenticated user', () => {
describe('and with valid license', () => { describe('and with valid license', () => {
beforeEach(async () => { beforeEach(async () => {
vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true); vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true);
@@ -179,4 +162,3 @@ describe('graphQL getRole query', () => {
}); });
}); });
}); });
});

20
packages/backend/src/graphql/queries/get-roles.ee.test.js
View File

@@ -15,8 +15,7 @@ describe('graphQL getRoles query', () => {
userWithPermissions, userWithPermissions,
userWithoutPermissions, userWithoutPermissions,
tokenWithPermissions, tokenWithPermissions,
tokenWithoutPermissions, tokenWithoutPermissions;
invalidToken;
beforeEach(async () => { beforeEach(async () => {
currentUserRole = await createRole({ name: 'Current user role' }); currentUserRole = await createRole({ name: 'Current user role' });
@@ -53,24 +52,8 @@ describe('graphQL getRoles query', () => {
tokenWithoutPermissions = createAuthTokenByUserId( tokenWithoutPermissions = createAuthTokenByUserId(
userWithoutPermissions.id userWithoutPermissions.id
); );
invalidToken = 'invalid-token';
}); });
describe('with unauthenticated user', () => {
it('should throw not authorized error', async () => {
const response = await request(app)
.post('/graphql')
.set('Authorization', invalidToken)
.send({ query })
.expect(200);
expect(response.body.errors).toBeDefined();
expect(response.body.errors[0].message).toEqual('Not Authorised!');
});
});
describe('with authenticated user', () => {
describe('and with valid license', () => { describe('and with valid license', () => {
beforeEach(async () => { beforeEach(async () => {
vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true); vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true);
@@ -149,4 +132,3 @@ describe('graphQL getRoles query', () => {
}); });
}); });
}); });
});

17
packages/backend/src/graphql/queries/get-trial-status.ee.test.js
View File

@@ -16,22 +16,6 @@ describe('graphQL getTrialStatus query', () => {
} }
`; `;
const invalidToken = 'invalid-token';
describe('with unauthenticated user', () => {
it('should throw not authorized error', async () => {
const response = await request(app)
.post('/graphql')
.set('Authorization', invalidToken)
.send({ query })
.expect(200);
expect(response.body.errors).toBeDefined();
expect(response.body.errors[0].message).toEqual('Not Authorised!');
});
});
describe('with authenticated user', () => {
let user, userToken; let user, userToken;
beforeEach(async () => { beforeEach(async () => {
@@ -114,4 +98,3 @@ describe('graphQL getTrialStatus query', () => {
}); });
}); });
}); });
});

30
packages/backend/src/graphql/queries/get-user.test.js
View File

@@ -8,31 +8,6 @@ import { createPermission } from '../../../test/factories/permission';
import { createUser } from '../../../test/factories/user'; import { createUser } from '../../../test/factories/user';
describe('graphQL getUser query', () => { describe('graphQL getUser query', () => {
describe('with unauthenticated user', () => {
it('should throw not authorized error', async () => {
const invalidUserId = '123123123';
const query = `
query {
getUser(id: "${invalidUserId}") {
id
email
}
}
`;
const response = await request(app)
.post('/graphql')
.set('Authorization', 'invalid-token')
.send({ query })
.expect(200);
expect(response.body.errors).toBeDefined();
expect(response.body.errors[0].message).toEqual('Not Authorised!');
});
});
describe('with authenticated user', () => {
describe('and without permissions', () => { describe('and without permissions', () => {
it('should throw not authorized error', async () => { it('should throw not authorized error', async () => {
const userWithoutPermissions = await createUser(); const userWithoutPermissions = await createUser();
@@ -84,9 +59,7 @@ describe('graphQL getUser query', () => {
}); });
token = createAuthTokenByUserId(currentUser.id); token = createAuthTokenByUserId(currentUser.id);
requestObject = request(app) requestObject = request(app).post('/graphql').set('Authorization', token);
.post('/graphql')
.set('Authorization', token);
}); });
it('should return user data for a valid user id', async () => { it('should return user data for a valid user id', async () => {
@@ -171,4 +144,3 @@ describe('graphQL getUser query', () => {
}); });
}); });
}); });
});

19
packages/backend/src/graphql/queries/get-users.test.js
View File

@@ -30,20 +30,6 @@ describe('graphQL getUsers query', () => {
} }
`; `;
describe('with unauthenticated user', () => {
it('should throw not authorized error', async () => {
const response = await request(app)
.post('/graphql')
.set('Authorization', 'invalid-token')
.send({ query })
.expect(200);
expect(response.body.errors).toBeDefined();
expect(response.body.errors[0].message).toEqual('Not Authorised!');
});
});
describe('with authenticated user', () => {
describe('and without permissions', () => { describe('and without permissions', () => {
it('should throw not authorized error', async () => { it('should throw not authorized error', async () => {
const userWithoutPermissions = await createUser(); const userWithoutPermissions = await createUser();
@@ -86,9 +72,7 @@ describe('graphQL getUsers query', () => {
}); });
token = createAuthTokenByUserId(currentUser.id); token = createAuthTokenByUserId(currentUser.id);
requestObject = request(app) requestObject = request(app).post('/graphql').set('Authorization', token);
.post('/graphql')
.set('Authorization', token);
}); });
it('should return users data', async () => { it('should return users data', async () => {
@@ -162,4 +146,3 @@ describe('graphQL getUsers query', () => {
}); });
}); });
}); });
});