test: use new alert in create role and create user tests

This commit is contained in:
Jakub P.
2024-12-10 00:32:51 +01:00
committed by kasia.oczkowska
parent 7a8dc68592
commit 53d95366e9
5 changed files with 430 additions and 524 deletions

View File

@@ -1,3 +1,5 @@
const { expect } = require('@playwright/test');
const { faker } = require('@faker-js/faker'); const { faker } = require('@faker-js/faker');
const { AuthenticatedPage } = require('../authenticated-page'); const { AuthenticatedPage } = require('../authenticated-page');
@@ -11,11 +13,17 @@ export class AdminCreateUserPage extends AuthenticatedPage {
super(page); super(page);
this.fullNameInput = page.getByTestId('full-name-input'); this.fullNameInput = page.getByTestId('full-name-input');
this.emailInput = page.getByTestId('email-input'); this.emailInput = page.getByTestId('email-input');
this.roleInput = page.getByTestId('role.id-autocomplete'); this.roleInput = page.getByTestId('roleId-autocomplete');
this.createButton = page.getByTestId('create-button'); this.createButton = page.getByTestId('create-button');
this.pageTitle = page.getByTestId('create-user-title'); this.pageTitle = page.getByTestId('create-user-title');
this.invitationEmailInfoAlert = page.getByTestId('invitation-email-info-alert'); this.invitationEmailInfoAlert = page.getByTestId(
this.acceptInvitationLink = page.getByTestId('invitation-email-info-alert').getByRole('link'); 'invitation-email-info-alert'
);
this.acceptInvitationLink = page
.getByTestId('invitation-email-info-alert')
.getByRole('link');
this.createUserSuccessAlert = page.getByTestId('create-user-success-alert');
this.fieldError = page.locator('p[id$="-helper-text"]');
} }
seed(seed) { seed(seed) {
@@ -28,4 +36,8 @@ export class AdminCreateUserPage extends AuthenticatedPage {
email: faker.internet.email().toLowerCase(), email: faker.internet.email().toLowerCase(),
}; };
} }
async expectCreateUserSuccessAlertToBeVisible() {
await expect(this.createUserSuccessAlert).toBeVisible();
}
} }

View File

@@ -35,9 +35,8 @@ test.describe('Role management page', () => {
await adminCreateRolePage.closeSnackbar(); await adminCreateRolePage.closeSnackbar();
}); });
let roleRow = await test.step( let roleRow =
'Make sure role data is correct', await test.step('Make sure role data is correct', async () => {
async () => {
const roleRow = await adminRolesPage.getRoleRowByName( const roleRow = await adminRolesPage.getRoleRowByName(
'Create Edit Test' 'Create Edit Test'
); );
@@ -48,8 +47,7 @@ test.describe('Role management page', () => {
await expect(roleData.canEdit).toBe(true); await expect(roleData.canEdit).toBe(true);
await expect(roleData.canDelete).toBe(true); await expect(roleData.canDelete).toBe(true);
return roleRow; return roleRow;
} });
);
await test.step('Edit the role', async () => { await test.step('Edit the role', async () => {
await adminRolesPage.clickEditRole(roleRow); await adminRolesPage.clickEditRole(roleRow);
@@ -67,9 +65,8 @@ test.describe('Role management page', () => {
await adminEditRolePage.closeSnackbar(); await adminEditRolePage.closeSnackbar();
}); });
roleRow = await test.step( roleRow =
'Make sure changes reflected on roles page', await test.step('Make sure changes reflected on roles page', async () => {
async () => {
await adminRolesPage.isMounted(); await adminRolesPage.isMounted();
const roleRow = await adminRolesPage.getRoleRowByName( const roleRow = await adminRolesPage.getRoleRowByName(
'Create Update Test' 'Create Update Test'
@@ -81,8 +78,7 @@ test.describe('Role management page', () => {
await expect(roleData.canEdit).toBe(true); await expect(roleData.canEdit).toBe(true);
await expect(roleData.canDelete).toBe(true); await expect(roleData.canDelete).toBe(true);
return roleRow; return roleRow;
} });
);
await test.step('Delete the role', async () => { await test.step('Delete the role', async () => {
await adminRolesPage.clickDeleteRole(roleRow); await adminRolesPage.clickDeleteRole(roleRow);
@@ -184,49 +180,39 @@ test.describe('Role management page', () => {
await expect(snackbar.variant).toBe('success'); await expect(snackbar.variant).toBe('success');
await adminCreateRolePage.closeSnackbar(); await adminCreateRolePage.closeSnackbar();
}); });
await test.step( await test.step('Create a new user with the "Delete Role" role', async () => {
'Create a new user with the "Delete Role" role', await adminUsersPage.navigateTo();
async () => { await adminUsersPage.createUserButton.click();
await adminUsersPage.navigateTo(); await adminCreateUserPage.fullNameInput.fill('User Role Test');
await adminUsersPage.createUserButton.click(); await adminCreateUserPage.emailInput.fill(
await adminCreateUserPage.fullNameInput.fill('User Role Test'); 'user-role-test@automatisch.io'
await adminCreateUserPage.emailInput.fill( );
'user-role-test@automatisch.io' await adminCreateUserPage.roleInput.click();
); await adminCreateUserPage.page
await adminCreateUserPage.roleInput.click(); .getByRole('option', { name: 'Delete Role', exact: true })
await adminCreateUserPage.page .click();
.getByRole('option', { name: 'Delete Role', exact: true }) await adminCreateUserPage.createButton.click();
.click(); await adminCreateUserPage.invitationEmailInfoAlert.waitFor({
await adminCreateUserPage.createButton.click(); state: 'attached',
await adminCreateUserPage.snackbar.waitFor({ });
state: 'attached', await adminCreateUserPage.expectCreateUserSuccessAlertToBeVisible();
}); });
await adminCreateUserPage.invitationEmailInfoAlert.waitFor({
state: 'attached', await test.step('Try to delete "Delete Role" role when new user has it', async () => {
}); await adminRolesPage.navigateTo();
const snackbar = await adminUsersPage.getSnackbarData( const row = await adminRolesPage.getRoleRowByName('Delete Role');
'snackbar-create-user-success' const modal = await adminRolesPage.clickDeleteRole(row);
); await modal.deleteButton.click();
await expect(snackbar.variant).toBe('success'); await adminRolesPage.snackbar.waitFor({
await adminUsersPage.closeSnackbar(); state: 'attached',
} });
); const snackbar = await adminRolesPage.getSnackbarData(
await test.step( 'snackbar-delete-role-error'
'Try to delete "Delete Role" role when new user has it', );
async () => { await expect(snackbar.variant).toBe('error');
await adminRolesPage.navigateTo(); await adminRolesPage.closeSnackbar();
const row = await adminRolesPage.getRoleRowByName('Delete Role'); await modal.close();
const modal = await adminRolesPage.clickDeleteRole(row); });
await modal.deleteButton.click();
await adminRolesPage.snackbar.waitFor({
state: 'attached',
});
const snackbar = await adminRolesPage.getSnackbarData('snackbar-delete-role-error');
await expect(snackbar.variant).toBe('error');
await adminRolesPage.closeSnackbar();
await modal.close();
}
);
await test.step('Change the role the user has', async () => { await test.step('Change the role the user has', async () => {
await adminUsersPage.navigateTo(); await adminUsersPage.navigateTo();
await adminUsersPage.usersLoader.waitFor({ await adminUsersPage.usersLoader.waitFor({
@@ -301,24 +287,16 @@ test.describe('Role management page', () => {
.getByRole('option', { name: 'Cannot Delete Role' }) .getByRole('option', { name: 'Cannot Delete Role' })
.click(); .click();
await adminCreateUserPage.createButton.click(); await adminCreateUserPage.createButton.click();
await adminCreateUserPage.snackbar.waitFor({
state: 'attached',
});
await adminCreateUserPage.invitationEmailInfoAlert.waitFor({ await adminCreateUserPage.invitationEmailInfoAlert.waitFor({
state: 'attached', state: 'attached',
}); });
const snackbar = await adminCreateUserPage.getSnackbarData( await adminCreateUserPage.expectCreateUserSuccessAlertToBeVisible();
'snackbar-create-user-success'
);
await expect(snackbar.variant).toBe('success');
await adminCreateUserPage.closeSnackbar();
}); });
await test.step('Delete this user', async () => { await test.step('Delete this user', async () => {
await adminUsersPage.navigateTo(); await adminUsersPage.navigateTo();
const row = await adminUsersPage.findUserPageWithEmail( const row = await adminUsersPage.findUserPageWithEmail(
'user-delete-role-test@automatisch.io' 'user-delete-role-test@automatisch.io'
); );
// await test.waitForTimeout(10000);
const modal = await adminUsersPage.clickDeleteUser(row); const modal = await adminUsersPage.clickDeleteUser(row);
await modal.deleteButton.click(); await modal.deleteButton.click();
await adminUsersPage.snackbar.waitFor({ await adminUsersPage.snackbar.waitFor({
@@ -385,17 +363,10 @@ test('Accessibility of role management page', async ({
.getByRole('option', { name: 'Basic Test' }) .getByRole('option', { name: 'Basic Test' })
.click(); .click();
await adminCreateUserPage.createButton.click(); await adminCreateUserPage.createButton.click();
await adminCreateUserPage.snackbar.waitFor({
state: 'attached',
});
await adminCreateUserPage.invitationEmailInfoAlert.waitFor({ await adminCreateUserPage.invitationEmailInfoAlert.waitFor({
state: 'attached', state: 'attached',
}); });
const snackbar = await adminCreateUserPage.getSnackbarData( await adminCreateUserPage.expectCreateUserSuccessAlertToBeVisible();
'snackbar-create-user-success'
);
await expect(snackbar.variant).toBe('success');
await adminCreateUserPage.closeSnackbar();
}); });
await test.step('Logout and login to the basic role user', async () => { await test.step('Logout and login to the basic role user', async () => {
@@ -409,42 +380,35 @@ test('Accessibility of role management page', async ({
await page.getByTestId('logout-item').click(); await page.getByTestId('logout-item').click();
const acceptInvitationPage = new AcceptInvitation(page); const acceptInvitationPage = new AcceptInvitation(page);
await acceptInvitationPage.open(acceptInvitatonToken); await acceptInvitationPage.open(acceptInvitatonToken);
await acceptInvitationPage.acceptInvitation('sample'); await acceptInvitationPage.acceptInvitation('sample');
const loginPage = new LoginPage(page); const loginPage = new LoginPage(page);
// await loginPage.isMounted();
await loginPage.login('basic-role-test@automatisch.io', 'sample'); await loginPage.login('basic-role-test@automatisch.io', 'sample');
await expect(loginPage.loginButton).not.toBeVisible(); await expect(loginPage.loginButton).not.toBeVisible();
await expect(page).toHaveURL('/flows'); await expect(page).toHaveURL('/flows');
}); });
await test.step( await test.step('Navigate to the admin settings page and make sure it is blank', async () => {
'Navigate to the admin settings page and make sure it is blank', const pageUrl = new URL(page.url());
async () => { const url = `${pageUrl.origin}/admin-settings/users`;
const pageUrl = new URL(page.url()); await page.goto(url);
const url = `${pageUrl.origin}/admin-settings/users`; await page.waitForTimeout(750);
await page.goto(url); const isUnmounted = await page.evaluate(() => {
await page.waitForTimeout(750); // eslint-disable-next-line no-undef
const isUnmounted = await page.evaluate(() => { const root = document.querySelector('#root');
// eslint-disable-next-line no-undef
const root = document.querySelector('#root');
if (root) { if (root) {
// We have react query devtools only in dev env. // We have react query devtools only in dev env.
// In production, there is nothing in root. // In production, there is nothing in root.
// That's why `<= 1`. // That's why `<= 1`.
return root.children.length <= 1; return root.children.length <= 1;
} }
return false; return false;
}); });
await expect(isUnmounted).toBe(true); await expect(isUnmounted).toBe(true);
} });
);
await test.step('Log back into the admin account', async () => { await test.step('Log back into the admin account', async () => {
await page.goto('/'); await page.goto('/');

View File

@@ -5,281 +5,221 @@ const { test, expect } = require('../../fixtures/index');
* otherwise tests will fail since users are only *soft*-deleted * otherwise tests will fail since users are only *soft*-deleted
*/ */
test.describe('User management page', () => { test.describe('User management page', () => {
test.beforeEach(async ({ adminUsersPage }) => { test.beforeEach(async ({ adminUsersPage }) => {
await adminUsersPage.navigateTo(); await adminUsersPage.navigateTo();
await adminUsersPage.closeSnackbar(); await adminUsersPage.closeSnackbar();
}); });
test( test('User creation and deletion process', async ({
'User creation and deletion process', adminCreateUserPage,
async ({ adminCreateUserPage, adminEditUserPage, adminUsersPage }) => { adminEditUserPage,
adminCreateUserPage.seed(9000); adminUsersPage,
const user = adminCreateUserPage.generateUser(); }) => {
await adminUsersPage.usersLoader.waitFor({ adminCreateUserPage.seed(9000);
state: 'detached' /* Note: state: 'visible' introduces flakiness const user = adminCreateUserPage.generateUser();
await adminUsersPage.usersLoader.waitFor({
state: 'detached' /* Note: state: 'visible' introduces flakiness
because visibility: hidden is used as part of the state transition in because visibility: hidden is used as part of the state transition in
notistack, see notistack, see
https://github.com/iamhosseindhv/notistack/blob/122f47057eb7ce5a1abfe923316cf8475303e99a/src/transitions/Collapse/Collapse.tsx#L110 https://github.com/iamhosseindhv/notistack/blob/122f47057eb7ce5a1abfe923316cf8475303e99a/src/transitions/Collapse/Collapse.tsx#L110
*/ */,
});
await test.step('Create a user', async () => {
await adminUsersPage.createUserButton.click();
await adminCreateUserPage.fullNameInput.fill(user.fullName);
await adminCreateUserPage.emailInput.fill(user.email);
await adminCreateUserPage.roleInput.click();
await adminCreateUserPage.page
.getByRole('option', { name: 'Admin' })
.click();
await adminCreateUserPage.createButton.click();
await adminCreateUserPage.invitationEmailInfoAlert.waitFor({
state: 'attached',
}); });
await test.step(
'Create a user',
async () => {
await adminUsersPage.createUserButton.click();
await adminCreateUserPage.fullNameInput.fill(user.fullName);
await adminCreateUserPage.emailInput.fill(user.email);
await adminCreateUserPage.roleInput.click();
await adminCreateUserPage.page.getByRole(
'option', { name: 'Admin' }
).click();
await adminCreateUserPage.createButton.click();
await adminCreateUserPage.invitationEmailInfoAlert.waitFor({
state: 'attached'
});
const snackbar = await adminUsersPage.getSnackbarData( await adminCreateUserPage.expectCreateUserSuccessAlertToBeVisible();
'snackbar-create-user-success' await adminUsersPage.navigateTo();
); });
await expect(snackbar.variant).toBe('success'); await test.step('Check the user exists with the expected properties', async () => {
await adminUsersPage.navigateTo(); await adminUsersPage.findUserPageWithEmail(user.email);
await adminUsersPage.closeSnackbar(); const userRow = await adminUsersPage.getUserRowByEmail(user.email);
} const data = await adminUsersPage.getRowData(userRow);
await expect(data.email).toBe(user.email);
await expect(data.fullName).toBe(user.fullName);
await expect(data.role).toBe('Admin');
});
await test.step('Edit user info and make sure the edit works correctly', async () => {
await adminUsersPage.findUserPageWithEmail(user.email);
let userRow = await adminUsersPage.getUserRowByEmail(user.email);
await adminUsersPage.clickEditUser(userRow);
await adminEditUserPage.waitForLoad(user.fullName);
const newUserInfo = adminEditUserPage.generateUser();
await adminEditUserPage.fullNameInput.fill(newUserInfo.fullName);
await adminEditUserPage.updateButton.click();
const snackbar = await adminUsersPage.getSnackbarData(
'snackbar-edit-user-success'
); );
await test.step( await expect(snackbar.variant).toBe('success');
'Check the user exists with the expected properties', await adminUsersPage.closeSnackbar();
async () => {
await adminUsersPage.findUserPageWithEmail(user.email); await adminUsersPage.findUserPageWithEmail(user.email);
const userRow = await adminUsersPage.getUserRowByEmail(user.email); userRow = await adminUsersPage.getUserRowByEmail(user.email);
const data = await adminUsersPage.getRowData(userRow); const rowData = await adminUsersPage.getRowData(userRow);
await expect(data.email).toBe(user.email); await expect(rowData.fullName).toBe(newUserInfo.fullName);
await expect(data.fullName).toBe(user.fullName); });
await expect(data.role).toBe('Admin'); await test.step('Delete user and check the page confirms this deletion', async () => {
} await adminUsersPage.findUserPageWithEmail(user.email);
const userRow = await adminUsersPage.getUserRowByEmail(user.email);
await adminUsersPage.clickDeleteUser(userRow);
const modal = adminUsersPage.deleteUserModal;
await modal.deleteButton.click();
const snackbar = await adminUsersPage.getSnackbarData(
'snackbar-delete-user-success'
); );
await test.step( await expect(snackbar.variant).toBe('success');
'Edit user info and make sure the edit works correctly', await adminUsersPage.closeSnackbar();
async () => { await expect(userRow).not.toBeVisible(false);
await adminUsersPage.findUserPageWithEmail(user.email); });
});
let userRow = await adminUsersPage.getUserRowByEmail(user.email); test('Creating a user which has been deleted', async ({
await adminUsersPage.clickEditUser(userRow); adminCreateUserPage,
await adminEditUserPage.waitForLoad(user.fullName); adminUsersPage,
const newUserInfo = adminEditUserPage.generateUser(); }) => {
await adminEditUserPage.fullNameInput.fill(newUserInfo.fullName); adminCreateUserPage.seed(9100);
await adminEditUserPage.updateButton.click(); const testUser = adminCreateUserPage.generateUser();
const snackbar = await adminUsersPage.getSnackbarData( await test.step('Create the test user', async () => {
'snackbar-edit-user-success' await adminUsersPage.navigateTo();
); await adminUsersPage.createUserButton.click();
await expect(snackbar.variant).toBe('success'); await adminCreateUserPage.fullNameInput.fill(testUser.fullName);
await adminUsersPage.closeSnackbar(); await adminCreateUserPage.emailInput.fill(testUser.email);
await adminCreateUserPage.roleInput.click();
await adminUsersPage.findUserPageWithEmail(user.email); await adminCreateUserPage.page
userRow = await adminUsersPage.getUserRowByEmail(user.email); .getByRole('option', { name: 'Admin' })
const rowData = await adminUsersPage.getRowData(userRow); .click();
await expect(rowData.fullName).toBe(newUserInfo.fullName); await adminCreateUserPage.createButton.click();
} await adminCreateUserPage.expectCreateUserSuccessAlertToBeVisible();
);
await test.step(
'Delete user and check the page confirms this deletion',
async () => {
await adminUsersPage.findUserPageWithEmail(user.email);
const userRow = await adminUsersPage.getUserRowByEmail(user.email);
await adminUsersPage.clickDeleteUser(userRow);
const modal = adminUsersPage.deleteUserModal;
await modal.deleteButton.click();
const snackbar = await adminUsersPage.getSnackbarData(
'snackbar-delete-user-success'
);
await expect(snackbar.variant).toBe('success');
await adminUsersPage.closeSnackbar();
await expect(userRow).not.toBeVisible(false);
}
);
}); });
test( await test.step('Delete the created user', async () => {
'Creating a user which has been deleted', await adminUsersPage.navigateTo();
async ({ adminCreateUserPage, adminUsersPage }) => { await adminUsersPage.findUserPageWithEmail(testUser.email);
adminCreateUserPage.seed(9100); const userRow = await adminUsersPage.getUserRowByEmail(testUser.email);
const testUser = adminCreateUserPage.generateUser(); await adminUsersPage.clickDeleteUser(userRow);
const modal = adminUsersPage.deleteUserModal;
await test.step( await modal.deleteButton.click();
'Create the test user', const snackbar = await adminUsersPage.getSnackbarData(
async () => { 'snackbar-delete-user-success'
await adminUsersPage.navigateTo();
await adminUsersPage.createUserButton.click();
await adminCreateUserPage.fullNameInput.fill(testUser.fullName);
await adminCreateUserPage.emailInput.fill(testUser.email);
await adminCreateUserPage.roleInput.click();
await adminCreateUserPage.page.getByRole(
'option', { name: 'Admin' }
).click();
await adminCreateUserPage.createButton.click();
const snackbar = await adminUsersPage.getSnackbarData(
'snackbar-create-user-success'
);
await expect(snackbar.variant).toBe('success');
await adminUsersPage.closeSnackbar();
}
); );
await expect(snackbar).not.toBeNull();
await expect(snackbar.variant).toBe('success');
await adminUsersPage.closeSnackbar();
await expect(userRow).not.toBeVisible(false);
});
await test.step( await test.step('Create the user again', async () => {
'Delete the created user', await adminUsersPage.createUserButton.click();
async () => { await adminCreateUserPage.fullNameInput.fill(testUser.fullName);
await adminUsersPage.navigateTo(); await adminCreateUserPage.emailInput.fill(testUser.email);
await adminUsersPage.findUserPageWithEmail(testUser.email); await adminCreateUserPage.roleInput.click();
const userRow = await adminUsersPage.getUserRowByEmail(testUser.email); await adminCreateUserPage.page
await adminUsersPage.clickDeleteUser(userRow); .getByRole('option', { name: 'Admin' })
const modal = adminUsersPage.deleteUserModal; .click();
await modal.deleteButton.click(); await adminCreateUserPage.createButton.click();
const snackbar = await adminUsersPage.getSnackbarData( await expect(adminCreateUserPage.fieldError).toHaveCount(1);
'snackbar-delete-user-success' });
); });
await expect(snackbar).not.toBeNull();
await expect(snackbar.variant).toBe('success');
await adminUsersPage.closeSnackbar();
await expect(userRow).not.toBeVisible(false);
}
);
await test.step( test('Creating a user which already exists', async ({
'Create the user again', adminCreateUserPage,
async () => { adminUsersPage,
await adminUsersPage.createUserButton.click(); page,
await adminCreateUserPage.fullNameInput.fill(testUser.fullName); }) => {
await adminCreateUserPage.emailInput.fill(testUser.email); adminCreateUserPage.seed(9200);
await adminCreateUserPage.roleInput.click(); const testUser = adminCreateUserPage.generateUser();
await adminCreateUserPage.page.getByRole(
'option', { name: 'Admin' }
).click();
await adminCreateUserPage.createButton.click();
const snackbar = await adminUsersPage.getSnackbarData('snackbar-error');
await expect(snackbar.variant).toBe('error');
await adminUsersPage.closeSnackbar();
}
);
}
);
test( await test.step('Create the test user', async () => {
'Creating a user which already exists', await adminUsersPage.createUserButton.click();
async ({ adminCreateUserPage, adminUsersPage, page }) => { await adminCreateUserPage.fullNameInput.fill(testUser.fullName);
adminCreateUserPage.seed(9200); await adminCreateUserPage.emailInput.fill(testUser.email);
const testUser = adminCreateUserPage.generateUser(); await adminCreateUserPage.roleInput.click();
await adminCreateUserPage.page
.getByRole('option', { name: 'Admin' })
.click();
await adminCreateUserPage.createButton.click();
await adminCreateUserPage.expectCreateUserSuccessAlertToBeVisible();
});
await test.step( await test.step('Create the user again', async () => {
'Create the test user', await adminUsersPage.navigateTo();
async () => { await adminUsersPage.createUserButton.click();
await adminUsersPage.createUserButton.click(); await adminCreateUserPage.fullNameInput.fill(testUser.fullName);
await adminCreateUserPage.fullNameInput.fill(testUser.fullName); await adminCreateUserPage.emailInput.fill(testUser.email);
await adminCreateUserPage.emailInput.fill(testUser.email); const createUserPageUrl = page.url();
await adminCreateUserPage.roleInput.click(); await adminCreateUserPage.roleInput.click();
await adminCreateUserPage.page.getByRole( await adminCreateUserPage.page
'option', { name: 'Admin' } .getByRole('option', { name: 'Admin' })
).click(); .click();
await adminCreateUserPage.createButton.click(); await adminCreateUserPage.createButton.click();
const snackbar = await adminUsersPage.getSnackbarData(
'snackbar-create-user-success'
);
await expect(snackbar.variant).toBe('success');
await adminUsersPage.closeSnackbar();
}
);
await test.step( await expect(page.url()).toBe(createUserPageUrl);
'Create the user again', await expect(adminCreateUserPage.fieldError).toHaveCount(1);
async () => { });
await adminUsersPage.navigateTo(); });
await adminUsersPage.createUserButton.click();
await adminCreateUserPage.fullNameInput.fill(testUser.fullName);
await adminCreateUserPage.emailInput.fill(testUser.email);
const createUserPageUrl = page.url();
await adminCreateUserPage.roleInput.click();
await adminCreateUserPage.page.getByRole(
'option', { name: 'Admin' }
).click();
await adminCreateUserPage.createButton.click();
await expect(page.url()).toBe(createUserPageUrl); test('Editing a user to have the same email as another user should not be allowed', async ({
const snackbar = await adminUsersPage.getSnackbarData('snackbar-error'); adminCreateUserPage,
await expect(snackbar.variant).toBe('error'); adminEditUserPage,
await adminUsersPage.closeSnackbar(); adminUsersPage,
} page,
); }) => {
} adminCreateUserPage.seed(9300);
); const user1 = adminCreateUserPage.generateUser();
const user2 = adminCreateUserPage.generateUser();
await test.step('Create the first user', async () => {
await adminUsersPage.navigateTo();
await adminUsersPage.createUserButton.click();
await adminCreateUserPage.fullNameInput.fill(user1.fullName);
await adminCreateUserPage.emailInput.fill(user1.email);
await adminCreateUserPage.roleInput.click();
await adminCreateUserPage.page
.getByRole('option', { name: 'Admin' })
.click();
await adminCreateUserPage.createButton.click();
await adminCreateUserPage.expectCreateUserSuccessAlertToBeVisible();
});
test( await test.step('Create the second user', async () => {
'Editing a user to have the same email as another user should not be allowed', await adminUsersPage.navigateTo();
async ({ await adminUsersPage.createUserButton.click();
adminCreateUserPage, adminEditUserPage, adminUsersPage, page await adminCreateUserPage.fullNameInput.fill(user2.fullName);
}) => { await adminCreateUserPage.emailInput.fill(user2.email);
adminCreateUserPage.seed(9300); await adminCreateUserPage.roleInput.click();
const user1 = adminCreateUserPage.generateUser(); await adminCreateUserPage.page
const user2 = adminCreateUserPage.generateUser(); .getByRole('option', { name: 'Admin' })
await test.step( .click();
'Create the first user', await adminCreateUserPage.createButton.click();
async () => { await adminCreateUserPage.expectCreateUserSuccessAlertToBeVisible();
await adminUsersPage.navigateTo(); });
await adminUsersPage.createUserButton.click();
await adminCreateUserPage.fullNameInput.fill(user1.fullName);
await adminCreateUserPage.emailInput.fill(user1.email);
await adminCreateUserPage.roleInput.click();
await adminCreateUserPage.page.getByRole(
'option', { name: 'Admin' }
).click();
await adminCreateUserPage.createButton.click();
const snackbar = await adminUsersPage.getSnackbarData(
'snackbar-create-user-success'
);
await expect(snackbar.variant).toBe('success');
await adminUsersPage.closeSnackbar();
}
);
await test.step( await test.step('Try editing the second user to have the email of the first user', async () => {
'Create the second user', await adminUsersPage.navigateTo();
async () => { await adminUsersPage.findUserPageWithEmail(user2.email);
await adminUsersPage.navigateTo(); let userRow = await adminUsersPage.getUserRowByEmail(user2.email);
await adminUsersPage.createUserButton.click(); await adminUsersPage.clickEditUser(userRow);
await adminCreateUserPage.fullNameInput.fill(user2.fullName); await adminEditUserPage.waitForLoad(user2.fullName);
await adminCreateUserPage.emailInput.fill(user2.email); await adminEditUserPage.emailInput.fill(user1.email);
await adminCreateUserPage.roleInput.click(); const editPageUrl = page.url();
await adminCreateUserPage.page.getByRole( await adminEditUserPage.updateButton.click();
'option', { name: 'Admin' }
).click();
await adminCreateUserPage.createButton.click();
const snackbar = await adminUsersPage.getSnackbarData(
'snackbar-create-user-success'
);
await expect(snackbar.variant).toBe('success');
await adminUsersPage.closeSnackbar();
}
);
await test.step( const snackbar = await adminUsersPage.getSnackbarData('snackbar-error');
'Try editing the second user to have the email of the first user', await expect(snackbar.variant).toBe('error');
async () => { await adminUsersPage.closeSnackbar();
await adminUsersPage.navigateTo(); await expect(page.url()).toBe(editPageUrl);
await adminUsersPage.findUserPageWithEmail(user2.email); });
let userRow = await adminUsersPage.getUserRowByEmail(user2.email); });
await adminUsersPage.clickEditUser(userRow);
await adminEditUserPage.waitForLoad(user2.fullName);
await adminEditUserPage.emailInput.fill(user1.email);
const editPageUrl = page.url();
await adminEditUserPage.updateButton.click();
const snackbar = await adminUsersPage.getSnackbarData(
'snackbar-error'
);
await expect(snackbar.variant).toBe('error');
await adminUsersPage.closeSnackbar();
await expect(page.url()).toBe(editPageUrl);
}
);
}
);
}); });

View File

@@ -7,198 +7,191 @@ test('Ensure creating a new flow works', async ({ page }) => {
); );
}); });
test( test('Create a new flow with a Scheduler step then an Ntfy step', async ({
'Create a new flow with a Scheduler step then an Ntfy step', flowEditorPage,
async ({ flowEditorPage, page }) => { page,
await test.step('create flow', async () => { }) => {
await test.step('navigate to new flow page', async () => { await test.step('create flow', async () => {
await page.getByTestId('create-flow-button').click(); await test.step('navigate to new flow page', async () => {
await page.waitForURL( await page.getByTestId('create-flow-button').click();
/\/editor\/[0-9a-fA-F]{8}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{12}/ await page.waitForURL(
); /\/editor\/[0-9a-fA-F]{8}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{12}/
);
});
await test.step('has two steps by default', async () => {
await expect(page.getByTestId('flow-step')).toHaveCount(2);
});
});
await test.step('setup Scheduler trigger', async () => {
await test.step('choose app and event substep', async () => {
await test.step('choose application', async () => {
await flowEditorPage.appAutocomplete.click();
await page.getByRole('option', { name: 'Scheduler' }).click();
}); });
await test.step('has two steps by default', async () => { await test.step('choose and event', async () => {
await expect(page.getByTestId('flow-step')).toHaveCount(2); await expect(flowEditorPage.eventAutocomplete).toBeVisible();
await flowEditorPage.eventAutocomplete.click();
await page.getByRole('option', { name: 'Every hour' }).click();
});
await test.step('continue to next step', async () => {
await flowEditorPage.continueButton.click();
});
await test.step('collapses the substep', async () => {
await expect(flowEditorPage.appAutocomplete).not.toBeVisible();
await expect(flowEditorPage.eventAutocomplete).not.toBeVisible();
}); });
}); });
await test.step('setup Scheduler trigger', async () => { await test.step('set up a trigger', async () => {
await test.step('choose app and event substep', async () => { await test.step('choose "yes" in "trigger on weekends?"', async () => {
await test.step('choose application', async () => { await expect(flowEditorPage.trigger).toBeVisible();
await flowEditorPage.appAutocomplete.click(); await flowEditorPage.trigger.click();
await page await page.getByRole('option', { name: 'Yes' }).click();
.getByRole('option', { name: 'Scheduler' })
.click();
});
await test.step('choose and event', async () => {
await expect(flowEditorPage.eventAutocomplete).toBeVisible();
await flowEditorPage.eventAutocomplete.click();
await page
.getByRole('option', { name: 'Every hour' })
.click();
});
await test.step('continue to next step', async () => {
await flowEditorPage.continueButton.click();
});
await test.step('collapses the substep', async () => {
await expect(flowEditorPage.appAutocomplete).not.toBeVisible();
await expect(flowEditorPage.eventAutocomplete).not.toBeVisible();
});
}); });
await test.step('set up a trigger', async () => { await test.step('continue to next step', async () => {
await test.step('choose "yes" in "trigger on weekends?"', async () => { await flowEditorPage.continueButton.click();
await expect(flowEditorPage.trigger).toBeVisible();
await flowEditorPage.trigger.click();
await page.getByRole('option', { name: 'Yes' }).click();
});
await test.step('continue to next step', async () => {
await flowEditorPage.continueButton.click();
});
await test.step('collapses the substep', async () => {
await expect(flowEditorPage.trigger).not.toBeVisible();
});
}); });
await test.step('test trigger', async () => { await test.step('collapses the substep', async () => {
await test.step('show sample output', async () => { await expect(flowEditorPage.trigger).not.toBeVisible();
await expect(flowEditorPage.testOutput).not.toBeVisible();
await flowEditorPage.continueButton.click();
await expect(flowEditorPage.testOutput).toBeVisible();
await flowEditorPage.screenshot({
path: 'Scheduler trigger test output.png',
});
await flowEditorPage.continueButton.click();
});
}); });
}); });
await test.step('arrange Ntfy action', async () => { await test.step('test trigger', async () => {
await test.step('choose app and event substep', async () => { await test.step('show sample output', async () => {
await test.step('choose application', async () => { await expect(flowEditorPage.testOutput).not.toBeVisible();
await flowEditorPage.appAutocomplete.click(); await flowEditorPage.continueButton.click();
await page.getByRole('option', { name: 'Ntfy' }).click(); await expect(flowEditorPage.testOutput).toBeVisible();
});
await test.step('choose an event', async () => {
await expect(flowEditorPage.eventAutocomplete).toBeVisible();
await flowEditorPage.eventAutocomplete.click();
await page
.getByRole('option', { name: 'Send message' })
.click();
});
await test.step('continue to next step', async () => {
await flowEditorPage.continueButton.click();
});
await test.step('collapses the substep', async () => {
await expect(flowEditorPage.appAutocomplete).not.toBeVisible();
await expect(flowEditorPage.eventAutocomplete).not.toBeVisible();
});
});
await test.step('choose connection substep', async () => {
await test.step('choose connection list item', async () => {
await flowEditorPage.connectionAutocomplete.click();
await page.getByRole('option').first().click();
});
await test.step('continue to next step', async () => {
await flowEditorPage.continueButton.click();
});
await test.step('collapses the substep', async () => {
await expect(flowEditorPage.connectionAutocomplete).not.toBeVisible();
});
});
await test.step('set up action substep', async () => {
await test.step('fill topic and message body', async () => {
await page
.getByTestId('parameters.topic-power-input')
.locator('[contenteditable]')
.fill('Topic');
await page
.getByTestId('parameters.message-power-input')
.locator('[contenteditable]')
.fill('Message body');
});
await test.step('continue to next step', async () => {
await flowEditorPage.continueButton.click();
});
await test.step('collapses the substep', async () => {
await expect(flowEditorPage.connectionAutocomplete).not.toBeVisible();
});
});
await test.step('test trigger substep', async () => {
await test.step('show sample output', async () => {
await expect(flowEditorPage.testOutput).not.toBeVisible();
await page
.getByTestId('flow-substep-continue-button')
.first()
.click();
await expect(flowEditorPage.testOutput).toBeVisible();
await flowEditorPage.screenshot({
path: 'Ntfy action test output.png',
});
await flowEditorPage.continueButton.click();
});
});
});
await test.step('publish and unpublish', async () => {
await test.step('publish flow', async () => {
await expect(flowEditorPage.unpublishFlowButton).not.toBeVisible();
await expect(flowEditorPage.publishFlowButton).toBeVisible();
await flowEditorPage.publishFlowButton.click();
await expect(flowEditorPage.publishFlowButton).not.toBeVisible();
});
await test.step('shows read-only sticky snackbar', async () => {
await expect(flowEditorPage.infoSnackbar).toBeVisible();
await flowEditorPage.screenshot({ await flowEditorPage.screenshot({
path: 'Published flow.png', path: 'Scheduler trigger test output.png',
}); });
await flowEditorPage.continueButton.click();
});
});
});
await test.step('arrange Ntfy action', async () => {
await test.step('choose app and event substep', async () => {
await test.step('choose application', async () => {
await flowEditorPage.appAutocomplete.click();
await page.getByRole('option', { name: 'Ntfy' }).click();
}); });
await test.step('unpublish from snackbar', async () => { await test.step('choose an event', async () => {
await expect(flowEditorPage.eventAutocomplete).toBeVisible();
await flowEditorPage.eventAutocomplete.click();
await page.getByRole('option', { name: 'Send message' }).click();
});
await test.step('continue to next step', async () => {
await flowEditorPage.continueButton.click();
});
await test.step('collapses the substep', async () => {
await expect(flowEditorPage.appAutocomplete).not.toBeVisible();
await expect(flowEditorPage.eventAutocomplete).not.toBeVisible();
});
});
await test.step('choose connection substep', async () => {
await test.step('choose connection list item', async () => {
await flowEditorPage.connectionAutocomplete.click();
await page await page
.getByTestId('unpublish-flow-from-snackbar') .getByRole('option')
.filter({ hasText: 'Add new connection' })
.click(); .click();
await expect(flowEditorPage.infoSnackbar).not.toBeVisible();
}); });
await test.step('publish once again', async () => { await test.step('continue to next step', async () => {
await expect(flowEditorPage.publishFlowButton).toBeVisible(); await page.getByTestId('create-connection-button').click();
await flowEditorPage.publishFlowButton.click();
await expect(flowEditorPage.publishFlowButton).not.toBeVisible();
}); });
await test.step('unpublish from layout top bar', async () => { await test.step('collapses the substep', async () => {
await expect(flowEditorPage.unpublishFlowButton).toBeVisible(); await flowEditorPage.continueButton.click();
await flowEditorPage.unpublishFlowButton.click(); await expect(flowEditorPage.connectionAutocomplete).not.toBeVisible();
await expect(flowEditorPage.unpublishFlowButton).not.toBeVisible(); });
});
await test.step('set up action substep', async () => {
await test.step('fill topic and message body', async () => {
await page
.getByTestId('parameters.topic-power-input')
.locator('[contenteditable]')
.fill('Topic');
await page
.getByTestId('parameters.message-power-input')
.locator('[contenteditable]')
.fill('Message body');
});
await test.step('continue to next step', async () => {
await flowEditorPage.continueButton.click();
});
await test.step('collapses the substep', async () => {
await expect(flowEditorPage.connectionAutocomplete).not.toBeVisible();
});
});
await test.step('test trigger substep', async () => {
await test.step('show sample output', async () => {
await expect(flowEditorPage.testOutput).not.toBeVisible();
await page.getByTestId('flow-substep-continue-button').first().click();
await expect(flowEditorPage.testOutput).toBeVisible();
await flowEditorPage.screenshot({ await flowEditorPage.screenshot({
path: 'Unpublished flow.png', path: 'Ntfy action test output.png',
}); });
await flowEditorPage.continueButton.click();
});
});
});
await test.step('publish and unpublish', async () => {
await test.step('publish flow', async () => {
await expect(flowEditorPage.unpublishFlowButton).not.toBeVisible();
await expect(flowEditorPage.publishFlowButton).toBeVisible();
await flowEditorPage.publishFlowButton.click();
await expect(flowEditorPage.publishFlowButton).not.toBeVisible();
});
await test.step('shows read-only sticky snackbar', async () => {
await expect(flowEditorPage.infoSnackbar).toBeVisible();
await flowEditorPage.screenshot({
path: 'Published flow.png',
}); });
}); });
await test.step('in layout', async () => { await test.step('unpublish from snackbar', async () => {
await test.step('can go back to flows page', async () => { await page.getByTestId('unpublish-flow-from-snackbar').click();
await page.getByTestId('editor-go-back-button').click(); await expect(flowEditorPage.infoSnackbar).not.toBeVisible();
await expect(page).toHaveURL('/flows'); });
await test.step('publish once again', async () => {
await expect(flowEditorPage.publishFlowButton).toBeVisible();
await flowEditorPage.publishFlowButton.click();
await expect(flowEditorPage.publishFlowButton).not.toBeVisible();
});
await test.step('unpublish from layout top bar', async () => {
await expect(flowEditorPage.unpublishFlowButton).toBeVisible();
await flowEditorPage.unpublishFlowButton.click();
await expect(flowEditorPage.unpublishFlowButton).not.toBeVisible();
await flowEditorPage.screenshot({
path: 'Unpublished flow.png',
}); });
}); });
} });
);
await test.step('in layout', async () => {
await test.step('can go back to flows page', async () => {
await page.getByTestId('editor-go-back-button').click();
await expect(page).toHaveURL('/flows');
});
});
});

View File

@@ -33,10 +33,7 @@ publicTest.describe('My Profile', () => {
.getByRole('option', { name: 'Admin' }) .getByRole('option', { name: 'Admin' })
.click(); .click();
await adminCreateUserPage.createButton.click(); await adminCreateUserPage.createButton.click();
const snackbar = await adminUsersPage.getSnackbarData( await adminCreateUserPage.expectCreateUserSuccessAlertToBeVisible();
'snackbar-create-user-success'
);
await expect(snackbar.variant).toBe('success');
}); });
await publicTest.step('copy invitation link', async () => { await publicTest.step('copy invitation link', async () => {