feat: Move get users API endpoint to admin namespace
This commit is contained in:
@@ -1,6 +1,6 @@
|
|||||||
import { renderObject } from '../../../../helpers/renderer.js';
|
import { renderObject } from '../../../../../helpers/renderer.js';
|
||||||
import User from '../../../../models/user.js';
|
import User from '../../../../../models/user.js';
|
||||||
import paginateRest from '../../../../helpers/pagination-rest.js';
|
import paginateRest from '../../../../../helpers/pagination-rest.js';
|
||||||
|
|
||||||
export default async (request, response) => {
|
export default async (request, response) => {
|
||||||
const usersQuery = User.query()
|
const usersQuery = User.query()
|
@@ -1,26 +1,17 @@
|
|||||||
import { describe, it, expect, beforeEach } from 'vitest';
|
import { vi, describe, it, expect, beforeEach } from 'vitest';
|
||||||
import request from 'supertest';
|
import request from 'supertest';
|
||||||
import app from '../../../../app';
|
import app from '../../../../../app';
|
||||||
import createAuthTokenByUserId from '../../../../helpers/create-auth-token-by-user-id';
|
import createAuthTokenByUserId from '../../../../../helpers/create-auth-token-by-user-id';
|
||||||
import { createRole } from '../../../../../test/factories/role';
|
import { createRole } from '../../../../../../test/factories/role';
|
||||||
import { createPermission } from '../../../../../test/factories/permission';
|
import { createUser } from '../../../../../../test/factories/user';
|
||||||
import { createUser } from '../../../../../test/factories/user';
|
import getUsersMock from '../../../../../../test/mocks/rest/api/v1/admin/users/get-users.js';
|
||||||
import getUsersMock from '../../../../../test/mocks/rest/api/v1/users/get-users';
|
import * as license from '../../../../../helpers/license.ee.js';
|
||||||
|
|
||||||
describe('GET /api/v1/users', () => {
|
describe('GET /api/v1/admin/users', () => {
|
||||||
let currentUser, currentUserRole, anotherUser, anotherUserRole, token;
|
let currentUser, currentUserRole, anotherUser, anotherUserRole, token;
|
||||||
|
|
||||||
beforeEach(async () => {
|
beforeEach(async () => {
|
||||||
currentUserRole = await createRole({
|
currentUserRole = await createRole({ key: 'admin' });
|
||||||
key: 'currentUser',
|
|
||||||
name: 'Current user role',
|
|
||||||
});
|
|
||||||
|
|
||||||
await createPermission({
|
|
||||||
action: 'read',
|
|
||||||
subject: 'User',
|
|
||||||
roleId: currentUserRole.id,
|
|
||||||
});
|
|
||||||
|
|
||||||
currentUser = await createUser({
|
currentUser = await createUser({
|
||||||
roleId: currentUserRole.id,
|
roleId: currentUserRole.id,
|
||||||
@@ -41,8 +32,10 @@ describe('GET /api/v1/users', () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
it('should return users data', async () => {
|
it('should return users data', async () => {
|
||||||
|
vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true);
|
||||||
|
|
||||||
const response = await request(app)
|
const response = await request(app)
|
||||||
.get('/api/v1/users')
|
.get('/api/v1/admin/users')
|
||||||
.set('Authorization', token)
|
.set('Authorization', token)
|
||||||
.expect(200);
|
.expect(200);
|
||||||
|
|
17
packages/backend/src/routes/api/v1/admin/users.ee.js
Normal file
17
packages/backend/src/routes/api/v1/admin/users.ee.js
Normal file
@@ -0,0 +1,17 @@
|
|||||||
|
import { Router } from 'express';
|
||||||
|
import { authenticateUser } from '../../../../helpers/authentication.js';
|
||||||
|
import { authorizeAdmin } from '../../../../helpers/authorization.js';
|
||||||
|
import { checkIsEnterprise } from '../../../../helpers/check-is-enterprise.js';
|
||||||
|
import getUsersAction from '../../../../controllers/api/v1/admin/users/get-users.ee.js';
|
||||||
|
|
||||||
|
const router = Router();
|
||||||
|
|
||||||
|
router.get(
|
||||||
|
'/',
|
||||||
|
authenticateUser,
|
||||||
|
authorizeAdmin,
|
||||||
|
checkIsEnterprise,
|
||||||
|
getUsersAction
|
||||||
|
);
|
||||||
|
|
||||||
|
export default router;
|
@@ -4,12 +4,10 @@ import { authorizeUser } from '../../../helpers/authorization.js';
|
|||||||
import checkIsCloud from '../../../helpers/check-is-cloud.js';
|
import checkIsCloud from '../../../helpers/check-is-cloud.js';
|
||||||
import getCurrentUserAction from '../../../controllers/api/v1/users/get-current-user.js';
|
import getCurrentUserAction from '../../../controllers/api/v1/users/get-current-user.js';
|
||||||
import getUserAction from '../../../controllers/api/v1/users/get-user.js';
|
import getUserAction from '../../../controllers/api/v1/users/get-user.js';
|
||||||
import getUsersAction from '../../../controllers/api/v1/users/get-users.js';
|
|
||||||
import getUserTrialAction from '../../../controllers/api/v1/users/get-user-trial.ee.js';
|
import getUserTrialAction from '../../../controllers/api/v1/users/get-user-trial.ee.js';
|
||||||
|
|
||||||
const router = Router();
|
const router = Router();
|
||||||
|
|
||||||
router.get('/', authenticateUser, authorizeUser, getUsersAction);
|
|
||||||
router.get('/me', authenticateUser, getCurrentUserAction);
|
router.get('/me', authenticateUser, getCurrentUserAction);
|
||||||
router.get('/:userId', authenticateUser, authorizeUser, getUserAction);
|
router.get('/:userId', authenticateUser, authorizeUser, getUserAction);
|
||||||
router.get(
|
router.get(
|
||||||
|
@@ -9,6 +9,7 @@ import paymentRouter from './api/v1/payment.ee.js';
|
|||||||
import samlAuthProvidersRouter from './api/v1/admin/saml-auth-providers.ee.js';
|
import samlAuthProvidersRouter from './api/v1/admin/saml-auth-providers.ee.js';
|
||||||
import rolesRouter from './api/v1/admin/roles.ee.js';
|
import rolesRouter from './api/v1/admin/roles.ee.js';
|
||||||
import permissionsRouter from './api/v1/admin/permissions.ee.js';
|
import permissionsRouter from './api/v1/admin/permissions.ee.js';
|
||||||
|
import adminUsersRouter from './api/v1/admin/users.ee.js';
|
||||||
|
|
||||||
const router = Router();
|
const router = Router();
|
||||||
|
|
||||||
@@ -22,5 +23,6 @@ router.use('/api/v1/payment', paymentRouter);
|
|||||||
router.use('/api/v1/admin/saml-auth-providers', samlAuthProvidersRouter);
|
router.use('/api/v1/admin/saml-auth-providers', samlAuthProvidersRouter);
|
||||||
router.use('/api/v1/admin/roles', rolesRouter);
|
router.use('/api/v1/admin/roles', rolesRouter);
|
||||||
router.use('/api/v1/admin/permissions', permissionsRouter);
|
router.use('/api/v1/admin/permissions', permissionsRouter);
|
||||||
|
router.use('/api/v1/admin/users', adminUsersRouter);
|
||||||
|
|
||||||
export default router;
|
export default router;
|
||||||
|
Reference in New Issue
Block a user