From 51ccdf3577aae1034c972d0600d259138dd9c8e5 Mon Sep 17 00:00:00 2001 From: Ali BARIN Date: Thu, 8 Dec 2022 10:40:05 +0100 Subject: [PATCH] feat(webhook): do not process actions in test run --- packages/backend/src/controllers/webhooks/handler.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/backend/src/controllers/webhooks/handler.ts b/packages/backend/src/controllers/webhooks/handler.ts index c40a893a..15a8d2e1 100644 --- a/packages/backend/src/controllers/webhooks/handler.ts +++ b/packages/backend/src/controllers/webhooks/handler.ts @@ -13,12 +13,13 @@ export default async (request: IRequest, response: Response) => { .findById(request.params.flowId) .throwIfNotFound(); + const testRun = !flow.active; const triggerStep = await flow.getTriggerStep(); const triggerCommand = await triggerStep.getTriggerCommand(); const app = await triggerStep.getApp(); const isWebhookApp = app.key === 'webhook'; - if (!flow.active && !isWebhookApp) { + if (testRun && !isWebhookApp) { return response.sendStatus(404); } @@ -66,9 +67,13 @@ export default async (request: IRequest, response: Response) => { flowId: flow.id, stepId: triggerStep.id, triggerItem, - testRun: !flow.active + testRun }); + if (testRun) { + return response.sendStatus(200); + } + const nextStep = await triggerStep.getNextStep(); const jobName = `${executionId}-${nextStep.id}`;