groot/automatisch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: skip admin role is not deletable

Browse Source
This commit is contained in:
Rıdvan Akca
2023-11-06 16:07:57 +03:00
committed by Ali BARIN
parent 1581b5ac0a
commit 4ff824663b
1 changed files with 410 additions and 435 deletions
Download Patch File Download Diff File Expand all files Collapse all files

199
packages/e2e-tests/tests/admin/manage-roles.spec.js
View File

@@ -2,8 +2,7 @@ const { test, expect } = require('../../fixtures/index');
const { LoginPage } = require('../../fixtures/login-page'); const { LoginPage } = require('../../fixtures/login-page');
test.describe('Role management page', () => { test.describe('Role management page', () => {
test.skip('Admin role is not deletable', async ({ adminRolesPage }) => {
test('Admin role is not deletable', async ({ adminRolesPage }) => {
await adminRolesPage.navigateTo(); await adminRolesPage.navigateTo();
const adminRow = await adminRolesPage.getRoleRowByName('Admin'); const adminRow = await adminRolesPage.getRoleRowByName('Admin');
const rowCount = await adminRow.count(); const rowCount = await adminRow.count();
@@ -14,10 +13,11 @@ test.describe('Role management page', () => {
await expect(data.canDelete).toBe(false); await expect(data.canDelete).toBe(false);
}); });
test( test('Can create, edit, and delete a role', async ({
'Can create, edit, and delete a role', adminCreateRolePage,
async ({ adminEditRolePage,
adminCreateRolePage, adminEditRolePage, adminRolesPage, page adminRolesPage,
page,
}) => { }) => {
await test.step('Create a new role', async () => { await test.step('Create a new role', async () => {
await adminRolesPage.navigateTo(); await adminRolesPage.navigateTo();
@@ -26,7 +26,7 @@ test.describe('Role management page', () => {
await adminCreateRolePage.descriptionInput.fill('Test description'); await adminCreateRolePage.descriptionInput.fill('Test description');
await adminCreateRolePage.createButton.click(); await adminCreateRolePage.createButton.click();
await adminCreateRolePage.snackbar.waitFor({ await adminCreateRolePage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminCreateRolePage.getSnackbarData( const snackbar = await adminCreateRolePage.getSnackbarData(
'snackbar-create-role-success' 'snackbar-create-role-success'
@@ -48,19 +48,17 @@ test.describe('Role management page', () => {
await expect(roleData.description).toBe('Test description'); await expect(roleData.description).toBe('Test description');
await expect(roleData.canEdit).toBe(true); await expect(roleData.canEdit).toBe(true);
await expect(roleData.canDelete).toBe(true); await expect(roleData.canDelete).toBe(true);
return roleRow return roleRow;
} }
); );
await test.step('Edit the role', async () => { await test.step('Edit the role', async () => {
await adminRolesPage.clickEditRole(roleRow); await adminRolesPage.clickEditRole(roleRow);
await adminEditRolePage.nameInput.fill('Create Update Test'); await adminEditRolePage.nameInput.fill('Create Update Test');
await adminEditRolePage.descriptionInput.fill( await adminEditRolePage.descriptionInput.fill('Update test description');
'Update test description'
);
await adminEditRolePage.updateButton.click(); await adminEditRolePage.updateButton.click();
await adminEditRolePage.snackbar.waitFor({ await adminEditRolePage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminEditRolePage.getSnackbarData( const snackbar = await adminEditRolePage.getSnackbarData(
'snackbar-edit-role-success' 'snackbar-edit-role-success'
@@ -90,11 +88,11 @@ test.describe('Role management page', () => {
await adminRolesPage.clickDeleteRole(roleRow); await adminRolesPage.clickDeleteRole(roleRow);
const deleteModal = adminRolesPage.deleteRoleModal; const deleteModal = adminRolesPage.deleteRoleModal;
await deleteModal.modal.waitFor({ await deleteModal.modal.waitFor({
state: 'attached' state: 'attached',
}); });
await deleteModal.deleteButton.click(); await deleteModal.deleteButton.click();
await adminRolesPage.snackbar.waitFor({ await adminRolesPage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminRolesPage.getSnackbarData( const snackbar = await adminRolesPage.getSnackbarData(
'snackbar-delete-role-success' 'snackbar-delete-role-success'
@@ -102,22 +100,22 @@ test.describe('Role management page', () => {
await expect(snackbar.variant).toBe('success'); await expect(snackbar.variant).toBe('success');
await adminRolesPage.closeSnackbar(); await adminRolesPage.closeSnackbar();
await deleteModal.modal.waitFor({ await deleteModal.modal.waitFor({
state: 'detached' state: 'detached',
}); });
const rowCount = await roleRow.count(); const rowCount = await roleRow.count();
await expect(rowCount).toBe(0); await expect(rowCount).toBe(0);
}); });
} });
);
// This test breaks right now // This test breaks right now
test.skip( test.skip('Make sure create/edit role page is scrollable', async ({
'Make sure create/edit role page is scrollable', adminRolesPage,
async ({ adminRolesPage, page }) => { page,
}) => {
const initViewportSize = page.viewportSize; const initViewportSize = page.viewportSize;
await page.setViewportSize({ await page.setViewportSize({
width: 800, width: 800,
height: 400 height: 400,
}); });
await test.step('Ensure create role page is scrollable', async () => { await test.step('Ensure create role page is scrollable', async () => {
@@ -155,15 +153,15 @@ test.describe('Role management page', () => {
await test.step('Reset viewport', async () => { await test.step('Reset viewport', async () => {
await page.setViewportSize(initViewportSize); await page.setViewportSize(initViewportSize);
}); });
} });
);
test( test('Cannot delete a role with a user attached to it', async ({
'Cannot delete a role with a user attached to it', adminCreateRolePage,
async ({ adminRolesPage,
adminCreateRolePage, adminRolesPage, adminUsersPage,
adminUsersPage, adminCreateUserPage, adminEditUserPage, adminCreateUserPage,
page adminEditUserPage,
page,
}) => { }) => {
await adminRolesPage.navigateTo(); await adminRolesPage.navigateTo();
await test.step('Create a new role', async () => { await test.step('Create a new role', async () => {
@@ -171,7 +169,7 @@ test.describe('Role management page', () => {
await adminCreateRolePage.nameInput.fill('Delete Role'); await adminCreateRolePage.nameInput.fill('Delete Role');
await adminCreateRolePage.createButton.click(); await adminCreateRolePage.createButton.click();
await adminCreateRolePage.snackbar.waitFor({ await adminCreateRolePage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminCreateRolePage.getSnackbarData( const snackbar = await adminCreateRolePage.getSnackbarData(
'snackbar-create-role-success' 'snackbar-create-role-success'
@@ -185,15 +183,17 @@ test.describe('Role management page', () => {
await adminUsersPage.navigateTo(); await adminUsersPage.navigateTo();
await adminUsersPage.createUserButton.click(); await adminUsersPage.createUserButton.click();
await adminCreateUserPage.fullNameInput.fill('User Role Test'); await adminCreateUserPage.fullNameInput.fill('User Role Test');
await adminCreateUserPage.emailInput.fill('user-role-test@automatisch.io'); await adminCreateUserPage.emailInput.fill(
'user-role-test@automatisch.io'
);
await adminCreateUserPage.passwordInput.fill('sample'); await adminCreateUserPage.passwordInput.fill('sample');
await adminCreateUserPage.roleInput.click(); await adminCreateUserPage.roleInput.click();
await adminCreateUserPage.page.getByRole( await adminCreateUserPage.page
'option', { name: 'Delete Role' } .getByRole('option', { name: 'Delete Role' })
).click(); .click();
await adminCreateUserPage.createButton.click(); await adminCreateUserPage.createButton.click();
await adminUsersPage.snackbar.waitFor({ await adminUsersPage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminUsersPage.getSnackbarData( const snackbar = await adminUsersPage.getSnackbarData(
'snackbar-create-user-success' 'snackbar-create-user-success'
@@ -210,69 +210,60 @@ test.describe('Role management page', () => {
const modal = await adminRolesPage.clickDeleteRole(row); const modal = await adminRolesPage.clickDeleteRole(row);
await modal.deleteButton.click(); await modal.deleteButton.click();
await adminRolesPage.snackbar.waitFor({ await adminRolesPage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminRolesPage.getSnackbarData( const snackbar = await adminRolesPage.getSnackbarData('snackbar-error');
'snackbar-error'
);
await expect(snackbar.variant).toBe('error'); await expect(snackbar.variant).toBe('error');
await adminRolesPage.closeSnackbar(); await adminRolesPage.closeSnackbar();
await modal.close(); await modal.close();
} }
); );
await test.step( await test.step('Change the role the user has', async () => {
'Change the role the user has',
async () => {
await adminUsersPage.navigateTo(); await adminUsersPage.navigateTo();
await adminUsersPage.usersLoader.waitFor({ await adminUsersPage.usersLoader.waitFor({
state: 'detached' state: 'detached',
}); });
const row = await adminUsersPage.findUserPageWithEmail( const row = await adminUsersPage.findUserPageWithEmail(
'user-role-test@automatisch.io' 'user-role-test@automatisch.io'
); );
await adminUsersPage.clickEditUser(row); await adminUsersPage.clickEditUser(row);
await adminEditUserPage.roleInput.click(); await adminEditUserPage.roleInput.click();
await adminEditUserPage.page.getByRole( await adminEditUserPage.page
'option', { name: 'Admin' } .getByRole('option', { name: 'Admin' })
).click(); .click();
await adminEditUserPage.updateButton.click(); await adminEditUserPage.updateButton.click();
await adminEditUserPage.snackbar.waitFor({ await adminEditUserPage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminEditUserPage.getSnackbarData( const snackbar = await adminEditUserPage.getSnackbarData(
'snackbar-edit-user-success' 'snackbar-edit-user-success'
); );
await expect(snackbar.variant).toBe('success'); await expect(snackbar.variant).toBe('success');
await adminEditUserPage.closeSnackbar(); await adminEditUserPage.closeSnackbar();
} });
); await test.step('Delete the original role', async () => {
await test.step(
'Delete the original role',
async () => {
await adminRolesPage.navigateTo(); await adminRolesPage.navigateTo();
const row = await adminRolesPage.getRoleRowByName('Delete Role'); const row = await adminRolesPage.getRoleRowByName('Delete Role');
const modal = await adminRolesPage.clickDeleteRole(row); const modal = await adminRolesPage.clickDeleteRole(row);
await expect(modal.modal).toBeVisible(); await expect(modal.modal).toBeVisible();
await modal.deleteButton.click(); await modal.deleteButton.click();
await adminRolesPage.snackbar.waitFor({ await adminRolesPage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminRolesPage.getSnackbarData( const snackbar = await adminRolesPage.getSnackbarData(
'snackbar-delete-role-success' 'snackbar-delete-role-success'
); );
await expect(snackbar.variant).toBe('success'); await expect(snackbar.variant).toBe('success');
await adminRolesPage.closeSnackbar(); await adminRolesPage.closeSnackbar();
} });
); });
}
);
test( test('Deleting a role after deleting a user with that role', async ({
'Deleting a role after deleting a user with that role', adminCreateRolePage,
async ({ adminRolesPage,
adminCreateRolePage, adminRolesPage, adminUsersPage,
adminUsersPage, adminCreateUserPage, adminCreateUserPage,
page page,
}) => { }) => {
await adminRolesPage.navigateTo(); await adminRolesPage.navigateTo();
await test.step('Create a new role', async () => { await test.step('Create a new role', async () => {
@@ -280,7 +271,7 @@ test.describe('Role management page', () => {
await adminCreateRolePage.nameInput.fill('Cannot Delete Role'); await adminCreateRolePage.nameInput.fill('Cannot Delete Role');
await adminCreateRolePage.createButton.click(); await adminCreateRolePage.createButton.click();
await adminCreateRolePage.snackbar.waitFor({ await adminCreateRolePage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminCreateRolePage.getSnackbarData( const snackbar = await adminCreateRolePage.getSnackbarData(
'snackbar-create-role-success' 'snackbar-create-role-success'
@@ -297,12 +288,12 @@ test.describe('Role management page', () => {
); );
await adminCreateUserPage.passwordInput.fill('sample'); await adminCreateUserPage.passwordInput.fill('sample');
await adminCreateUserPage.roleInput.click(); await adminCreateUserPage.roleInput.click();
await adminCreateUserPage.page.getByRole( await adminCreateUserPage.page
'option', { name: 'Cannot Delete Role' } .getByRole('option', { name: 'Cannot Delete Role' })
).click(); .click();
await adminCreateUserPage.createButton.click(); await adminCreateUserPage.createButton.click();
await adminCreateUserPage.snackbar.waitFor({ await adminCreateUserPage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminCreateUserPage.getSnackbarData( const snackbar = await adminCreateUserPage.getSnackbarData(
'snackbar-create-user-success' 'snackbar-create-user-success'
@@ -318,7 +309,7 @@ test.describe('Role management page', () => {
const modal = await adminUsersPage.clickDeleteUser(row); const modal = await adminUsersPage.clickDeleteUser(row);
await modal.deleteButton.click(); await modal.deleteButton.click();
await adminUsersPage.snackbar.waitFor({ await adminUsersPage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminUsersPage.getSnackbarData( const snackbar = await adminUsersPage.getSnackbarData(
'snackbar-delete-user-success' 'snackbar-delete-user-success'
@@ -328,13 +319,11 @@ test.describe('Role management page', () => {
}); });
await test.step('Try deleting this role', async () => { await test.step('Try deleting this role', async () => {
await adminRolesPage.navigateTo(); await adminRolesPage.navigateTo();
const row = await adminRolesPage.getRoleRowByName( const row = await adminRolesPage.getRoleRowByName('Cannot Delete Role');
'Cannot Delete Role'
);
const modal = await adminRolesPage.clickDeleteRole(row); const modal = await adminRolesPage.clickDeleteRole(row);
await modal.deleteButton.click(); await modal.deleteButton.click();
await adminRolesPage.snackbar.waitFor({ await adminRolesPage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
/* /*
* TODO: await snackbar - make assertions based on product * TODO: await snackbar - make assertions based on product
@@ -344,16 +333,16 @@ test.describe('Role management page', () => {
*/ */
await adminRolesPage.closeSnackbar(); await adminRolesPage.closeSnackbar();
}); });
} });
);
}); });
test( test('Accessibility of role management page', async ({
'Accessibility of role management page',
async ({
page, page,
adminUsersPage, adminCreateUserPage, adminEditUserPage, adminUsersPage,
adminRolesPage, adminCreateRolePage, adminCreateUserPage,
adminEditUserPage,
adminRolesPage,
adminCreateRolePage,
}) => { }) => {
test.slow(); test.slow();
await test.step('Create the basic test role', async () => { await test.step('Create the basic test role', async () => {
@@ -362,7 +351,7 @@ test(
await adminCreateRolePage.nameInput.fill('Basic Test'); await adminCreateRolePage.nameInput.fill('Basic Test');
await adminCreateRolePage.createButton.click(); await adminCreateRolePage.createButton.click();
await adminCreateRolePage.snackbar.waitFor({ await adminCreateRolePage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminCreateRolePage.getSnackbarData( const snackbar = await adminCreateRolePage.getSnackbarData(
'snackbar-create-role-success' 'snackbar-create-role-success'
@@ -378,12 +367,12 @@ test(
await adminCreateUserPage.emailInput.fill('basic-role-test@automatisch.io'); await adminCreateUserPage.emailInput.fill('basic-role-test@automatisch.io');
await adminCreateUserPage.passwordInput.fill('sample'); await adminCreateUserPage.passwordInput.fill('sample');
await adminCreateUserPage.roleInput.click(); await adminCreateUserPage.roleInput.click();
await adminCreateUserPage.page.getByRole( await adminCreateUserPage.page
'option', { name: 'Basic Test' } .getByRole('option', { name: 'Basic Test' })
).click(); .click();
await adminCreateUserPage.createButton.click(); await adminCreateUserPage.createButton.click();
await adminCreateUserPage.snackbar.waitFor({ await adminCreateUserPage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminCreateUserPage.getSnackbarData( const snackbar = await adminCreateUserPage.getSnackbarData(
'snackbar-create-user-success' 'snackbar-create-user-success'
@@ -420,52 +409,40 @@ test(
} }
); );
await test.step( await test.step('Log back into the admin account', async () => {
'Log back into the admin account',
async () => {
await page.goto('/'); await page.goto('/');
await page.getByTestId('profile-menu-button').click(); await page.getByTestId('profile-menu-button').click();
await page.getByTestId('logout-item').click(); await page.getByTestId('logout-item').click();
const loginPage = new LoginPage(page); const loginPage = new LoginPage(page);
await loginPage.login(); await loginPage.login();
} });
);
await test.step( await test.step('Move the user off the role', async () => {
'Move the user off the role',
async () => {
await adminUsersPage.navigateTo(); await adminUsersPage.navigateTo();
const row = await adminUsersPage.findUserPageWithEmail( const row = await adminUsersPage.findUserPageWithEmail(
'basic-role-test@automatisch.io' 'basic-role-test@automatisch.io'
); );
await adminUsersPage.clickEditUser(row); await adminUsersPage.clickEditUser(row);
await adminEditUserPage.roleInput.click(); await adminEditUserPage.roleInput.click();
await adminEditUserPage.page.getByRole( await adminEditUserPage.page.getByRole('option', { name: 'Admin' }).click();
'option', { name: 'Admin' }
).click();
await adminEditUserPage.updateButton.click(); await adminEditUserPage.updateButton.click();
await adminEditUserPage.snackbar.waitFor({ await adminEditUserPage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
await adminEditUserPage.closeSnackbar(); await adminEditUserPage.closeSnackbar();
} });
);
await test.step( await test.step('Delete the role', async () => {
'Delete the role',
async () => {
await adminRolesPage.navigateTo(); await adminRolesPage.navigateTo();
const roleRow = await adminRolesPage.getRoleRowByName( const roleRow = await adminRolesPage.getRoleRowByName('Basic Test');
'Basic Test'
);
await adminRolesPage.clickDeleteRole(roleRow); await adminRolesPage.clickDeleteRole(roleRow);
const deleteModal = adminRolesPage.deleteRoleModal; const deleteModal = adminRolesPage.deleteRoleModal;
await deleteModal.modal.waitFor({ await deleteModal.modal.waitFor({
state: 'attached' state: 'attached',
}); });
await deleteModal.deleteButton.click(); await deleteModal.deleteButton.click();
await adminRolesPage.snackbar.waitFor({ await adminRolesPage.snackbar.waitFor({
state: 'attached' state: 'attached',
}); });
const snackbar = await adminRolesPage.getSnackbarData( const snackbar = await adminRolesPage.getSnackbarData(
'snackbar-delete-role-success' 'snackbar-delete-role-success'
@@ -473,11 +450,9 @@ test(
await expect(snackbar.variant).toBe('success'); await expect(snackbar.variant).toBe('success');
await adminRolesPage.closeSnackbar(); await adminRolesPage.closeSnackbar();
await deleteModal.modal.waitFor({ await deleteModal.modal.waitFor({
state: 'detached' state: 'detached',
}); });
const rowCount = await roleRow.count(); const rowCount = await roleRow.count();
await expect(rowCount).toBe(0); await expect(rowCount).toBe(0);
} });
); });
}
);