groot/automatisch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #698 from automatisch/issue-695

Browse Source 
feat(web): hide empty error tab in execution step
This commit is contained in:
Ömer Faruk Aydın
2022-11-08 23:30:48 +01:00
committed by GitHub
parent e9e7b679f4 bdb7a1b840
commit 41de2aa769
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/web/src/components/ExecutionStep/index.tsx
View File

@@ -51,6 +51,7 @@ export default function ExecutionStep(
const validationStatusIcon = const validationStatusIcon =
executionStep.status === 'success' ? validIcon : errorIcon; executionStep.status === 'success' ? validIcon : errorIcon;
const hasError = !!executionStep.errorDetails;
return ( return (
<Wrapper elevation={1} data-test="execution-step"> <Wrapper elevation={1} data-test="execution-step">
@@ -86,7 +87,7 @@ export default function ExecutionStep(
> >
<Tab label="Data in" data-test="data-in-tab" /> <Tab label="Data in" data-test="data-in-tab" />
<Tab label="Data out" data-test="data-out-tab" /> <Tab label="Data out" data-test="data-out-tab" />
<Tab label="Error" data-test="error-tab" /> {hasError && <Tab label="Error" data-test="error-tab" />}
</Tabs> </Tabs>
</Box> </Box>
@@ -98,9 +99,11 @@ export default function ExecutionStep(
<JSONViewer data={executionStep.dataOut} /> <JSONViewer data={executionStep.dataOut} />
</TabPanel> </TabPanel>
<TabPanel value={activeTabIndex} index={2}> {hasError && (
<JSONViewer data={executionStep.errorDetails} /> <TabPanel value={activeTabIndex} index={2}>
</TabPanel> <JSONViewer data={executionStep.errorDetails} />
</TabPanel>
)}
</Content> </Content>
</Wrapper> </Wrapper>
); );