groot/automatisch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Remove early exit strategy for twitter triggers

Browse Source
This commit is contained in:
Faruk AYDIN
2022-10-12 23:16:25 +02:00
committed by Ali BARIN
parent d9192f6e6b
commit 3c3bb82e97
4 changed files with 28 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
packages/backend/src/apps/twitter/common/get-user-followers.ts
View File

@@ -49,22 +49,19 @@ const getUserFollowers = async (
} }
if (response.data.meta.result_count > 0) { if (response.data.meta.result_count > 0) {
response.data.data.forEach((tweet: IJSONObject) => { response.data.data.forEach((follower: IJSONObject) => {
if ( followers.data.push({
!options.lastInternalId || raw: follower,
Number(tweet.id) > Number(options.lastInternalId) meta: { internalId: follower.id as string },
) { });
followers.data.push({
raw: tweet,
meta: { internalId: tweet.id as string },
});
} else {
return;
}
}); });
} }
} while (response.data.meta.next_token && options.lastInternalId); } while (response.data.meta.next_token && options.lastInternalId);
followers.data.sort((follower, nextFollower) => {
return (follower.raw.id as number) - (nextFollower.raw.id as number);
});
return followers; return followers;
}; };

19
packages/backend/src/apps/twitter/common/get-user-tweets.ts
View File

@@ -61,21 +61,18 @@ const getUserTweets = async (
if (response.data.meta.result_count > 0) { if (response.data.meta.result_count > 0) {
response.data.data.forEach((tweet: IJSONObject) => { response.data.data.forEach((tweet: IJSONObject) => {
if ( tweets.data.push({
!options.lastInternalId || raw: tweet,
Number(tweet.id) > Number(options.lastInternalId) meta: { internalId: tweet.id as string },
) { });
tweets.data.push({
raw: tweet,
meta: { internalId: tweet.id as string },
});
} else {
return;
}
}); });
} }
} while (response.data.meta.next_token && options.lastInternalId); } while (response.data.meta.next_token && options.lastInternalId);
tweets.data.sort((tweet, nextTweet) => {
return (tweet.raw.id as number) - (nextTweet.raw.id as number);
});
return tweets; return tweets;
}; };

25
packages/backend/src/apps/twitter/triggers/search-tweets/search-tweets.ts
View File

@@ -52,25 +52,22 @@ const searchTweets = async (
if (response.data.meta.result_count > 0) { if (response.data.meta.result_count > 0) {
response.data.data.forEach((tweet: IJSONObject) => { response.data.data.forEach((tweet: IJSONObject) => {
if ( const dataItem = {
!options.lastInternalId || raw: tweet,
Number(tweet.id) > Number(options.lastInternalId) meta: {
) { internalId: tweet.id as string,
const dataItem = { },
raw: tweet, };
meta: {
internalId: tweet.id as string,
},
};
tweets.data.push(dataItem); tweets.data.push(dataItem);
} else {
return;
}
}); });
} }
} while (response.data.meta.next_token && options.lastInternalId); } while (response.data.meta.next_token && options.lastInternalId);
tweets.data.sort((tweet, nextTweet) => {
return (tweet.raw.id as number) - (nextTweet.raw.id as number);
});
return tweets; return tweets;
}; };

8
packages/backend/src/services/processor.ts
View File

@@ -59,14 +59,6 @@ class Processor {
initialTriggerData.data = [initialTriggerData.data[0]]; initialTriggerData.data = [initialTriggerData.data[0]];
} }
if (initialTriggerData.data.length > 1) {
initialTriggerData.data = initialTriggerData.data.sort(
(item, nextItem) => {
return (item.raw.id as number) - (nextItem.raw.id as number);
}
);
}
const executions: Execution[] = []; const executions: Execution[] = [];
for await (const data of initialTriggerData.data) { for await (const data of initialTriggerData.data) {