groot/automatisch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: iterate array, not generator in auth steps

Browse Source
This commit is contained in:
Ali BARIN
2021-10-15 18:34:48 +02:00
parent 9cc10f6346
commit 3a44cf5f86
1 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/web/src/components/AddAppConnection/index.tsx
View File

@@ -21,14 +21,6 @@ type Response = {
[key: string]: any; [key: string]: any;
} }
function* authStepGenerator(steps: any[]) {
for (const step of steps) {
yield step;
}
return;
}
export default function AddAppConnection(props: AddAppConnectionProps){ export default function AddAppConnection(props: AddAppConnectionProps){
const { application, onClose } = props; const { application, onClose } = props;
const { key, fields, authenticationSteps } = application; const { key, fields, authenticationSteps } = application;
@@ -46,16 +38,16 @@ export default function AddAppConnection(props: AddAppConnectionProps){
fields: data, fields: data,
}; };
const stepGenerator = authStepGenerator(authenticationSteps); let stepIndex = 0;
while (stepIndex < authenticationSteps.length) {
let authenticationStep; const step = authenticationSteps[stepIndex];
while (!(authenticationStep = stepGenerator.next()).done) {
const step = authenticationStep.value;
const variables = computeAuthStepVariables(step, response); const variables = computeAuthStepVariables(step, response);
const stepResponse = await processStep(step, variables); const stepResponse = await processStep(step, variables);
response[step.name] = stepResponse; response[step.name] = stepResponse;
stepIndex++;
} }
onClose?.(); onClose?.();