feat: remove helperText if there is no error

This commit is contained in:
Rıdvan Akca
2023-03-03 18:40:55 +03:00
parent d061eb7b58
commit 394e747a88

View File

@@ -15,8 +15,8 @@ import { yupResolver } from '@hookform/resolvers/yup';
import { LOGIN } from 'graphql/mutations/login'; import { LOGIN } from 'graphql/mutations/login';
const validationSchema = yup.object().shape({ const validationSchema = yup.object().shape({
fullName: yup.string().required(), fullName: yup.string().trim().required(),
email: yup.string().email().required(), email: yup.string().trim().email().required(),
password: yup.string().required(), password: yup.string().required(),
confirmPassword: yup confirmPassword: yup
.string() .string()
@@ -24,7 +24,7 @@ const validationSchema = yup.object().shape({
.oneOf([yup.ref('password')], 'Passwords must match'), .oneOf([yup.ref('password')], 'Passwords must match'),
}); });
const initialValue = { const initialValues = {
fullName: '', fullName: '',
email: '', email: '',
password: '', password: '',
@@ -79,7 +79,7 @@ function SignUpForm() {
</Typography> </Typography>
<Form <Form
defaultValues={initialValue} defaultValues={initialValues}
onSubmit={handleSubmit} onSubmit={handleSubmit}
resolver={yupResolver(validationSchema)} resolver={yupResolver(validationSchema)}
mode="onChange" mode="onChange"
@@ -93,7 +93,9 @@ function SignUpForm() {
autoComplete="fullName" autoComplete="fullName"
data-test="fullName-text-field" data-test="fullName-text-field"
error={touchedFields.fullName && !!errors?.fullName} error={touchedFields.fullName && !!errors?.fullName}
helperText={errors?.fullName?.message || ' '} helperText={
(touchedFields.fullName && errors?.fullName?.message) || ''
}
/> />
<TextField <TextField
@@ -104,7 +106,7 @@ function SignUpForm() {
autoComplete="email" autoComplete="email"
data-test="email-text-field" data-test="email-text-field"
error={touchedFields.email && !!errors?.email} error={touchedFields.email && !!errors?.email}
helperText={errors?.email?.message || ' '} helperText={(touchedFields.email && errors?.email?.message) || ''}
/> />
<TextField <TextField
@@ -114,7 +116,9 @@ function SignUpForm() {
margin="dense" margin="dense"
type="password" type="password"
error={touchedFields.password && !!errors?.password} error={touchedFields.password && !!errors?.password}
helperText={errors?.password?.message || ' '} helperText={
(touchedFields.password && errors?.password?.message) || ''
}
/> />
<TextField <TextField
@@ -124,7 +128,11 @@ function SignUpForm() {
margin="dense" margin="dense"
type="password" type="password"
error={touchedFields.confirmPassword && !!errors?.confirmPassword} error={touchedFields.confirmPassword && !!errors?.confirmPassword}
helperText={errors?.confirmPassword?.message || ' '} helperText={
(touchedFields.confirmPassword &&
errors?.confirmPassword?.message) ||
''
}
/> />
<LoadingButton <LoadingButton