fix: do not update step on initial render

This commit is contained in:
Ali BARIN
2022-01-28 16:17:23 +01:00
committed by Ömer Faruk Aydın
parent bb3183959e
commit 3925de13a7
3 changed files with 67 additions and 14 deletions

View File

@@ -37,6 +37,7 @@ const getOption = (options: Record<string, unknown>[], appKey: string) => option
export default function FlowStep(props: FlowStepProps): React.ReactElement | null {
const { collapsed, index, onChange } = props;
const [step, setStep] = React.useState<Step>(props.step);
const initialRender = React.useRef<boolean>(true);
const formatMessage = useFormatMessage();
const [currentSubstep, setCurrentSubstep] = React.useState<number | null>(0);
const { data } = useQuery(GET_APPS)
@@ -44,11 +45,24 @@ export default function FlowStep(props: FlowStepProps): React.ReactElement | nul
// emit the step change to the parent component
React.useEffect(() => {
onChange?.(step);
if (!initialRender.current) {
onChange?.(step);
} else {
initialRender.current = false;
}
}, [step, onChange]);
const appAndEventOptions = React.useMemo(() => apps?.map(optionGenerator), [apps]);
const onAppAndEventChange = React.useCallback((event: React.SyntheticEvent, selectedOption: unknown) => {
if (typeof selectedOption === 'object') {
const typedSelectedOption = selectedOption as { value: string; };
const option: { value: string } = typedSelectedOption;
const appKey = option.value as string;
setStep((step) => ({ ...step, appKey }));
}
}, []);
if (!apps) return null;
const app = apps.find((currentApp: App) => currentApp.key === step.appKey);
@@ -58,16 +72,6 @@ export default function FlowStep(props: FlowStepProps): React.ReactElement | nul
const toggleSubstep = (substepIndex: number) => setCurrentSubstep((value) => value !== substepIndex ? substepIndex : null);
const onAppAndEventChange = (event: React.SyntheticEvent, selectedOption: unknown) => {
if (typeof selectedOption === 'object') {
const typedSelectedOption = selectedOption as { value: string; };
const option: { value: string } = typedSelectedOption;
const appKey = option.value as string;
const updatedStep = { ...step, appKey };
setStep(updatedStep);
}
}
return (
<Wrapper elevation={collapsed ? 1 : 4} onClick={onOpen}>
<Header collapsed={collapsed}>